From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vaishali Thakkar <vaishali.thakkar@oracle.com>
Subject: Re: [PATCH] drm/msm: Move call to PTR_ERR_OR_ZERO after reassignment
Date: Thu, 28 Apr 2016 18:53:27 +0530
Message-ID: <57220ECF.5000005@oracle.com>
References: <1461756097-20799-1-git-send-email-vaishali.thakkar@oracle.com>
 <20160428125301.GY32731@imgtec.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 63D906ECF1
 for <dri-devel@lists.freedesktop.org>; Thu, 28 Apr 2016 13:23:46 +0000 (UTC)
In-Reply-To: <20160428125301.GY32731@imgtec.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Eric Engestrom <eric.engestrom@imgtec.com>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

CgpPbiBUaHVyc2RheSAyOCBBcHJpbCAyMDE2IDA2OjIzIFBNLCBFcmljIEVuZ2VzdHJvbSB3cm90
ZToKPiBPbiBXZWQsIEFwciAyNywgMjAxNiBhdCAwNDo1MTozN1BNICswNTMwLCBWYWlzaGFsaSBU
aGFra2FyIHdyb3RlOgo+PiBIZXJlLCBhIGxvY2F0aW9uIGlzIHJlc2V0IHRvIE5VTEwgYmVmb3Jl
IGJlaW5nIHBhc3NlZCB0byBQVFJfRVJSLgo+PiBTbywgUFRSX0VSUiBzaG91bGQgYmUgY2FsbGVk
IGJlZm9yZSBpdHMgYXJndW1lbnQgaXMgcmVhc3NpZ25lZAo+PiB0byBOVUxMLiBGdXJ0aGVyIHRv
IHNpbXBsaWZ5IHRoaW5ncyB1c2UgUFRSX0VSUl9PUl9aRVJPIGluc3RlYWQKPj4gb2YgUFRSX0VS
UiBhbmQgSVNfRVJSLgo+Pgo+PiBQcm9ibGVtIGZvdW5kIHVzaW5nIENvY2NpbmVsbGUuCj4+Cj4+
IFNpZ25lZC1vZmYtYnk6IFZhaXNoYWxpIFRoYWtrYXIgPHZhaXNoYWxpLnRoYWtrYXJAb3JhY2xl
LmNvbT4KPj4gLS0tCj4+ICBkcml2ZXJzL2dwdS9kcm0vbXNtL2VkcC9lZHBfY3RybC5jIHwgMTYg
KysrKysrKysrLS0tLS0tLQo+PiAgMSBmaWxlIGNoYW5nZWQsIDkgaW5zZXJ0aW9ucygrKSwgNyBk
ZWxldGlvbnMoLSkKPj4KPj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZWRwL2Vk
cF9jdHJsLmMgYi9kcml2ZXJzL2dwdS9kcm0vbXNtL2VkcC9lZHBfY3RybC5jCj4+IGluZGV4IDgx
MjAwZTkuLjc4MTY1NDEgMTAwNjQ0Cj4+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9tc20vZWRwL2Vk
cF9jdHJsLmMKPj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL21zbS9lZHAvZWRwX2N0cmwuYwo+PiBA
QCAtMzAyLDIxICszMDIsMjMgQEAgc3RhdGljIHZvaWQgZWRwX2Nsa19kaXNhYmxlKHN0cnVjdCBl
ZHBfY3RybCAqY3RybCwgdTMyIGNsa19tYXNrKQo+PiAgc3RhdGljIGludCBlZHBfcmVndWxhdG9y
X2luaXQoc3RydWN0IGVkcF9jdHJsICpjdHJsKQo+PiAgewo+PiAgCXN0cnVjdCBkZXZpY2UgKmRl
diA9ICZjdHJsLT5wZGV2LT5kZXY7Cj4+ICsJaW50IHJldDsKPj4gIAo+PiAgCURCRygiIik7Cj4+
ICAJY3RybC0+dmRkYV92cmVnID0gZGV2bV9yZWd1bGF0b3JfZ2V0KGRldiwgInZkZGEiKTsKPj4g
LQlpZiAoSVNfRVJSKGN0cmwtPnZkZGFfdnJlZykpIHsKPj4gKwlyZXQgPSBQVFJfRVJSX09SX1pF
Uk8oY3RybC0+dmRkYV92cmVnKTsKPj4gKwlpZiAocmV0KSB7Cj4+ICAJCXByX2VycigiJXM6IENv
dWxkIG5vdCBnZXQgdmRkYSByZWcsIHJldCA9ICVsZFxuIiwgX19mdW5jX18sCj4+IC0JCQkJUFRS
X0VSUihjdHJsLT52ZGRhX3ZyZWcpKTsKPj4gKwkJCQlyZXQpOwo+PiAgCQljdHJsLT52ZGRhX3Zy
ZWcgPSBOVUxMOwo+PiAtCQlyZXR1cm4gUFRSX0VSUihjdHJsLT52ZGRhX3ZyZWcpOwo+PiArCQly
ZXR1cm4gcmV0Owo+PiAgCX0KPj4gIAljdHJsLT5sdmxfdnJlZyA9IGRldm1fcmVndWxhdG9yX2dl
dChkZXYsICJsdmwtdmRkIik7Cj4+IC0JaWYgKElTX0VSUihjdHJsLT5sdmxfdnJlZykpIHsKPj4g
LQkJcHJfZXJyKCJDb3VsZCBub3QgZ2V0IGx2bC12ZGQgcmVnLCAlbGQiLAo+PiAtCQkJCVBUUl9F
UlIoY3RybC0+bHZsX3ZyZWcpKTsKPj4gKwlyZXQgPSBQVFJfRVJSX09SX1pFUk8oY3RybC0+bHZs
X3ZyZWcpOwo+PiArCWlmIChyZXQpIHsKPiAKPiBXaGlsZSB5b3UncmUgcmV3cml0aW5nIHRoZW0s
IGl0IG1pZ2h0IGJlIHdvcnRoIG1ha2luZyB0aGVzZSB0d28gcHJfZXJyKCkKPiBwcmludCB0aGUg
c2FtZSBmb3JtYXQsIGUuZy46Cj4gCj4gCXByX2VycigiJXM6IENvdWxkIG5vdCBnZXQgbHZsLXZk
ZCByZWcsIHJldCA9ICVsZFxuIiwgX19mdW5jX18sIHJldCk7CgpEb25lLCB0aGFua3MuCgo+PiAr
CQlwcl9lcnIoIkNvdWxkIG5vdCBnZXQgbHZsLXZkZCByZWcsICVsZCIsIHJldCk7Cj4+ICAJCWN0
cmwtPmx2bF92cmVnID0gTlVMTDsKPj4gLQkJcmV0dXJuIFBUUl9FUlIoY3RybC0+bHZsX3ZyZWcp
Owo+PiArCQlyZXR1cm4gcmV0Owo+PiAgCX0KPj4gIAo+PiAgCXJldHVybiAwOwo+PiAtLSAKPj4g
Mi4xLjQKPiAKPiBSZXZpZXdlZC1ieTogRXJpYyBFbmdlc3Ryb20gPGVyaWMuZW5nZXN0cm9tQGlt
Z3RlYy5jb20+Cj4gCgotLSAKVmFpc2hhbGkKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vZHJpLWRldmVsCg==