From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Cc: peter.ujfalusi@ti.com, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH 2/4] drm/omapdrm: Add gamma table support to DSS dispc
Date: Fri, 20 May 2016 16:23:03 +0300 [thread overview]
Message-ID: <573F0FB7.1010104@ti.com> (raw)
In-Reply-To: <573F0DCC.9040500@ti.com>
[-- Attachment #1.1.1: Type: text/plain, Size: 570 bytes --]
On 20/05/16 16:14, Jyri Sarha wrote:
> On 05/20/16 15:51, Tomi Valkeinen wrote:
>>> +u32 dispc_mgr_gamma_size(enum omap_channel channel)
>>>> +{
>>>> + const struct dispc_gamma_desc *gdesc = &mgr_desc[channel].gamma;
>>>> +
>>>> + if (!dss_has_feature(FEAT_GAMMA_TABLE))
>>>> + return 0;
>>>> +
>> This should probably check the availability of LCD2/LCD3?
>>
>
> That would be a double check (the function should never be called with
> channels that are not there), but I am happy to add it.
>
True, I think we can trust omapdrm here =).
Tomi
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-05-20 13:23 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 6:35 [PATCH 0/4] drm/omapdrm: gamma table support Jyri Sarha
2016-05-20 6:35 ` [PATCH 1/4] drm/omapdrm: omap_modeset_init: Separate crtc id and plane id indexing Jyri Sarha
2016-05-20 12:14 ` Tomi Valkeinen
2016-05-20 6:35 ` [PATCH 2/4] drm/omapdrm: Add gamma table support to DSS dispc Jyri Sarha
2016-05-20 12:51 ` Tomi Valkeinen
2016-05-20 13:14 ` Jyri Sarha
2016-05-20 13:23 ` Tomi Valkeinen [this message]
2016-05-20 6:35 ` [PATCH 3/4] drm/omapdrm: Work-a-round for errata i734 (LCD1 Gamma) in " Jyri Sarha
2016-05-20 13:21 ` Tomi Valkeinen
2016-05-23 9:50 ` Jyri Sarha
2016-05-23 11:00 ` Tomi Valkeinen
2016-05-20 6:35 ` [PATCH 4/4] drm/omapdrm: Implement gamma_lut atomic crtc property Jyri Sarha
2016-05-20 7:05 ` Daniel Vetter
2016-05-20 7:35 ` Jyri Sarha
2016-05-20 8:14 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=573F0FB7.1010104@ti.com \
--to=tomi.valkeinen@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jsarha@ti.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peter.ujfalusi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).