From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCH 2/4] drm/omapdrm: Add gamma table support to DSS dispc Date: Fri, 20 May 2016 16:23:03 +0300 Message-ID: <573F0FB7.1010104@ti.com> References: <573F0868.8090700@ti.com> <573F0DCC.9040500@ti.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1324387345==" Return-path: Received: from comal.ext.ti.com (comal.ext.ti.com [198.47.26.152]) by gabe.freedesktop.org (Postfix) with ESMTPS id C4BEE6EAC9 for ; Fri, 20 May 2016 13:23:11 +0000 (UTC) In-Reply-To: <573F0DCC.9040500@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: peter.ujfalusi@ti.com, laurent.pinchart@ideasonboard.com List-Id: dri-devel@lists.freedesktop.org --===============1324387345== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="OKPx4QVr3ewXGW0xSRKhQH60qQCrdm61G" --OKPx4QVr3ewXGW0xSRKhQH60qQCrdm61G Content-Type: multipart/mixed; boundary="Rr2vtPOhTwmQq3gnti27Cw0BjuTObkaDI" From: Tomi Valkeinen To: Jyri Sarha , dri-devel@lists.freedesktop.org Cc: airlied@linux.ie, daniel@ffwll.ch, peter.ujfalusi@ti.com, bparrot@ti.com, laurent.pinchart@ideasonboard.com Message-ID: <573F0FB7.1010104@ti.com> Subject: Re: [PATCH 2/4] drm/omapdrm: Add gamma table support to DSS dispc References: <573F0868.8090700@ti.com> <573F0DCC.9040500@ti.com> In-Reply-To: <573F0DCC.9040500@ti.com> --Rr2vtPOhTwmQq3gnti27Cw0BjuTObkaDI Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 20/05/16 16:14, Jyri Sarha wrote: > On 05/20/16 15:51, Tomi Valkeinen wrote: >>> +u32 dispc_mgr_gamma_size(enum omap_channel channel) >>>> +{ >>>> + const struct dispc_gamma_desc *gdesc =3D &mgr_desc[channel].gamma;= >>>> + >>>> + if (!dss_has_feature(FEAT_GAMMA_TABLE)) >>>> + return 0; >>>> + >> This should probably check the availability of LCD2/LCD3? >> >=20 > That would be a double check (the function should never be called with > channels that are not there), but I am happy to add it. >=20 True, I think we can trust omapdrm here =3D). Tomi --Rr2vtPOhTwmQq3gnti27Cw0BjuTObkaDI-- --OKPx4QVr3ewXGW0xSRKhQH60qQCrdm61G Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXPw+3AAoJEPo9qoy8lh71JtIP/1w1PvdFv+Lp0sIhg3Xc+YYO bsXPEJZw24s4sV0LmrhC1gzcrZFrTRsSOCl15HfvHGpX3mOdv9F7uOEDXOytcTVm GV8DoGbUocCOVLIv6/WTNw8RLsboGTjTlJS0xwUHYB/VXEB19WPMzwd0FBj8UwHq ht27oVLqauEGbtseAPeSawoz/bU20JwKpK7/rtIqKDaE8WcucMCY43+eONQmb6Y0 rZr2TdYcYbxpx9PVcQRfOJetY4NT/RqTkJbCBMiFW4EJKSJpoFlKTaBA9EyR48/T vQpph6DeZJ6ne4M7xr8Uo8HxYUlHRBR0WQIbFISjoAd/98QaRmTcjOA7TpjdGPLy zUeBwGpk9ZlG13VrxoYq6OnXnIlOc2Bdk5v3AMulEXFL7Unusqf1eSSMovQMMTvV EREzyzqIkHEoQ5PoAlJ1abRYmqqqM/J10CpCv0k14dvjqRZ1514fNbQ/sQsiq8wB wm1mPYnxJ9nQbhelgXWigs6W8Y2yGSgHD1gSPcQS6vtNVOetm/gDYE2bODCw+ys0 FXgixGPyg+Ig2FQj6whhM0rRILdB0iLr3g4kKZxReGC1aHA2s4URSFPTjapqhp/w cFiDELv8Q0VK47P8hu8AzGQxaKJdEHRz6p03mZnzo96yecB0y3md+EvgVJadqkCj zKQ5Fah/yNo4cFeS9NKA =N3p8 -----END PGP SIGNATURE----- --OKPx4QVr3ewXGW0xSRKhQH60qQCrdm61G-- --===============1324387345== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1324387345==--