From: Jyri Sarha <jsarha@ti.com>
To: Daniel Vetter <daniel@ffwll.ch>
Cc: Tomeu Vizoso <tomeu.vizoso@collabora.com>,
dri-devel <dri-devel@lists.freedesktop.org>,
peter.ujfalusi@ti.com, Robert Foss <robert.foss@collabora.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH v5 0/4] drm/omapdrm: gamma table support + drm_crtc_enable_color_mgmt()
Date: Thu, 26 May 2016 15:19:56 +0300 [thread overview]
Message-ID: <5746E9EC.2060306@ti.com> (raw)
In-Reply-To: <CAKMK7uFRA87Sh9akMDhS_sYErdz_pa_biM01mdn_LZ4PguPuSw@mail.gmail.com>
On 05/26/16 13:17, Daniel Vetter wrote:
> On Thu, May 26, 2016 at 11:35:44AM +0300, Jyri Sarha wrote:
>> > Implements gamma tables for OMAP4, OMAP5, and dra7xx SoCs and adds a
>> > workaround for errata that may break LCD1 channel if gamma tables
>> > are in use.
>> >
>> > Also adds new drm_crtc_enable_color_mgmt() as suggested[1] by Daniel
>> > Vetter and get rid of the old drm_helper_crtc_enable_color_mgmt(). I
>> > have not tested the change to i915 driver, only compiled it, but
>> > functionally it should be exactly the same.
>> >
>> > [1] http://www.spinics.net/lists/dri-devel/msg108092.html
> Btw for testing it would be awesome if you could take the color manager
> igt testcase we have, and make it generic. Probably needs some
> adjustments like skip tests when not all properties which are needed are
> there. We should already auto-skip crc-based tests when that's not there,
> so hopefully not too much work.
>
> This way we could start to have something like real validation tests for
> all these atomic extensions and make sure things do work across drivers in
> a uniform way. Tomeu and Robert have done this conversion work thus far,
> with Daniel leading the effort (all cc'ed). Lionel has done the color mgmt
> test.
Well, the igt is totally new to me. I could take a look after our next
internal release in 2-3 weeks from now.
But, how about this series? Should I send a pull request directly to
Dave Airlie to get this in drm-next?
BR,
Jyri
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2016-05-26 12:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 8:35 [PATCH v5 0/4] drm/omapdrm: gamma table support + drm_crtc_enable_color_mgmt() Jyri Sarha
2016-05-26 8:35 ` [PATCH v5 1/4] drm: drm_helper_crtc_enable_color_mgmt() => drm_crtc_enable_color_mgmt() Jyri Sarha
2016-05-26 9:05 ` Tomi Valkeinen
2016-05-26 9:59 ` Jyri Sarha
2016-05-26 10:13 ` Daniel Vetter
2016-05-26 8:35 ` [PATCH v5 2/4] drm/omapdrm: Add gamma table support to DSS dispc Jyri Sarha
2016-05-26 8:35 ` [PATCH v5 3/4] drm/omapdrm: Workaround for errata i734 (LCD1 Gamma) in " Jyri Sarha
2016-05-26 8:35 ` [PATCH v5 4/4] drm/omapdrm: Implement gamma_lut atomic crtc properties Jyri Sarha
2016-05-26 10:17 ` [PATCH v5 0/4] drm/omapdrm: gamma table support + drm_crtc_enable_color_mgmt() Daniel Vetter
2016-05-26 12:18 ` Tomi Valkeinen
2016-05-26 12:19 ` Jyri Sarha [this message]
2016-05-26 11:15 ` Tomi Valkeinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5746E9EC.2060306@ti.com \
--to=jsarha@ti.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=peter.ujfalusi@ti.com \
--cc=robert.foss@collabora.com \
--cc=tomeu.vizoso@collabora.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox