From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rongrong Zou Subject: Re: [path v2 0/7] Add DRM driver for Hisilicon Hibmc Date: Mon, 30 May 2016 11:11:38 +0800 Message-ID: <574BAF6A.9040208@huawei.com> References: <1464514855-108050-1-git-send-email-zourongrong@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Xinliang Liu , Rongrong Zou Cc: David Airlie , Emil Velikov , lijianhua@huawei.com, dri-devel , Hanjun Guo , majun258@huawei.com, Linuxarm , LAKML , Linux Kernel Mailing List , linux-fbdev@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi Xinliang =E5=9C=A8 2016/5/30 11:01, Xinliang Liu =E5=86=99=E9=81=93: > Hi Rongrong, > > It seems that you haven't run the checkpatch script. > Please run this script to check your patches before you send them. Li= ke bellow: > $ cd yourkerneldir > $ ./scripts/checkpatch.pl --strict yourpatches I run checkpatch.pl without "--strict", and i'll check again with this parameter, thanks! > > Thanks, > -xinliang > > On 29 May 2016 at 17:40, Rongrong Zou wrote: >> This patch set adds a new drm driver for Hisilicon Hibmc. Hibmc is a >> base board management controller, usually it is used on server for >> Out-of-band management purpose. In this patch set, we just support b= asic >> function for Hibmc display subsystem. Hibmc display subsystem is con= nected >> to host CPU by PCIe as blow: >> >> +----------+ +----------+ >> | | PCIe | Hibmc | >> |host CPU( |<----->| display | >> |arm64,x86)| |subsystem | >> +----------+ +----------+ >> >> Hardware Detail for Hibmc display subsystem >> ----------- >> >> The display subsystem of Hibmc is show as bellow: >> +----+ +----+ +----+ +--------+ >> | | | | | | | | >> | FB |----->| DE |----->|VDAC|---->|external| >> | | | | | | | VGA | >> +----+ +----+ +----+ +--------+ >> >> -DE(Display Engine) is the display controller. >> -VDAC(Video Digital-to-Analog converter) converts the RGB diaital= data >> stream from DE to VGA analog signals. >> >> Change History >> ------------ >> >> Changes in v2: >> -Remove self-defined macros for bit operations. >> -Remove unused register. >> -Replace those deprecated functions with new version of them. >> -use drm_connector_register_all() to register connector after >> drm_dev_register(). >> >> The patch v1 is at >> https://lists.freedesktop.org/archives/dri-devel/2016-February/10192= 1.html >> Sorry for too late sending. >> >> >> Rongrong Zou (7): >> idrm/hisilicon/hibmc: Add hisilicon hibmc drm master driver >> drm/hisilicon/hibmc: Add plane for DE >> drm/hisilicon/hibmc: Add crtc for DE >> drm/hisilicon/hibmc: Add encoder for VDAC >> drm/hisilicon/hibmc: Add connector for VDAC >> drm/hisilicon/hibmc: Add support for frame buffer >> drm/hisilicon/hibmc: Add maintainer for Hibmc DRM >> >> MAINTAINERS | 7 + >> drivers/gpu/drm/hisilicon/Kconfig | 1 + >> drivers/gpu/drm/hisilicon/Makefile | 3 +- >> drivers/gpu/drm/hisilicon/hibmc/Kconfig | 13 + >> drivers/gpu/drm/hisilicon/hibmc/Makefile | 4 + >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c | 477 ++++++++++= ++++++++++++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.h | 29 ++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 399 ++++++++++= ++++++++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h | 64 +++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev.c | 286 ++++++++++= +++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_power.c | 91 +++++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_power.h | 28 ++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_regs.h | 214 ++++++++++ >> drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 174 ++++++++ >> 14 files changed, 1789 insertions(+), 1 deletion(-) >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/Kconfig >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/Makefile >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.c >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_de.h >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.h >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_fbdev= =2Ec >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_power= =2Ec >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_power= =2Eh >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_regs.= h >> create mode 100644 drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.= c >> >> -- >> 1.9.1 >> > > . > --=20 Regards, Rongrong