From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?UTF-8?Q?Christian_K=c3=b6nig?= <christian.koenig@amd.com>
Subject: Re: [patch v2] drm/amdgpu: missing bounds check in
 amdgpu_set_pp_force_state()
Date: Thu, 16 Jun 2016 10:39:42 +0200
Message-ID: <576265CE.1070809@amd.com>
References: <20160616083023.GA7046@mwanda>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"; Format="flowed"
Content-Transfer-Encoding: base64
Return-path: <dri-devel-bounces@lists.freedesktop.org>
Received: from na01-bn1-obe.outbound.protection.outlook.com
 (mail-bn1bon0082.outbound.protection.outlook.com [157.56.111.82])
 by gabe.freedesktop.org (Postfix) with ESMTPS id F1C836E251
 for <dri-devel@lists.freedesktop.org>; Thu, 16 Jun 2016 08:55:05 +0000 (UTC)
In-Reply-To: <20160616083023.GA7046@mwanda>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/dri-devel>,
 <mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel" <dri-devel-bounces@lists.freedesktop.org>
To: Dan Carpenter <dan.carpenter@oracle.com>, Alex Deucher <alexander.deucher@amd.com>
Cc: Jammy Zhou <Jammy.Zhou@amd.com>, kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Geliang Tang <geliangtang@163.com>, Eric Huang <JinHuiEric.Huang@amd.com>, Rex Zhu <Rex.Zhu@amd.com>
List-Id: dri-devel@lists.freedesktop.org

QW0gMTYuMDYuMjAxNiB1bSAxMDozMCBzY2hyaWViIERhbiBDYXJwZW50ZXI6Cj4gVGhlcmUgaXMg
bm8gbGltaXQgb24gaGlnaCAiaWR4IiBjYW4gZ28uICBJdCBzaG91bGQgYmUgbGVzcyB0aGFuCj4g
QVJSQVlfU0laRShkYXRhLnN0YXRlcykgd2hpY2ggaXMgMTYuCj4KPiBUaGUgImRhdGEiIHZhcmlh
YmxlIHdhc24ndCBkZWNsYXJlZCBpbiB0aGF0IHNjb3BlIHNvIEkgc2hpZnRlZCB0aGUgY29kZQo+
IGFyb3VuZCBhIGJpdCB0byBtYWtlIGl0IHdvcmsuICBBbHNvIEkgbWFkZSAiaWR4IiB1bnNpZ25l
ZC4KPgo+IEZpeGVzOiBmMzg5OGVhMTJmYzEgKCdkcm0vYW1kL3Bvd2VycGxheTogYWRkIHNvbWUg
c3lzZnMgaW50ZXJmYWNlcyBmb3IgcG93ZXJwbGF5LicpCj4gU2lnbmVkLW9mZi1ieTogRGFuIENh
cnBlbnRlciA8ZGFuLmNhcnBlbnRlckBvcmFjbGUuY29tPgoKQWNrZWQtYnk6IENocmlzdGlhbiBL
w7ZuaWcgPGNocmlzdGlhbi5rb2VuaWdAYW1kLmNvbT4uCgo+IC0tLQo+IHYyOiBtYWtlIGlkeCB1
bnNpZ25lZAo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1L2FtZGdw
dV9wbS5jIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3BtLmMKPiBpbmRleCA1
ODliMzZlLi4wZTEzZDgwIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9hbWQvYW1kZ3B1
L2FtZGdwdV9wbS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUvYW1kZ3B1X3Bt
LmMKPiBAQCAtMjcwLDMwICsyNzAsMjggQEAgc3RhdGljIHNzaXplX3QgYW1kZ3B1X3NldF9wcF9m
b3JjZV9zdGF0ZShzdHJ1Y3QgZGV2aWNlICpkZXYsCj4gICAJc3RydWN0IGRybV9kZXZpY2UgKmRk
ZXYgPSBkZXZfZ2V0X2RydmRhdGEoZGV2KTsKPiAgIAlzdHJ1Y3QgYW1kZ3B1X2RldmljZSAqYWRl
diA9IGRkZXYtPmRldl9wcml2YXRlOwo+ICAgCWVudW0gYW1kX3BtX3N0YXRlX3R5cGUgc3RhdGUg
PSAwOwo+IC0JbG9uZyBpZHg7Cj4gKwl1bnNpZ25lZCBsb25nIGlkeDsKPiAgIAlpbnQgcmV0Owo+
ICAgCj4gICAJaWYgKHN0cmxlbihidWYpID09IDEpCj4gICAJCWFkZXYtPnBwX2ZvcmNlX3N0YXRl
X2VuYWJsZWQgPSBmYWxzZTsKPiAtCWVsc2Ugewo+IC0JCXJldCA9IGtzdHJ0b2woYnVmLCAwLCAm
aWR4KTsKPiArCWVsc2UgaWYgKGFkZXYtPnBwX2VuYWJsZWQpIHsKPiArCQlzdHJ1Y3QgcHBfc3Rh
dGVzX2luZm8gZGF0YTsKPiAgIAo+IC0JCWlmIChyZXQpIHsKPiArCQlyZXQgPSBrc3RydG91bChi
dWYsIDAsICZpZHgpOwo+ICsJCWlmIChyZXQgfHwgaWR4ID49IEFSUkFZX1NJWkUoZGF0YS5zdGF0
ZXMpKSB7Cj4gICAJCQljb3VudCA9IC1FSU5WQUw7Cj4gICAJCQlnb3RvIGZhaWw7Cj4gICAJCX0K
PiAgIAo+IC0JCWlmIChhZGV2LT5wcF9lbmFibGVkKSB7Cj4gLQkJCXN0cnVjdCBwcF9zdGF0ZXNf
aW5mbyBkYXRhOwo+IC0JCQlhbWRncHVfZHBtX2dldF9wcF9udW1fc3RhdGVzKGFkZXYsICZkYXRh
KTsKPiAtCQkJc3RhdGUgPSBkYXRhLnN0YXRlc1tpZHhdOwo+IC0JCQkvKiBvbmx5IHNldCB1c2Vy
IHNlbGVjdGVkIHBvd2VyIHN0YXRlcyAqLwo+IC0JCQlpZiAoc3RhdGUgIT0gUE9XRVJfU1RBVEVf
VFlQRV9JTlRFUk5BTF9CT09UICYmCj4gLQkJCQlzdGF0ZSAhPSBQT1dFUl9TVEFURV9UWVBFX0RF
RkFVTFQpIHsKPiAtCQkJCWFtZGdwdV9kcG1fZGlzcGF0Y2hfdGFzayhhZGV2LAo+IC0JCQkJCQlB
TURfUFBfRVZFTlRfRU5BQkxFX1VTRVJfU1RBVEUsICZzdGF0ZSwgTlVMTCk7Cj4gLQkJCQlhZGV2
LT5wcF9mb3JjZV9zdGF0ZV9lbmFibGVkID0gdHJ1ZTsKPiAtCQkJfQo+ICsJCWFtZGdwdV9kcG1f
Z2V0X3BwX251bV9zdGF0ZXMoYWRldiwgJmRhdGEpOwo+ICsJCXN0YXRlID0gZGF0YS5zdGF0ZXNb
aWR4XTsKPiArCQkvKiBvbmx5IHNldCB1c2VyIHNlbGVjdGVkIHBvd2VyIHN0YXRlcyAqLwo+ICsJ
CWlmIChzdGF0ZSAhPSBQT1dFUl9TVEFURV9UWVBFX0lOVEVSTkFMX0JPT1QgJiYKPiArCQkgICAg
c3RhdGUgIT0gUE9XRVJfU1RBVEVfVFlQRV9ERUZBVUxUKSB7Cj4gKwkJCWFtZGdwdV9kcG1fZGlz
cGF0Y2hfdGFzayhhZGV2LAo+ICsJCQkJCUFNRF9QUF9FVkVOVF9FTkFCTEVfVVNFUl9TVEFURSwg
JnN0YXRlLCBOVUxMKTsKPiArCQkJYWRldi0+cHBfZm9yY2Vfc3RhdGVfZW5hYmxlZCA9IHRydWU7
Cj4gICAJCX0KPiAgIAl9Cj4gICBmYWlsOgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMu
ZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlz
dGluZm8vZHJpLWRldmVsCg==