dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Tomi Valkeinen <tomi.valkeinen@ti.com>
To: Jyri Sarha <jsarha@ti.com>, dri-devel@lists.freedesktop.org
Cc: bcousson@baylibre.com, laurent.pinchart@ideasonboard.com
Subject: Re: [PATCH v2 1/6] drm/tilcdc: Restore old dpms state in pm_resume()
Date: Thu, 16 Jun 2016 12:13:19 +0300	[thread overview]
Message-ID: <57626DAF.5070307@ti.com> (raw)
In-Reply-To: <bbe9e1d1aa508379f0f294ab6570f0a35bfc3124.1465979902.git.jsarha@ti.com>


[-- Attachment #1.1.1: Type: text/plain, Size: 514 bytes --]

On 15/06/16 11:39, Jyri Sarha wrote:
> Restore old dpms state in pm_resume(). The dpms is turned off in
> pm_suspend() and it should be restored to its original state in
> pm_resume().
> 
> Fixes commit 614b3cfeb8d2 ("drm/tilcdc: disable the lcd controller/dma
> engine when suspend invoked")

This still doesn't explain the issue (at least clearly). If you send a
fix for some problem, it's good to have a clear explanation of what's
the problem (from user's perspective, what does he see).

 Tomi


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2016-06-16  9:13 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-15  8:39 [PATCH v2 0/6] drm/tilcdc Fixes and cleanups Jyri Sarha
2016-06-15  8:39 ` [PATCH v2 1/6] drm/tilcdc: Restore old dpms state in pm_resume() Jyri Sarha
2016-06-16  9:13   ` Tomi Valkeinen [this message]
2016-06-15  8:39 ` [PATCH v2 2/6] drm/tilcdc: Write to LCDC_END_OF_INT_IND_REG at the end of IRQ function Jyri Sarha
2016-06-16  9:19   ` Tomi Valkeinen
2016-06-15  8:39 ` [PATCH v2 3/6] drm/tilcdc: Move waiting of LCDC_FRAME_DONE IRQ into stop() Jyri Sarha
2016-06-16  9:25   ` Tomi Valkeinen
2016-06-15  8:39 ` [PATCH v2 4/6] drm/tilcdc: Call drm_crtc_vblank_on() and *_off() in start() and stop() Jyri Sarha
2016-06-15  8:39 ` [PATCH v2 5/6] drm/tilcdc: Refer to panel.txt and tfp410.txt bindings in tilcdc.txt Jyri Sarha
2016-06-15  8:39 ` [PATCH v2 6/6] drm/tilcdc: Avoid error print by of_graph_get_next_endpoint() Jyri Sarha
2016-06-15 12:29 ` [PATCH v2 0/6] drm/tilcdc Fixes and cleanups Jyri Sarha
2016-06-16  9:30 ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57626DAF.5070307@ti.com \
    --to=tomi.valkeinen@ti.com \
    --cc=bcousson@baylibre.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jsarha@ti.com \
    --cc=laurent.pinchart@ideasonboard.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox