From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Subject: Re: [PATCH 7/8] drm/amd/powerplay: Change assignment for a buffer variable in phm_dispatch_table() Date: Sun, 17 Jul 2016 17:03:23 +0200 Message-ID: <578B9E3B.6020006@bfs.de> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <558FB427.80103@users.sourceforge.net> <477a5e29-19aa-6eea-fd33-c5e5cb790966@users.sourceforge.net> Reply-To: wharms@bfs.de Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <477a5e29-19aa-6eea-fd33-c5e5cb790966@users.sourceforge.net> Sender: kernel-janitors-owner@vger.kernel.org To: SF Markus Elfring Cc: dri-devel@lists.freedesktop.org, David Airlie , =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= , Alex Deucher , LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: dri-devel@lists.freedesktop.org Am 16.07.2016 17:08, schrieb SF Markus Elfring: > From: Markus Elfring > Date: Sat, 16 Jul 2016 15:36:36 +0200 > > The variable "temp_storage" was eventually reassigned with a pointer. > Thus omit the explicit initialisation at the beginning. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c > index 024e22e..735aeb0 100644 > --- a/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c > +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/functiontables.c > @@ -60,7 +60,7 @@ int phm_dispatch_table(struct pp_hwmgr *hwmgr, > void *input, void *output) > { > int result = 0; > - void *temp_storage = NULL; > + void *temp_storage; > > if (hwmgr == NULL || rt_table == NULL) { > printk(KERN_ERR "[ powerplay ] Invalid Parameter!\n"); > @@ -73,7 +73,8 @@ int phm_dispatch_table(struct pp_hwmgr *hwmgr, > printk(KERN_ERR "[ powerplay ] Could not allocate table temporary storage\n"); > return -ENOMEM; > } > - } > + } else > + temp_storage = NULL; > > result = phm_run_table(hwmgr, rt_table, input, output, temp_storage); > kfree(temp_storage); the handling of rt_table->storage_size == 0 is so better visible. IMHO in this case the function could return directly either with -EINVAL; or with 0; -> more direct more obvious. if (rt_table->storage_size == 0 ) return 0; re, wh