From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH v2] drm/radeon: Remove deprecated create_singlethread_workqueue Date: Mon, 18 Jul 2016 15:21:21 +0200 Message-ID: <578CD7D1.8000308@amd.com> References: <20160716113044.GA18061@Karyakshetra> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20160716113044.GA18061@Karyakshetra> Sender: linux-kernel-owner@vger.kernel.org To: Bhaktipriya Shridhar , Alex Deucher , David Airlie Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Tejun Heo List-Id: dri-devel@lists.freedesktop.org Am 16.07.2016 um 13:30 schrieb Bhaktipriya Shridhar: > alloc_workqueue replaces deprecated create_singlethread_workqueue(). > > Each hardware CRTC has a single flip work queue. > When a radeon_flip_work_func item is queued, it needs to be executed > ASAP because even a slight delay may cause the flip to be delayed by > one refresh cycle. > > Hence, a dedicated workqueue with WQ_HIGHPRI set, has been used here > since a delay can cause the outcome to miss the refresh cycle. > > Since there are only a fixed number of work items, explicit concurren= cy > limit is unnecessary here. > > Signed-off-by: Bhaktipriya Shridhar Reviewed-by: Christian K=F6nig > --- > Changes in v2: > -Used a dedicated work queue with WQ_HIGHPRI > > drivers/gpu/drm/radeon/radeon_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/dr= m/radeon/radeon_display.c > index 6a41b49..64b246e 100644 > --- a/drivers/gpu/drm/radeon/radeon_display.c > +++ b/drivers/gpu/drm/radeon/radeon_display.c > @@ -711,7 +711,7 @@ static void radeon_crtc_init(struct drm_device *d= ev, int index) > > drm_mode_crtc_set_gamma_size(&radeon_crtc->base, 256); > radeon_crtc->crtc_id =3D index; > - radeon_crtc->flip_queue =3D create_singlethread_workqueue("radeon-c= rtc"); > + radeon_crtc->flip_queue =3D alloc_workqueue("radeon-crtc", WQ_HIGHP= RI, 0); > rdev->mode_info.crtcs[index] =3D radeon_crtc; > > if (rdev->family >=3D CHIP_BONAIRE) { > -- > 2.1.4 >