From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH -next] drm/amdgpu: fix return value check in amdgpu_debugfs_ring_init() Date: Tue, 19 Jul 2016 14:25:52 +0200 Message-ID: <578E1C50.2090203@amd.com> References: <1468930520-10348-1-git-send-email-weiyj_lk@163.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1468930520-10348-1-git-send-email-weiyj_lk@163.com> Sender: linux-kernel-owner@vger.kernel.org To: Wei Yongjun , alexander.deucher@amd.com, airlied@linux.ie, tom.stdenis@amd.com, Jammy.Zhou@amd.com, David1.Zhou@amd.com, Monk.Liu@amd.com, Jerry.Zhang@amd.com Cc: Wei Yongjun , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Am 19.07.2016 um 14:15 schrieb Wei Yongjun: > From: Wei Yongjun > > In case of error, the function debugfs_create_*() returns NULL > pointer not ERR_PTR() if debugfs is enabled. The IS_ERR() test > in the return value check should be replaced with NULL test. > (defined(CONFIG_DEBUG_FS) make sure debugfs is enabled) > > Signed-off-by: Wei Yongjun Reviewed-by: Christian K=F6nig . There might be some more cases like this, we have probably copy&pasted=20 that code multiple times. > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c b/drivers/gpu/d= rm/amd/amdgpu/amdgpu_ring.c > index 3b885e3..9247ae16 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c > @@ -362,8 +362,8 @@ static int amdgpu_debugfs_ring_init(struct amdgpu= _device *adev, > ent =3D debugfs_create_file(name, > S_IFREG | S_IRUGO, root, > ring, &amdgpu_debugfs_ring_fops); > - if (IS_ERR(ent)) > - return PTR_ERR(ent); > + if (!ent) > + return -ENOMEM; > =20 > i_size_write(ent->d_inode, ring->ring_size + 12); > ring->ent =3D ent; > >