From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Subject: Re: [PATCH 2/4] GPU-DRM-Etnaviv: Delete unnecessary if statement in __etnaviv_gem_new() Date: Fri, 22 Jul 2016 18:41:38 +0200 Message-ID: <57924CC2.5030309@bfs.de> References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.so urceforge.net> <00ca5af9-674a-73ce-b423-1ce41d426942@users.sourceforge.net> Reply-To: wharms@bfs.de Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: SF Markus Elfring Cc: dri-devel@lists.freedesktop.org, Christian Gmeiner , David Airlie , Lucas Stach , Russell King , LKML , kernel-janitors@vger.kernel.org, Julia Lawall List-Id: dri-devel@lists.freedesktop.org Am 22.07.2016 17:48, schrieb SF Markus Elfring: > From: Markus Elfring > Date: Fri, 22 Jul 2016 16:45:22 +0200 > > Move a return statement into a block for successful function execution. > Omit a duplicate check for the local variable "ret" then at the end. > > Signed-off-by: Markus Elfring > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 6 +----- > 1 file changed, 1 insertion(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > index 8eee742..851a8ba 100644 > --- a/drivers/gpu/drm/etnaviv/etnaviv_gem.c > +++ b/drivers/gpu/drm/etnaviv/etnaviv_gem.c > @@ -661,13 +661,9 @@ static struct drm_gem_object *__etnaviv_gem_new(struct drm_device *dev, > */ > mapping = obj->filp->f_mapping; > mapping_set_gfp_mask(mapping, GFP_HIGHUSER); > + return obj; > } > > - if (ret) > - goto fail; > - > - return obj; > - > fail: > drm_gem_object_unreference_unlocked(obj); > return ERR_PTR(ret); >>From the program flow an readability it would be more nice the branch on error ret = drm_gem_object_init(dev, obj, size); if (ret) goto fail; just m 2 cents re, wh