From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mukesh Ojha Subject: Re: [PATCH] drm/msm/a6xx: Fix build with !CONFIG_DEBUG_FS Date: Wed, 3 Apr 2019 14:28:50 +0530 Message-ID: <58fdea0d-6c6c-e7dc-0be7-80df9f565250@codeaurora.org> References: <20190403064811.25832-1-yuehaibing@huawei.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190403064811.25832-1-yuehaibing@huawei.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: Yue Haibing , robdclark@gmail.com, sean@poorly.run, airlied@linux.ie, daniel@ffwll.ch, jcrouse@codeaurora.org Cc: linux-kernel@vger.kernel.org, freedreno@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org On 4/3/2019 12:18 PM, Yue Haibing wrote: > From: YueHaibing > > When building CONFIG_DEBUG_FS is not set > gcc warn this: > > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c: In function a6xx_show: > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c:1124:2: error: implicit declaration of function adreno_show; did you mean adreno_dump? [-Werror=implicit-function-declaration] > adreno_show(gpu, state, p); > ^~~~~~~~~~~ > > Reported-by: Hulk Robot > Fixes: 1707add81551 ("drm/msm/a6xx: Add a6xx gpu state") > Signed-off-by: YueHaibing Reviewed-by: Mukesh Ojha Cheers, -Mukesh > --- > drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > index e686331..d327eb5 100644 > --- a/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > +++ b/drivers/gpu/drm/msm/adreno/a6xx_gpu_state.c > @@ -1121,7 +1121,9 @@ void a6xx_show(struct msm_gpu *gpu, struct msm_gpu_state *state, > if (IS_ERR_OR_NULL(state)) > return; > > +#if defined(CONFIG_DEBUG_FS) || defined(CONFIG_DEV_COREDUMP) > adreno_show(gpu, state, p); > +#endif > > drm_puts(p, "registers:\n"); > for (i = 0; i < a6xx_state->nr_registers; i++) {