From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC309C48BEB for ; Fri, 16 Feb 2024 09:05:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3344F10E4E9; Fri, 16 Feb 2024 09:05:32 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; unprotected) header.d=tq-group.com header.i=@tq-group.com header.b="m/YKmGdz"; dkim-atps=neutral Received: from mx1.tq-group.com (mx1.tq-group.com [93.104.207.81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6BA8A10E4E9 for ; Fri, 16 Feb 2024 09:05:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tq-group.com; i=@tq-group.com; q=dns/txt; s=key1; t=1708074327; x=1739610327; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=9vIOGZfDhKu9DGx5o5UYxS0vQjX/6Zu979oLg6n9Etg=; b=m/YKmGdzJJwfM2aVRQ1wGj8s6cTLl8H+86BcCwYIma7ZzgvCAzAwIaQ7 lGrmh443gKX/AaFb/OspwaR7YapufqfjNRypp+x2uUPmh3+bzWy/r7jju 5rk66IG/ZBmth2wPD7wyC9zuMJaF530isHeXUkR02n/Wh8frNVXV8kw2B JvsIWiH13DfXK8Qc3rsSXcFxmIRXZ13qJjOlDz1ceEX1q+RHCJYPcnqnk vATX+uRRsRoYO6AHZ33gGN3bnpqjo2Rl1PVC5d/wNFuq2pIIZrpP75lRI pTyUtuSxOL66V/POsrY4gXJ0eT46R8O0CXDratuPYCPNtTB4TShDtx0g7 A==; X-IronPort-AV: E=Sophos;i="6.06,164,1705359600"; d="scan'208";a="35440531" Received: from vtuxmail01.tq-net.de ([10.115.0.20]) by mx1.tq-group.com with ESMTP; 16 Feb 2024 10:05:25 +0100 Received: from steina-w.localnet (steina-w.tq-net.de [10.123.53.25]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by vtuxmail01.tq-net.de (Postfix) with ESMTPSA id 1BAE5280075; Fri, 16 Feb 2024 10:05:25 +0100 (CET) From: Alexander Stein To: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org Cc: marex@denx.de, frieder.schrempf@kontron.de, Lucas Stach , Adam Ford , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Vinod Koul , Kishon Vijay Abraham I , Catalin Marinas , Will Deacon , Liu Ying , Ulf Hansson , dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org, linux-pm@vger.kernel.org, Adam Ford Subject: Re: [PATCH V8 09/12] dt-bindings: display: imx: add binding for i.MX8MP HDMI TX Date: Fri, 16 Feb 2024 10:05:26 +0100 Message-ID: <5916132.MhkbZ0Pkbq@steina-w> Organization: TQ-Systems GmbH In-Reply-To: <20240203165307.7806-10-aford173@gmail.com> References: <20240203165307.7806-1-aford173@gmail.com> <20240203165307.7806-10-aford173@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi all, Am Samstag, 3. Februar 2024, 17:52:49 CET schrieb Adam Ford: > From: Lucas Stach >=20 > The HDMI TX controller on the i.MX8MP SoC is a Synopsys designware IP > core with a little bit of SoC integration around it. >=20 > Signed-off-by: Lucas Stach > Signed-off-by: Adam Ford >=20 > --- > V3: Change name and location to better idenfity as a bridge and > HDMI 2.0a transmitter >=20 > Fix typos and feedback from Rob and added ports. > --- > .../display/bridge/fsl,imx8mp-hdmi-tx.yaml | 102 ++++++++++++++++++ > 1 file changed, 102 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/display/bridge/fsl,imx8mp-hdmi-tx.yaml >=20 > diff --git > a/Documentation/devicetree/bindings/display/bridge/fsl,imx8mp-hdmi-tx.yaml > b/Documentation/devicetree/bindings/display/bridge/fsl,imx8mp-hdmi-tx.yaml > new file mode 100644 > index 000000000000..3791c9f4ebab > --- /dev/null > +++ > b/Documentation/devicetree/bindings/display/bridge/fsl,imx8mp-hdmi-tx.yaml > @@ -0,0 +1,102 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/bridge/fsl,imx8mp-hdmi-tx.yam= l# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Freescale i.MX8MP DWC HDMI TX Encoder > + > +maintainers: > + - Lucas Stach > + > +description: > + The i.MX8MP HDMI transmitter is a Synopsys DesignWare > + HDMI 2.0a TX controller IP. > + > +allOf: > + - $ref: /schemas/display/bridge/synopsys,dw-hdmi.yaml# > + > +properties: > + compatible: > + enum: > + - fsl,imx8mp-hdmi-tx > + > + reg-io-width: > + const: 1 > + > + clocks: > + maxItems: 4 > + > + clock-names: > + items: > + - const: iahb > + - const: isfr > + - const: cec > + - const: pix > + > + power-domains: > + maxItems: 1 > + > + ports: > + $ref: /schemas/graph.yaml#/properties/ports > + > + properties: > + port@0: > + $ref: /schemas/graph.yaml#/properties/port > + description: Parallel RGB input port > + > + port@1: > + $ref: /schemas/graph.yaml#/properties/port > + description: HDMI output port > + > + required: > + - port@0 > + - port@1 Is this really correct that port@1 is required? AFAICS this host already=20 supports HPD and DDC by itself, so there is no need for a dedicated HDMI=20 connector. With the current state of the drivers this output port is completely ignore= d=20 anyway. Yet it works for a lot of people. Best regards, Alexander > + > +required: > + - compatible > + - reg > + - clocks > + - clock-names > + - interrupts > + - power-domains > + - ports > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include > + #include > + #include > + > + hdmi@32fd8000 { > + compatible =3D "fsl,imx8mp-hdmi-tx"; > + reg =3D <0x32fd8000 0x7eff>; > + interrupts =3D <0 IRQ_TYPE_LEVEL_HIGH>; > + clocks =3D <&clk IMX8MP_CLK_HDMI_APB>, > + <&clk IMX8MP_CLK_HDMI_REF_266M>, > + <&clk IMX8MP_CLK_32K>, > + <&hdmi_tx_phy>; > + clock-names =3D "iahb", "isfr", "cec", "pix"; > + power-domains =3D <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_HDMI_TX>; > + reg-io-width =3D <1>; > + ports { > + #address-cells =3D <1>; > + #size-cells =3D <0>; > + port@0 { > + reg =3D <0>; > + > + hdmi_tx_from_pvi: endpoint { > + remote-endpoint =3D <&pvi_to_hdmi_tx>; > + }; > + }; > + > + port@1 { > + reg =3D <1>; > + hdmi_tx_out: endpoint { > + remote-endpoint =3D <&hdmi0_con>; > + }; > + }; > + }; > + }; =2D-=20 TQ-Systems GmbH | M=FChlstra=DFe 2, Gut Delling | 82229 Seefeld, Germany Amtsgericht M=FCnchen, HRB 105018 Gesch=E4ftsf=FChrer: Detlef Schneider, R=FCdiger Stahl, Stefan Schneider http://www.tq-group.com/