From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/syncobj: Avoid kmalloc(GFP_KERNEL) under spinlock Date: Fri, 26 Oct 2018 09:43:05 +0200 Message-ID: <5928d5bb-70d4-cb0c-5a3b-06f30822c0ab@gmail.com> References: <20181026062027.12179-1-david1.zhou@amd.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181026062027.12179-1-david1.zhou@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chunming Zhou , dri-devel@lists.freedesktop.org Cc: =?UTF-8?Q?Christian_K=c3=b6nig?= , Julia Lawall , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMjYuMTAuMTggdW0gMDg6MjAgc2NocmllYiBDaHVubWluZyBaaG91Ogo+IGRyaXZlcnMvZ3B1 L2RybS9kcm1fc3luY29iai5jOjIwMjo0LTE0OiBFUlJPUjogZnVuY3Rpb24gZHJtX3N5bmNvYmpf ZmluZF9zaWduYWxfcHRfZm9yX3BvaW50IGNhbGxlZCBvbiBsaW5lIDM5MCBpbnNpZGUgbG9jayBv biBsaW5lIDM4OSBidXQgdXNlcyBHRlBfS0VSTkVMCj4KPiAgICBGaW5kIGZ1bmN0aW9ucyB0aGF0 IHJlZmVyIHRvIEdGUF9LRVJORUwgYnV0IGFyZSBjYWxsZWQgd2l0aCBsb2NrcyBoZWxkLgo+Cj4g R2VuZXJhdGVkIGJ5OiBzY3JpcHRzL2NvY2NpbmVsbGUvbG9ja3MvY2FsbF9rZXJuLmNvY2NpCj4K PiB2MjoKPiBzeW5jb2JqLT50aW1lbGluZSBzdGlsbCBuZWVkcyBwcm90ZWN0Lgo+Cj4gdjM6Cj4g dXNlIGEgZ2xvYmFsIHNpZ25hbGVkIGZlbmNlIGluc3RlYWQgb2YgcmUtYWxsb2NhdGlvbi4KPgo+ IHY0Ogo+IERvbid0IG5lZWQgbW92aW5nIGxvY2suCj4gRG9uJ3QgZXhwb3NlIGZ1bmMuCj4KPiB2 NToKPiByZW5hbWUgZnVuYyBhbmQgZGlyZWN0bHkgcmV0dXJuLgo+Cj4gVGVzdGVkIGJ5OiBzeW5j b2JqX3dhaXQgYW5kIC4vZGVxcC12ayAtbiBkRVFQLVZLLipzZW1hcGhvcmUqIHdpdGgKPiBsb2Nr IGRlYnVnIGtlcm5lbCBvcHRpb25zIGVuYWJsZWQuCj4KPiBTaWduZWQtb2ZmLWJ5OiBDaHVubWlu ZyBaaG91IDxkYXZpZDEuemhvdUBhbWQuY29tPgo+IENjOiBNYWFydGVuIExhbmtob3JzdCA8bWFh cnRlbi5sYW5raG9yc3RAbGludXguaW50ZWwuY29tPgo+IENjOiBpbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCj4gQ2M6IENocmlzdGlhbiBLw7ZuaWcgPGVhc3kycmVtZW1iZXIuY2hrQGdv b2dsZW1haWwuY29tPgo+IENjOiBDaHJpcyBXaWxzb24gPGNocmlzQGNocmlzLXdpbHNvbi5jby51 az4KPiBDQzogSnVsaWEgTGF3YWxsIDxqdWxpYS5sYXdhbGxAbGlwNi5mcj4KPiBSZXZpZXdlZC1i eTogQ2hyaXMgV2lsc29uIDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+CgpSZXZpZXdlZC1ieTog Q2hyaXN0aWFuIEvDtm5pZyA8Y2hyaXN0aWFuLmtvZW5pZ0BhbWQuY29tPgoKPiAtLS0KPiAgIGRy aXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jIHwgMzYgKysrKysrKysrKysrKysrKysrLS0tLS0t LS0tLS0tLS0tLS0KPiAgIDEgZmlsZSBjaGFuZ2VkLCAxOSBpbnNlcnRpb25zKCspLCAxNyBkZWxl dGlvbnMoLSkKPgo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYyBi L2RyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jCj4gaW5kZXggYjdlYWE2MDNmMzY4Li5kMWM2 ZjIxYzcyYjUgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vZHJtX3N5bmNvYmouYwo+IEBAIC04MCw2ICs4MCwyMyBAQCBz dHJ1Y3QgZHJtX3N5bmNvYmpfc2lnbmFsX3B0IHsKPiAgIAlzdHJ1Y3QgbGlzdF9oZWFkIGxpc3Q7 Cj4gICB9Owo+ICAgCj4gK3N0YXRpYyBERUZJTkVfU1BJTkxPQ0soc2lnbmFsZWRfZmVuY2VfbG9j ayk7Cj4gK3N0YXRpYyBzdHJ1Y3QgZG1hX2ZlbmNlIHNpZ25hbGVkX2ZlbmNlOwo+ICsKPiArc3Rh dGljIHN0cnVjdCBkbWFfZmVuY2UgKmRybV9zeW5jb2JqX2dldF9zdHViX2ZlbmNlKHZvaWQpCj4g K3sKPiArCXNwaW5fbG9jaygmc2lnbmFsZWRfZmVuY2VfbG9jayk7Cj4gKwlpZiAoIXNpZ25hbGVk X2ZlbmNlLm9wcykgewo+ICsJCWRtYV9mZW5jZV9pbml0KCZzaWduYWxlZF9mZW5jZSwKPiArCQkJ ICAgICAgICZkcm1fc3luY29ial9zdHViX2ZlbmNlX29wcywKPiArCQkJICAgICAgICZzaWduYWxl ZF9mZW5jZV9sb2NrLAo+ICsJCQkgICAgICAgMCwgMCk7Cj4gKwkJZG1hX2ZlbmNlX3NpZ25hbF9s b2NrZWQoJnNpZ25hbGVkX2ZlbmNlKTsKPiArCX0KPiArCXNwaW5fdW5sb2NrKCZzaWduYWxlZF9m ZW5jZV9sb2NrKTsKPiArCj4gKwlyZXR1cm4gZG1hX2ZlbmNlX2dldCgmc2lnbmFsZWRfZmVuY2Up Owo+ICt9Cj4gICAvKioKPiAgICAqIGRybV9zeW5jb2JqX2ZpbmQgLSBsb29rdXAgYW5kIHJlZmVy ZW5jZSBhIHN5bmMgb2JqZWN0Lgo+ICAgICogQGZpbGVfcHJpdmF0ZTogZHJtIGZpbGUgcHJpdmF0 ZSBwb2ludGVyCj4gQEAgLTExMywyMyArMTMwLDggQEAgc3RhdGljIHN0cnVjdCBkbWFfZmVuY2UK PiAgIAlzdHJ1Y3QgZHJtX3N5bmNvYmpfc2lnbmFsX3B0ICpzaWduYWxfcHQ7Cj4gICAKPiAgIAlp ZiAoKHN5bmNvYmotPnR5cGUgPT0gRFJNX1NZTkNPQkpfVFlQRV9USU1FTElORSkgJiYKPiAtCSAg ICAocG9pbnQgPD0gc3luY29iai0+dGltZWxpbmUpKSB7Cj4gLQkJc3RydWN0IGRybV9zeW5jb2Jq X3N0dWJfZmVuY2UgKmZlbmNlID0KPiAtCQkJa3phbGxvYyhzaXplb2Yoc3RydWN0IGRybV9zeW5j b2JqX3N0dWJfZmVuY2UpLAo+IC0JCQkJR0ZQX0tFUk5FTCk7Cj4gLQo+IC0JCWlmICghZmVuY2Up Cj4gLQkJCXJldHVybiBOVUxMOwo+IC0JCXNwaW5fbG9ja19pbml0KCZmZW5jZS0+bG9jayk7Cj4g LQkJZG1hX2ZlbmNlX2luaXQoJmZlbmNlLT5iYXNlLAo+IC0JCQkgICAgICAgJmRybV9zeW5jb2Jq X3N0dWJfZmVuY2Vfb3BzLAo+IC0JCQkgICAgICAgJmZlbmNlLT5sb2NrLAo+IC0JCQkgICAgICAg c3luY29iai0+dGltZWxpbmVfY29udGV4dCwKPiAtCQkJICAgICAgIHBvaW50KTsKPiAtCj4gLQkJ ZG1hX2ZlbmNlX3NpZ25hbCgmZmVuY2UtPmJhc2UpOwo+IC0JCXJldHVybiAmZmVuY2UtPmJhc2U7 Cj4gLQl9Cj4gKwkgICAgKHBvaW50IDw9IHN5bmNvYmotPnRpbWVsaW5lKSkKPiArCQlyZXR1cm4g ZHJtX3N5bmNvYmpfZ2V0X3N0dWJfZmVuY2UoKTsKPiAgIAo+ICAgCWxpc3RfZm9yX2VhY2hfZW50 cnkoc2lnbmFsX3B0LCAmc3luY29iai0+c2lnbmFsX3B0X2xpc3QsIGxpc3QpIHsKPiAgIAkJaWYg KHBvaW50ID4gc2lnbmFsX3B0LT52YWx1ZSkKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3Rz LmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo=