From: Inki Dae <inki.dae@samsung.com>
To: Andrzej Hajda <a.hajda@samsung.com>,
Gabriel Krisman Bertazi <krisman@collabora.co.uk>,
daniel.vetter@intel.com
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 2/6] exynos_drm: Clean up duplicated assignment in exynos_drm_driver
Date: Wed, 21 Jun 2017 13:58:20 +0900 [thread overview]
Message-ID: <5949FCEC.9090802@samsung.com> (raw)
In-Reply-To: <9b957f7c-26fa-52f3-7dd8-181cbd24ef4a@samsung.com>
Hi Andrzej,
2017년 06월 19일 20:03에 Andrzej Hajda 이(가) 쓴 글:
> Hi Inki,
>
> On 28.12.2016 15:32, Gabriel Krisman Bertazi wrote:
>> num_ioctls is already assigned when declaring the exynos_drm_driver
>> structure. No need to duplicate it here.
>>
>> Signed-off-by: Gabriel Krisman Bertazi <krisman@collabora.co.uk>
>
> It looks like the patch has not been merged, probably due to lack of
> your e-mail.
> Anyway it does the right thing, could you take it?
Got it. Thanks for notice.
Thanks,
Inki Dae
>
> Reviewed-by: Andrzej Hajda <a.hajda@samsung.com>
>
> --
> Regards
> Andrzej
>
>> ---
>> drivers/gpu/drm/exynos/exynos_drm_drv.c | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c
>> index 739180ac3da5..44b4d07eefb5 100644
>> --- a/drivers/gpu/drm/exynos/exynos_drm_drv.c
>> +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.c
>> @@ -570,7 +570,6 @@ static int exynos_drm_platform_probe(struct platform_device *pdev)
>> struct component_match *match;
>>
>> pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32);
>> - exynos_drm_driver.num_ioctls = ARRAY_SIZE(exynos_ioctls);
>>
>> match = exynos_drm_match_add(&pdev->dev);
>> if (IS_ERR(match))
>
>
>
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2017-06-21 5:08 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-28 14:32 [PATCH 0/6] drm documentation and clean ups Gabriel Krisman Bertazi
2016-12-28 14:32 ` [PATCH 1/6] drm: Deduplicate driver initialization message Gabriel Krisman Bertazi
2016-12-30 11:38 ` Daniel Vetter
2017-05-17 10:06 ` Jani Nikula
2017-05-17 11:41 ` Daniel Vetter
2017-05-17 11:51 ` Jani Nikula
2016-12-28 14:32 ` [PATCH 2/6] exynos_drm: Clean up duplicated assignment in exynos_drm_driver Gabriel Krisman Bertazi
2017-06-19 11:03 ` Andrzej Hajda
2017-06-21 4:58 ` Inki Dae [this message]
2016-12-28 14:32 ` [PATCH 3/6] drm: Drop unused forward declaration of drm_version Gabriel Krisman Bertazi
2016-12-28 14:32 ` [PATCH 4/6] drm: Export drm_ioctl_permit to kernel-doc Gabriel Krisman Bertazi
2016-12-28 14:32 ` [PATCH 5/6] drm: Document deprecated load/unload hook Gabriel Krisman Bertazi
2016-12-30 11:43 ` Daniel Vetter
2016-12-28 14:32 ` [PATCH 6/6] drm: Update TTM initialization documentation Gabriel Krisman Bertazi
2016-12-30 11:49 ` Daniel Vetter
2016-12-30 11:53 ` Daniel Vetter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5949FCEC.9090802@samsung.com \
--to=inki.dae@samsung.com \
--cc=a.hajda@samsung.com \
--cc=daniel.vetter@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=krisman@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox