dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Inki Dae <inki.dae@samsung.com>
To: Andrzej Hajda <a.hajda@samsung.com>
Cc: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
	Daniel Drake <drake@endlessm.com>
Subject: Re: [PATCH v2 10/11] drm/exynos/mixer: enable support for 1024x768 and 1280x1024 modes
Date: Tue, 17 Oct 2017 16:48:11 +0900	[thread overview]
Message-ID: <59E5B5BB.6080506@samsung.com> (raw)
In-Reply-To: <20170929100542.12849-11-a.hajda@samsung.com>



2017년 09월 29일 19:05에 Andrzej Hajda 이(가) 쓴 글:
> Since HDMI can handle these modes despite of MIXER limitations let's
> enable them.
> 
> Signed-off-by: Andrzej Hajda <a.hajda@samsung.com>
> Reviewed-by: Tobias Jakobi <tjakobi@math.uni-bielefeld.de>
> ---
>  drivers/gpu/drm/exynos/exynos_mixer.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_mixer.c b/drivers/gpu/drm/exynos/exynos_mixer.c
> index 8baa93f80106..85d33137cfd8 100644
> --- a/drivers/gpu/drm/exynos/exynos_mixer.c
> +++ b/drivers/gpu/drm/exynos/exynos_mixer.c
> @@ -1014,6 +1014,9 @@ static int mixer_mode_valid(struct exynos_drm_crtc *crtc,
>  	    (w >= 1664 && w <= 1920 && h >= 936 && h <= 1080))
>  		return MODE_OK;
>  
> +	if ((w == 1024 && h == 768) || (w == 1280 && h == 1024))
> +		return MODE_OK;

mixer_mode_valid function is common to all Exynos SoC managed by Exynos DRM driver.
So is it valid for all of them?

Thanks,
Inki Dae



> +
>  	return MODE_BAD;
>  }
>  
> 

  reply	other threads:[~2017-10-17  7:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20170929100545eucas1p24e82643e9ba934c6a0a1f437f4c0891a@eucas1p2.samsung.com>
2017-09-29 10:05 ` [PATCH v2 00/11] drm/exynos: TV path improvements Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 01/11] drm/exynos/mixer: abstract out output mode setup code Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 02/11] drm/exynos/mixer: move mode commit to enable callback Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 03/11] drm/exynos/mixer: move resolution configuration to single function Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 04/11] drm/exynos/mixer: fix mode validation code Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 05/11] drm/exynos/mixer: remove mixer_resources sub-structure Andrzej Hajda
2017-10-16 10:02     ` Inki Dae
2017-09-29 10:05   ` [PATCH v2 06/11] drm/exynos/hdmi: remove redundant mode field Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 07/11] drm/exynos: add mode_fixup callback to exynos_drm_crtc_ops Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 08/11] drm/exynos/mixer: pass actual mode on MIXER to encoder Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 09/11] drm/exynos/hdmi: quirk for support mode timings conversion Andrzej Hajda
2017-10-17  7:38     ` Inki Dae
2017-10-17  8:04       ` Andrzej Hajda
2017-10-18  2:31         ` Inki Dae
2017-10-18  9:36           ` Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 10/11] drm/exynos/mixer: enable support for 1024x768 and 1280x1024 modes Andrzej Hajda
2017-10-17  7:48     ` Inki Dae [this message]
2017-10-17  8:09       ` Andrzej Hajda
2017-09-29 10:05   ` [PATCH v2 11/11] drm/exynos/hdmi: add 85.5MHz pixel clock for v14 HDMI PHY Andrzej Hajda
2017-10-23  1:37   ` [PATCH v2 00/11] drm/exynos: TV path improvements Inki Dae

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59E5B5BB.6080506@samsung.com \
    --to=inki.dae@samsung.com \
    --cc=a.hajda@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=drake@endlessm.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=tjakobi@math.uni-bielefeld.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox