dri-devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: "Falkowski, Maciej" <maciej.falkowski@linux.intel.com>
To: Jeff Hugo <jeff.hugo@oss.qualcomm.com>, dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, karol.wachowski@linux.intel.com,
	lizhi.hou@amd.com
Subject: Re: [PATCH] accel/ivpu: Remove VPU_CPU_NOC_* register access from NPU6 onward
Date: Wed, 22 Oct 2025 12:57:51 +0200	[thread overview]
Message-ID: <59d15b3e-199f-4657-b7bf-ed456a60343f@linux.intel.com> (raw)
In-Reply-To: <bf77d882-7ab4-4271-a47b-ec0b86d19f91@oss.qualcomm.com>

On 10/21/2025 4:55 PM, Jeff Hugo wrote:

> On 10/21/2025 8:20 AM, Maciej Falkowski wrote:
>> From: Karol Wachowski <karol.wachowski@linux.intel.com>
>>
>> Quiescing TOP_MMIO in SOC_CPU_NOC as part of boot procedure is no longer
>> needed starting from 60XX. Remove soc_cpu_drive() call from NPU6 onward.
>>
>> The VPU_CPU_NOC_QREQN, VPU_CPU_NOC_QACCEPTN, and VPU_CPU_NOC_QDENY
>> registers are deprecated and non-functional on 60XX. They will be
>> removed in future generations.
>>
>> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
>> Signed-off-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
>
> Should you just squash this into "[PATCH] accel/ivpu: Add support for 
> Nova Lake's NPU"? Feels a bit odd to introduce an issue in that patch, 
> and then immediately fix it.
It wasn't exactly introducing an issue but sure squashing the two 
commits into one will simplify things.

Thanks,
Maciej

>
> -Jeff

      reply	other threads:[~2025-10-22 10:58 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-21 14:20 [PATCH] accel/ivpu: Remove VPU_CPU_NOC_* register access from NPU6 onward Maciej Falkowski
2025-10-21 14:55 ` Jeff Hugo
2025-10-22 10:57   ` Falkowski, Maciej [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59d15b3e-199f-4657-b7bf-ed456a60343f@linux.intel.com \
    --to=maciej.falkowski@linux.intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jeff.hugo@oss.qualcomm.com \
    --cc=karol.wachowski@linux.intel.com \
    --cc=lizhi.hou@amd.com \
    --cc=oded.gabbay@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox