From mboxrd@z Thu Jan 1 00:00:00 1970 From: xinliang Subject: Re: [PATCH] drm/hisilicon: Use dev_get_drvdata Date: Mon, 26 Aug 2019 17:10:51 +0800 Message-ID: <5D63A21B.1020207@hisilicon.com> References: <20190723103852.3907-1-hslester96@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20190723103852.3907-1-hslester96@gmail.com> Sender: linux-kernel-owner@vger.kernel.org To: Chuhong Yuan Cc: Rongrong Zou , David Airlie , Daniel Vetter , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org Hi, On 2019/7/23 18:38, Chuhong Yuan wrote: > Instead of using to_pci_dev + pci_get_drvdata, > use dev_get_drvdata to make code simpler. > > Signed-off-by: Chuhong Yuan Chuhong, thanks for the patch. And sorry for late reply. Acked-by: Xinliang Liu Applied to drm-hisilicon-hibmc-next. Thanks, Xinliang > --- > drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > index ce89e56937b0..f0be263feff5 100644 > --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_drv.c > @@ -60,16 +60,14 @@ static struct drm_driver hibmc_driver = { > > static int __maybe_unused hibmc_pm_suspend(struct device *dev) > { > - struct pci_dev *pdev = to_pci_dev(dev); > - struct drm_device *drm_dev = pci_get_drvdata(pdev); > + struct drm_device *drm_dev = dev_get_drvdata(dev); > > return drm_mode_config_helper_suspend(drm_dev); > } > > static int __maybe_unused hibmc_pm_resume(struct device *dev) > { > - struct pci_dev *pdev = to_pci_dev(dev); > - struct drm_device *drm_dev = pci_get_drvdata(pdev); > + struct drm_device *drm_dev = dev_get_drvdata(dev); > > return drm_mode_config_helper_resume(drm_dev); > }