From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D98C2C6FD1C for ; Mon, 20 Mar 2023 19:23:42 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E242310E2F0; Mon, 20 Mar 2023 19:23:41 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id 090A210E318 for ; Mon, 20 Mar 2023 19:23:40 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 84053614D7; Mon, 20 Mar 2023 19:23:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA516C4339C; Mon, 20 Mar 2023 19:23:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679340218; bh=ViTQxxdOJRkEYRhUQiCnCSf76pBDaRupx7wAVZ5N4kU=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=mNHEkg4rI8+eTJxg8xl9tYA1okQDoNFYyWIwPQuZepEMna7anDcr175IR+jDPqNF6 x0h7Uq16GME3vP5BTK0jEACnpsAr+lj//BrzlRJ5ZxbIRLP6XzYG8rDrSpdne8eD5Q plKubbDmXKWoMdtBJoUaLWw3btAOMJuyi/zx4jldli8jJGl9yMmWGaULWBIc/TEuwb KQ2WOOr74x5coeADDgqXJOHYH4OkhxSMOCIUiRKsu/m55ZXHIHAONQbNp2FVRfXBl5 4Rpk4Dz3BFW62mnIWYReuuY3A40clwUJI9iezi7zKntIm8dUBn1haD31ci3xZl3q2J NGvIoFw831Emw== Message-ID: <5ace543cae7a54db399750a1b330c3ae.sboyd@kernel.org> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable In-Reply-To: References: <1abd47784b08939ff08ff03d3d4f60449e87625f.1679062529.git.mazziesaccount@gmail.com> <20230317150916.a3xrh25ywe5k77yp@houat> Subject: Re: [PATCH v4 2/8] kunit: drm/tests: move generic helpers From: Stephen Boyd To: Matti Vaittinen , Maxime Ripard Date: Mon, 20 Mar 2023 12:23:36 -0700 User-Agent: alot/0.10 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heikki Krogerus , Emma Anholt , "Rafael J. Wysocki" , Greg Kroah-Hartman , =?utf-8?q?Ma=C3=ADra?= Canal , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Noralf =?utf-8?q?Tr=C3=B8nnes?= , Matti Vaittinen , Thomas Zimmermann , Andy Shevchenko Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Quoting Matti Vaittinen (2023-03-18 23:36:20) > >=20 > > I think you would have an easier time if you just copied and renamed > > them into the kunit folder as an preparation series. >=20 > Yes. That would simplify the syncing between the trees. It slightly bugs = > me to add dublicate code in kernel-but the clean-up series for DRM users = > could be prepared at the same time. It would be even possible to just=20 > change the drm-helper to be a wrapper for the generic one - and leave=20 > the callers intact - although it leaves some seemingly unnecessary=20 > "onion code" there. >=20 > > That way, you wouldn't have to coordinate DRM, CCF and IIO, you'd just > > create new helpers that can be reused/converted to by everyone eventual= ly >=20 > Yes. Thanks - I think I may go with this approach for the v5 :) Which kunit directory? I imagine if there are conflicts they will be trivial so it probably doesn't matter. Have you Cced kunit folks and the list on the kunit patches? They may have some opinion.