From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 79AA1C47258 for ; Tue, 23 Jan 2024 12:35:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB6C810E75D; Tue, 23 Jan 2024 12:35:58 +0000 (UTC) Received: from out-175.mta1.migadu.com (out-175.mta1.migadu.com [95.215.58.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0625B10E75D for ; Tue, 23 Jan 2024 12:35:57 +0000 (UTC) Message-ID: <5b0e1b73-9a94-4ab5-b30d-59caea8954cb@linux.dev> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1706013355; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q104h3QlUtguKNU196gINZbfXFac0qkpzQO4Cu5ARaE=; b=NonuuLgnbwm4TnzPT2hLumdstqoqmJBJsfPv8LB60gKfqePWFPiJzILiH9PccobXB1PieG lO6t2H72mcCMoEa4wh3Cn6pJ5TfzFOVVP3C+sif+Hgd4yFWJCvb7ZloelXh72zvS+vJmNu 3+nAiscLqw5LpVHBJkVX7VwpoButdoE= Date: Tue, 23 Jan 2024 20:35:48 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 5/5] drm-bridge: display-connector: Switch to use fwnode API Content-Language: en-US To: Laurent Pinchart References: <20240122163220.110788-1-sui.jingfeng@linux.dev> <20240122163220.110788-6-sui.jingfeng@linux.dev> <20240123012026.GC22880@pendragon.ideasonboard.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Sui Jingfeng In-Reply-To: <20240123012026.GC22880@pendragon.ideasonboard.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Neil Armstrong , Sui Jingfeng , Thomas Zimmermann , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Maxime Ripard , Daniel Vetter , David Airlie Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi, On 2024/1/23 09:20, Laurent Pinchart wrote: > On Tue, Jan 23, 2024 at 12:32:20AM +0800, Sui Jingfeng wrote: >> From: Sui Jingfeng >> >> Because API has wider coverage, it can be used on non-DT systems as well. >> >> Signed-off-by: Sui Jingfeng >> --- >> drivers/gpu/drm/bridge/display-connector.c | 22 ++++++++++++---------- >> 1 file changed, 12 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c >> index eb7e194e7735..2c3e54a458e8 100644 >> --- a/drivers/gpu/drm/bridge/display-connector.c >> +++ b/drivers/gpu/drm/bridge/display-connector.c >> @@ -243,8 +243,8 @@ static int display_connector_probe(struct platform_device *pdev) >> case DRM_MODE_CONNECTOR_DVII: { >> bool analog, digital; >> >> - analog = of_property_read_bool(pdev->dev.of_node, "analog"); >> - digital = of_property_read_bool(pdev->dev.of_node, "digital"); >> + analog = fwnode_property_present(pdev->dev.fwnode, "analog"); >> + digital = fwnode_property_present(pdev->dev.fwnode, "digital"); >> if (analog && !digital) { >> conn->bridge.type = DRM_MODE_CONNECTOR_DVIA; >> } else if (!analog && digital) { >> @@ -261,8 +261,8 @@ static int display_connector_probe(struct platform_device *pdev) >> case DRM_MODE_CONNECTOR_HDMIA: { >> const char *hdmi_type; >> >> - ret = of_property_read_string(pdev->dev.of_node, "type", >> - &hdmi_type); >> + ret = fwnode_property_read_string(pdev->dev.fwnode, "type", >> + &hdmi_type); >> if (ret < 0) { >> dev_err(&pdev->dev, "HDMI connector with no type\n"); >> return -EINVAL; >> @@ -292,7 +292,7 @@ static int display_connector_probe(struct platform_device *pdev) >> conn->bridge.interlace_allowed = true; >> >> /* Get the optional connector label. */ >> - of_property_read_string(pdev->dev.of_node, "label", &label); >> + fwnode_property_read_string(pdev->dev.fwnode, "label", &label); >> >> /* >> * Get the HPD GPIO for DVI, HDMI and DP connectors. If the GPIO can provide >> @@ -330,12 +330,13 @@ static int display_connector_probe(struct platform_device *pdev) >> if (type == DRM_MODE_CONNECTOR_DVII || >> type == DRM_MODE_CONNECTOR_HDMIA || >> type == DRM_MODE_CONNECTOR_VGA) { >> - struct device_node *phandle; >> + struct fwnode_handle *fwnode; >> >> - phandle = of_parse_phandle(pdev->dev.of_node, "ddc-i2c-bus", 0); >> - if (phandle) { >> - conn->bridge.ddc = of_get_i2c_adapter_by_node(phandle); >> - of_node_put(phandle); >> + fwnode = fwnode_find_reference(pdev->dev.fwnode, "ddc-i2c-bus", 0); >> + if (!IS_ERR_OR_NULL(fwnode)) { >> + dev_info(&pdev->dev, "has I2C bus property\n"); > This looks like a debugging leftover. Yes, thanks a lot for reviewing. I will pick up suggestions and go back to improve.