From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] drm/syncobj: Avoid kmalloc(GFP_KERNEL) under spinlock Date: Thu, 25 Oct 2018 20:58:23 +0200 Message-ID: <5b1d1779-6449-edf7-bddc-fa151f41cdef@googlemail.com> References: <20181025150831.19318-1-david1.zhou@amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181025150831.19318-1-david1.zhou@amd.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Chunming Zhou , dri-devel@lists.freedesktop.org Cc: Julia Lawall , intel-gfx@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org QW0gMjUuMTAuMTggdW0gMTc6MDggc2NocmllYiBDaHVubWluZyBaaG91Ogo+IGRyaXZlcnMvZ3B1 L2RybS9kcm1fc3luY29iai5jOjIwMjo0LTE0OiBFUlJPUjogZnVuY3Rpb24gZHJtX3N5bmNvYmpf ZmluZF9zaWduYWxfcHRfZm9yX3BvaW50IGNhbGxlZCBvbiBsaW5lIDM5MCBpbnNpZGUgbG9jayBv biBsaW5lIDM4OSBidXQgdXNlcyBHRlBfS0VSTkVMCj4KPiAgICBGaW5kIGZ1bmN0aW9ucyB0aGF0 IHJlZmVyIHRvIEdGUF9LRVJORUwgYnV0IGFyZSBjYWxsZWQgd2l0aCBsb2NrcyBoZWxkLgo+Cj4g R2VuZXJhdGVkIGJ5OiBzY3JpcHRzL2NvY2NpbmVsbGUvbG9ja3MvY2FsbF9rZXJuLmNvY2NpCj4K PiB2MjoKPiBzeW5jb2JqLT50aW1lbGluZSBzdGlsbCBuZWVkcyBwcm90ZWN0Lgo+Cj4gdjM6Cj4g dXNlIGEgZ2xvYmFsIHNpZ25hbGVkIGZlbmNlIGluc3RlYWQgb2YgcmUtYWxsb2NhdGlvbi4KPgo+ IHY0Ogo+IERvbid0IG5lZWQgbW92aW5nIGxvY2suCj4gRG9uJ3QgZXhwb3NlIGZ1bmMuCj4KPiBU ZXN0ZWQgYnk6IHN5bmNvYmpfd2FpdCBhbmQgLi9kZXFwLXZrIC1uIGRFUVAtVksuKnNlbWFwaG9y ZSogd2l0aAo+IGxvY2sgZGVidWcga2VybmVsIG9wdGlvbnMgZW5hYmxlZC4KPgo+IFNpZ25lZC1v ZmYtYnk6IENodW5taW5nIFpob3UgPGRhdmlkMS56aG91QGFtZC5jb20+Cj4gQ2M6IE1hYXJ0ZW4g TGFua2hvcnN0IDxtYWFydGVuLmxhbmtob3JzdEBsaW51eC5pbnRlbC5jb20+Cj4gQ2M6IGludGVs LWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKPiBDYzogQ2hyaXN0aWFuIEvDtm5pZyA8ZWFzeTJy ZW1lbWJlci5jaGtAZ29vZ2xlbWFpbC5jb20+Cj4gQ2M6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hy aXMtd2lsc29uLmNvLnVrPgo+IENDOiBKdWxpYSBMYXdhbGwgPGp1bGlhLmxhd2FsbEBsaXA2LmZy Pgo+IC0tLQo+ICAgZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMgfCA0MSArKysrKysrKysr KysrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICAgMSBmaWxlIGNoYW5nZWQsIDI0IGluc2VydGlv bnMoKyksIDE3IGRlbGV0aW9ucygtKQo+Cj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9k cm1fc3luY29iai5jIGIvZHJpdmVycy9ncHUvZHJtL2RybV9zeW5jb2JqLmMKPiBpbmRleCBiN2Vh YTYwM2YzNjguLmZhYjBhMmNmNjcyZSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vZHJt X3N5bmNvYmouYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9kcm1fc3luY29iai5jCj4gQEAgLTgw LDYgKzgwLDIzIEBAIHN0cnVjdCBkcm1fc3luY29ial9zaWduYWxfcHQgewo+ICAgCXN0cnVjdCBs aXN0X2hlYWQgbGlzdDsKPiAgIH07Cj4gICAKPiArc3RhdGljIERFRklORV9TUElOTE9DSyhzaWdu YWxlZF9mZW5jZV9sb2NrKTsKPiArc3RhdGljIHN0cnVjdCBkbWFfZmVuY2Ugc2lnbmFsZWRfZmVu Y2U7Cj4gKwo+ICtzdGF0aWMgc3RydWN0IGRtYV9mZW5jZSAqZHJtX3N5bmNvYmpfc2lnbmFsZWRf ZmVuY2VfZ2V0KHZvaWQpCgpNYXliZSBuYW1lIHRoYXQgZHJtX3N5bmNvYmpfZ2V0X3N0dWJfZmVu Y2UoKS4KCj4gK3sKPiArCXNwaW5fbG9jaygmc2lnbmFsZWRfZmVuY2VfbG9jayk7Cj4gKwlpZiAo IXNpZ25hbGVkX2ZlbmNlLm9wcykgewo+ICsJCWRtYV9mZW5jZV9pbml0KCZzaWduYWxlZF9mZW5j ZSwKPiArCQkJICAgICAgICZkcm1fc3luY29ial9zdHViX2ZlbmNlX29wcywKPiArCQkJICAgICAg ICZzaWduYWxlZF9mZW5jZV9sb2NrLAo+ICsJCQkgICAgICAgMCwgMCk7Cj4gKwkJZG1hX2ZlbmNl X3NpZ25hbF9sb2NrZWQoJnNpZ25hbGVkX2ZlbmNlKTsKPiArCX0KPiArCXNwaW5fdW5sb2NrKCZz aWduYWxlZF9mZW5jZV9sb2NrKTsKPiArCj4gKwlyZXR1cm4gZG1hX2ZlbmNlX2dldCgmc2lnbmFs ZWRfZmVuY2UpOwo+ICt9Cj4gICAvKioKPiAgICAqIGRybV9zeW5jb2JqX2ZpbmQgLSBsb29rdXAg YW5kIHJlZmVyZW5jZSBhIHN5bmMgb2JqZWN0Lgo+ICAgICogQGZpbGVfcHJpdmF0ZTogZHJtIGZp bGUgcHJpdmF0ZSBwb2ludGVyCj4gQEAgLTExMSwyNCArMTI4LDEyIEBAIHN0YXRpYyBzdHJ1Y3Qg ZG1hX2ZlbmNlCj4gICAJCQkJICAgICAgdWludDY0X3QgcG9pbnQpCj4gICB7Cj4gICAJc3RydWN0 IGRybV9zeW5jb2JqX3NpZ25hbF9wdCAqc2lnbmFsX3B0Owo+ICsJc3RydWN0IGRtYV9mZW5jZSAq ZiA9IE5VTEw7Cj4gICAKPiAgIAlpZiAoKHN5bmNvYmotPnR5cGUgPT0gRFJNX1NZTkNPQkpfVFlQ RV9USU1FTElORSkgJiYKPiAgIAkgICAgKHBvaW50IDw9IHN5bmNvYmotPnRpbWVsaW5lKSkgewo+ IC0JCXN0cnVjdCBkcm1fc3luY29ial9zdHViX2ZlbmNlICpmZW5jZSA9Cj4gLQkJCWt6YWxsb2Mo c2l6ZW9mKHN0cnVjdCBkcm1fc3luY29ial9zdHViX2ZlbmNlKSwKPiAtCQkJCUdGUF9LRVJORUwp Owo+IC0KPiAtCQlpZiAoIWZlbmNlKQo+IC0JCQlyZXR1cm4gTlVMTDsKPiAtCQlzcGluX2xvY2tf aW5pdCgmZmVuY2UtPmxvY2spOwo+IC0JCWRtYV9mZW5jZV9pbml0KCZmZW5jZS0+YmFzZSwKPiAt CQkJICAgICAgICZkcm1fc3luY29ial9zdHViX2ZlbmNlX29wcywKPiAtCQkJICAgICAgICZmZW5j ZS0+bG9jaywKPiAtCQkJICAgICAgIHN5bmNvYmotPnRpbWVsaW5lX2NvbnRleHQsCj4gLQkJCSAg ICAgICBwb2ludCk7Cj4gLQo+IC0JCWRtYV9mZW5jZV9zaWduYWwoJmZlbmNlLT5iYXNlKTsKPiAt CQlyZXR1cm4gJmZlbmNlLT5iYXNlOwo+ICsJCWYgPSBkcm1fc3luY29ial9zaWduYWxlZF9mZW5j ZV9nZXQoKTsKPiArCQlnb3RvIG91dDsKPiAgIAl9Cj4gICAKPiAgIAlsaXN0X2Zvcl9lYWNoX2Vu dHJ5KHNpZ25hbF9wdCwgJnN5bmNvYmotPnNpZ25hbF9wdF9saXN0LCBsaXN0KSB7Cj4gQEAgLTEz Nyw5ICsxNDIsMTEgQEAgc3RhdGljIHN0cnVjdCBkbWFfZmVuY2UKPiAgIAkJaWYgKChzeW5jb2Jq LT50eXBlID09IERSTV9TWU5DT0JKX1RZUEVfQklOQVJZKSAmJgo+ICAgCQkgICAgKHBvaW50ICE9 IHNpZ25hbF9wdC0+dmFsdWUpKQo+ICAgCQkJY29udGludWU7Cj4gLQkJcmV0dXJuIGRtYV9mZW5j ZV9nZXQoJnNpZ25hbF9wdC0+ZmVuY2VfYXJyYXktPmJhc2UpOwo+ICsJCWYgPSBkbWFfZmVuY2Vf Z2V0KCZzaWduYWxfcHQtPmZlbmNlX2FycmF5LT5iYXNlKTsKPiArCQlnb3RvIG91dDsKPiAgIAl9 Cj4gLQlyZXR1cm4gTlVMTDsKPiArb3V0Ogo+ICsJcmV0dXJuIGY7CgpJIHRoaW5rIHdlIGNhbiBk cm9wIHRoaXMgY2hhbmdlIG5vdyBhbmQganVzdCByZXR1cm4gZGlyZWN0bHkuCgpDaHJpc3RpYW4u Cgo+ICAgfQo+ICAgCj4gICBzdGF0aWMgdm9pZCBkcm1fc3luY29ial9hZGRfY2FsbGJhY2tfbG9j a2VkKHN0cnVjdCBkcm1fc3luY29iaiAqc3luY29iaiwKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVs QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=