From: Hans de Goede <hdegoede@redhat.com>
To: Thomas Zimmermann <tzimmermann@suse.de>,
rostedt@goodmis.org, pmladek@suse.com,
linux-fbdev@vger.kernel.org, sergey.senozhatsky@gmail.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
akpm@linux-foundation.org, sergey.senozhatsky.work@gmail.com
Subject: Re: [PATCH v3 0/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set
Date: Thu, 19 Jul 2018 13:45:24 +0200 [thread overview]
Message-ID: <5c8d334c-ca34-e446-2447-89421ae8f842@redhat.com> (raw)
In-Reply-To: <20180719101601.25076-1-tzimmermann@suse.de>
Hi,
On 19-07-18 12:15, Thomas Zimmermann wrote:
> Hi,
>
> this is version 3 of the WARN_CONSOLE_UNLOCKED patch set. The
> macro prints a warning if the console's critical sections are
> entered without holding the console lock. This patch set allows
> to disable the warnings while debugging the console.
>
> In the original approach, WARN_CONSOLE_UNLOCKED was disabled by
> setting ignore_console_lock_warning of type bool. As suggested by
> Petr Mladek, the new implementation is based on atomic_t and allows
> multiple threads to manipulate the warning state concurrently.
>
> With version 3, the patch set now includes the patch for introducing
> ignore_console_lock_warning. This patch superseds all previous patches
> of the same purpose.
>
> Best regards
> Thomas
>
> v3:
> - implement ignore_console_lock_warning with atomic_t
> v2:
> - restore ignore_console_lock_warning if lock_fb_info() fails
>
> Thomas Zimmermann (2):
> console: Replace #if 0 with atomic var 'ignore_console_lock_warning'
> fbdev/core: Disable console-lock warnings when fb.lockless_register_fb
> is set
I just saw this version after my comment on v2 that the race there
was not really a problem.
This version is even better though :) :
Acked-by: Hans de Goede <hdegoede@redhat.com>
Regards,
Hans
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-07-19 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-19 10:15 [PATCH v3 0/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Thomas Zimmermann
2018-07-19 10:16 ` [PATCH v3 1/2] console: Replace #if 0 with atomic var 'ignore_console_lock_warning' Thomas Zimmermann
2018-07-20 9:07 ` Petr Mladek
2018-07-31 10:45 ` Bartlomiej Zolnierkiewicz
2018-07-31 15:38 ` Steven Rostedt
2018-07-19 10:16 ` [PATCH v3 2/2] fbdev/core: Disable console-lock warnings when fb.lockless_register_fb is set Thomas Zimmermann
2018-07-20 9:10 ` Petr Mladek
2018-07-31 10:45 ` Bartlomiej Zolnierkiewicz
2018-07-19 11:45 ` Hans de Goede [this message]
2018-07-20 12:08 ` [PATCH v3 0/2] " Sergey Senozhatsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c8d334c-ca34-e446-2447-89421ae8f842@redhat.com \
--to=hdegoede@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=b.zolnierkie@samsung.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=sergey.senozhatsky.work@gmail.com \
--cc=sergey.senozhatsky@gmail.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox