From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dmitry Osipenko Subject: Re: [PATCH v2 1/2] drm/tegra: hub: Enable all required clocks Date: Fri, 30 Nov 2018 00:57:35 +0300 Message-ID: <5d0d052e-3a18-376f-ef63-a9beb03dd039@gmail.com> References: <20181129162435.20443-1-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6ED466E22E for ; Thu, 29 Nov 2018 21:57:38 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id 83-v6so3138509ljf.10 for ; Thu, 29 Nov 2018 13:57:38 -0800 (PST) In-Reply-To: <20181129162435.20443-1-thierry.reding@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org T24gMjkuMTEuMjAxOCAxOToyNCwgVGhpZXJyeSBSZWRpbmcgd3JvdGU6Cj4gRnJvbTogVGhpZXJy eSBSZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KPiAKPiBUaGUgZGlzcGxheSBhcmNoaXRlY3R1 cmUgb24gVGVncmExODYgYW5kIFRlZ3JhMTk0IHJlcXVpcmVzIHRoYXQgdGhlcmUgYmUKPiBzb21l IHZhbGlkIGNsb2NrIG9uIGFsbCBkb21haW5zIGJlZm9yZSBhY2Nlc3NpbmcgYW55IGRpc3BsYXkg cmVnaXN0ZXIuIEEKPiBmdXJ0aGVyIHJlcXVpcmVtZW50IGlzIHRoYXQgaW4gYWRkaXRpb24gdG8g dGhlIGhvc3QxeCwgaHViLCBkaXNwIGFuZCBkc2MKPiBjbG9ja3MsIGFsbCB0aGUgaGVhZCBjbG9j a3MgKHBjbGswLTIgb24gVGVncmExODYgb3IgcGNsazAtMyBvbiBUZWdyYTE5NCkKPiBtdXN0IGFs c28gYmUgZW5hYmxlZC4KPiAKPiBJbXBsZW1lbnQgdGhpcyBsb2dpYyB3aXRoaW4gdGhlIGRpc3Bs YXkgaHViIGRyaXZlciB0byBlbnN1cmUgdGhlIGNsb2Nrcwo+IGFyZSBhbHdheXMgZW5hYmxlZCBh dCB0aGUgcmlnaHQgdGltZS4KPiAKPiBTaWduZWQtb2ZmLWJ5OiBUaGllcnJ5IFJlZGluZyA8dHJl ZGluZ0BudmlkaWEuY29tPgo+IC0tLQo+IENoYW5nZXMgaW4gdjI6Cj4gLSByZXZlcnNlIG9yZGVy IGluIHdoaWNoIGNsb2NrcyBhcmUgZGlzYWJsZWQgZm9yIHN5bW1ldHJ5Cj4gLSBkb24ndCBsZWFr IGNoaWxkIGRldmljZSB0cmVlIG5vZGUKPiAKCkFuZCBoZXJlIGlzIGEgdmFyaWFudCB0aGF0IHVz ZXMgYnVsay1BUEksIGl0IGxvb2tzIG5pY2VyIHRvIG1lLiBEb24ndCB5b3UgdGhpbmsgc28/Cgpk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL3RlZ3JhL2h1Yi5jIGIvZHJpdmVycy9ncHUvZHJt L3RlZ3JhL2h1Yi5jCmluZGV4IDYxMTJkOTA0Mjk3OS4uZDU5N2RlN2QwZGU0IDEwMDY0NAotLS0g YS9kcml2ZXJzL2dwdS9kcm0vdGVncmEvaHViLmMKKysrIGIvZHJpdmVycy9ncHUvZHJtL3RlZ3Jh L2h1Yi5jCkBAIC03NDIsNiArNzQyLDcgQEAgc3RhdGljIGNvbnN0IHN0cnVjdCBob3N0MXhfY2xp ZW50X29wcyB0ZWdyYV9kaXNwbGF5X2h1Yl9vcHMgPSB7CiAKIHN0YXRpYyBpbnQgdGVncmFfZGlz cGxheV9odWJfcHJvYmUoc3RydWN0IHBsYXRmb3JtX2RldmljZSAqcGRldikKIHsKKwlzdHJ1Y3Qg ZGV2aWNlX25vZGUgKmNoaWxkID0gTlVMTDsKIAlzdHJ1Y3QgdGVncmFfZGlzcGxheV9odWIgKmh1 YjsKIAl1bnNpZ25lZCBpbnQgaTsKIAlpbnQgZXJyOwpAQCAtODAxLDYgKzgwMiwyOSBAQCBzdGF0 aWMgaW50IHRlZ3JhX2Rpc3BsYXlfaHViX3Byb2JlKHN0cnVjdCBwbGF0Zm9ybV9kZXZpY2UgKnBk ZXYpCiAJCQlyZXR1cm4gZXJyOwogCX0KIAorCWh1Yi0+bnVtX2hlYWRzID0gb2ZfZ2V0X2NoaWxk X2NvdW50KHBkZXYtPmRldi5vZl9ub2RlKTsKKworCWh1Yi0+Y2xrX2hlYWRzID0gZGV2bV9rY2Fs bG9jKCZwZGV2LT5kZXYsIGh1Yi0+bnVtX2hlYWRzLAorCQkJCSAgICAgIHNpemVvZigqaHViLT5j bGtfaGVhZHMpLCBHRlBfS0VSTkVMKTsKKwlpZiAoIWh1Yi0+Y2xrX2hlYWRzKQorCQlyZXR1cm4g LUVOT01FTTsKKworCWZvciAoaSA9IDA7IGkgPCBodWItPm51bV9oZWFkczsgaSsrKSB7CisJCWNo aWxkID0gb2ZfZ2V0X25leHRfY2hpbGQocGRldi0+ZGV2Lm9mX25vZGUsIGNoaWxkKTsKKworCQlo dWItPmNsa19oZWFkc1tpXS5pZCA9ICJkYyI7CisJCWh1Yi0+Y2xrX2hlYWRzW2ldLmNsayA9IGRl dm1fZ2V0X2Nsa19mcm9tX2NoaWxkKCZwZGV2LT5kZXYsCisJCQkJCQkJCWNoaWxkLCAiZGMiKTsK KwkJaWYgKElTX0VSUihodWItPmNsa19oZWFkc1tpXS5jbGspKSB7CisJCQlkZXZfZXJyKCZwZGV2 LT5kZXYsICJmYWlsZWQgdG8gZ2V0IGNsb2NrIGZvciBoZWFkICV1XG4iLAorCQkJCWkpOworCQkJ b2Zfbm9kZV9wdXQoY2hpbGQpOworCQkJcmV0dXJuIFBUUl9FUlIoaHViLT5jbGtfaGVhZHNbaV0u Y2xrKTsKKwkJfQorCX0KKworCW9mX25vZGVfcHV0KGNoaWxkKTsKKwogCS8qIFhYWDogZW5hYmxl IGNsb2NrIGFjcm9zcyByZXNldD8gKi8KIAllcnIgPSByZXNldF9jb250cm9sX2Fzc2VydChodWIt PnJzdCk7CiAJaWYgKGVyciA8IDApCkBAIC04NDYsNiArODcwLDcgQEAgc3RhdGljIGludCBfX21h eWJlX3VudXNlZCB0ZWdyYV9kaXNwbGF5X2h1Yl9zdXNwZW5kKHN0cnVjdCBkZXZpY2UgKmRldikK IAlpZiAoZXJyIDwgMCkKIAkJcmV0dXJuIGVycjsKIAorCWNsa19idWxrX2Rpc2FibGVfdW5wcmVw YXJlKGh1Yi0+bnVtX2hlYWRzLCBodWItPmNsa19oZWFkcyk7CiAJY2xrX2Rpc2FibGVfdW5wcmVw YXJlKGh1Yi0+Y2xrX2h1Yik7CiAJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKGh1Yi0+Y2xrX2RzYyk7 CiAJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKGh1Yi0+Y2xrX2Rpc3ApOwpAQCAtODcwLDEyICs4OTUs MTggQEAgc3RhdGljIGludCBfX21heWJlX3VudXNlZCB0ZWdyYV9kaXNwbGF5X2h1Yl9yZXN1bWUo c3RydWN0IGRldmljZSAqZGV2KQogCWlmIChlcnIgPCAwKQogCQlnb3RvIGRpc2FibGVfZHNjOwog Ci0JZXJyID0gcmVzZXRfY29udHJvbF9kZWFzc2VydChodWItPnJzdCk7CisJZXJyID0gY2xrX2J1 bGtfcHJlcGFyZV9lbmFibGUoaHViLT5udW1faGVhZHMsIGh1Yi0+Y2xrX2hlYWRzKTsKIAlpZiAo ZXJyIDwgMCkKIAkJZ290byBkaXNhYmxlX2h1YjsKIAorCWVyciA9IHJlc2V0X2NvbnRyb2xfZGVh c3NlcnQoaHViLT5yc3QpOworCWlmIChlcnIgPCAwKQorCQlnb3RvIGRpc2FibGVfaGVhZHM7CisK IAlyZXR1cm4gMDsKIAorZGlzYWJsZV9oZWFkczoKKwljbGtfYnVsa19kaXNhYmxlX3VucHJlcGFy ZShodWItPm51bV9oZWFkcywgaHViLT5jbGtfaGVhZHMpOwogZGlzYWJsZV9odWI6CiAJY2xrX2Rp c2FibGVfdW5wcmVwYXJlKGh1Yi0+Y2xrX2h1Yik7CiBkaXNhYmxlX2RzYzoKZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS90ZWdyYS9odWIuaCBiL2RyaXZlcnMvZ3B1L2RybS90ZWdyYS9odWIu aAppbmRleCA2Njk2YTg1ZmMxZjIuLjQwODY2NzY1ZWYwZCAxMDA2NDQKLS0tIGEvZHJpdmVycy9n cHUvZHJtL3RlZ3JhL2h1Yi5oCisrKyBiL2RyaXZlcnMvZ3B1L2RybS90ZWdyYS9odWIuaApAQCAt NDksNiArNDksOSBAQCBzdHJ1Y3QgdGVncmFfZGlzcGxheV9odWIgewogCXN0cnVjdCBjbGsgKmNs a19odWI7CiAJc3RydWN0IHJlc2V0X2NvbnRyb2wgKnJzdDsKIAorCXVuc2lnbmVkIGludCBudW1f aGVhZHM7CisJc3RydWN0IGNsa19idWxrX2RhdGEgKmNsa19oZWFkczsKKwogCWNvbnN0IHN0cnVj dCB0ZWdyYV9kaXNwbGF5X2h1Yl9zb2MgKnNvYzsKIAlzdHJ1Y3QgdGVncmFfd2luZG93Z3JvdXAg KndncnBzOwogfTsKCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5v cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2 ZWwK