From: Lu Baolu <baolu.lu@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
David Woodhouse <dwmw2@infradead.org>,
iommu@lists.linux-foundation.org, Joerg Roedel <jroedel@suse.de>
Cc: baolu.lu@linux.intel.com
Subject: Re: [PATCH v1] iommu/vt-d: Move intel_iommu_gfx_mapped to Intel IOMMU header
Date: Tue, 1 Sep 2020 13:01:35 +0800 [thread overview]
Message-ID: <5e9fef6a-7f75-d781-a39b-5cedbc08f3e2@linux.intel.com> (raw)
In-Reply-To: <20200828161212.71294-1-andriy.shevchenko@linux.intel.com>
Hi Andy,
On 8/29/20 12:12 AM, Andy Shevchenko wrote:
> Static analyzer is not happy about intel_iommu_gfx_mapped declaration:
>
> .../drivers/iommu/intel/iommu.c:364:5: warning: symbol 'intel_iommu_gfx_mapped' was not declared. Should it be static?
>
> Move its declaration to Intel IOMMU header file.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> include/drm/intel-gtt.h | 5 +----
> include/linux/intel-iommu.h | 1 +
> 2 files changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/include/drm/intel-gtt.h b/include/drm/intel-gtt.h
> index 71d81923e6b0..abfefaaf897a 100644
> --- a/include/drm/intel-gtt.h
> +++ b/include/drm/intel-gtt.h
> @@ -5,6 +5,7 @@
> #define _DRM_INTEL_GTT_H
>
> #include <linux/agp_backend.h>
> +#include <linux/intel-iommu.h>
> #include <linux/kernel.h>
>
> void intel_gtt_get(u64 *gtt_total,
> @@ -33,8 +34,4 @@ void intel_gtt_clear_range(unsigned int first_entry, unsigned int num_entries);
> /* flag for GFDT type */
> #define AGP_USER_CACHED_MEMORY_GFDT (1 << 3)
>
> -#ifdef CONFIG_INTEL_IOMMU
> -extern int intel_iommu_gfx_mapped;
> -#endif
> -
> #endif
> diff --git a/include/linux/intel-iommu.h b/include/linux/intel-iommu.h
> index 64fa5c56c825..fbd3bb64649b 100644
> --- a/include/linux/intel-iommu.h
> +++ b/include/linux/intel-iommu.h
> @@ -794,6 +794,7 @@ extern int iommu_calculate_max_sagaw(struct intel_iommu *iommu);
> extern int dmar_disabled;
> extern int intel_iommu_enabled;
> extern int intel_iommu_tboot_noforce;
> +extern int intel_iommu_gfx_mapped;
> #else
> static inline int iommu_calculate_agaw(struct intel_iommu *iommu)
> {
>
Looks good to me.
Reviewed-by: Lu Baolu <baolu.lu@linux.intel.com>
Best regards,
baolu
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2020-09-01 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-28 16:12 [PATCH v1] iommu/vt-d: Move intel_iommu_gfx_mapped to Intel IOMMU header Andy Shevchenko
2020-09-01 5:01 ` Lu Baolu [this message]
2020-09-04 10:13 ` Joerg Roedel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5e9fef6a-7f75-d781-a39b-5cedbc08f3e2@linux.intel.com \
--to=baolu.lu@linux.intel.com \
--cc=airlied@linux.ie \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jroedel@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox