dri-devel.lists.freedesktop.org archive mirror
 help / color / mirror / Atom feed
From: Lyude Paul <lyude@redhat.com>
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: nouveau <nouveau@lists.freedesktop.org>,
	"# 3.9+" <stable@vger.kernel.org>,
	"Lukas Wunner" <lukas@wunner.de>,
	"Karol Herbst" <karolherbst@gmail.com>,
	"Ben Skeggs" <bskeggs@redhat.com>,
	"David Airlie" <airlied@linux.ie>,
	"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
	"Daniel Vetter" <daniel.vetter@ffwll.ch>,
	"Thierry Reding" <treding@nvidia.com>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v6 3/5] drm/nouveau: Fix deadlock with fb_helper with async RPM requests
Date: Mon, 13 Aug 2018 15:12:11 -0400	[thread overview]
Message-ID: <5eedf19a59f06a4c7055660dc85d6dc23964abe9.camel@redhat.com> (raw)
In-Reply-To: <CAKb7UvjqVC5w4PDaVLtZqKs94bo22d4BGYgsQj9K-2_rksoqvg@mail.gmail.com>

On Mon, 2018-08-13 at 15:11 -0400, Ilia Mirkin wrote:
> On Mon, Aug 13, 2018 at 3:07 PM, Lyude Paul <lyude@redhat.com> wrote:
> > +bool
> > +nouveau_fbcon_hotplugged_in_suspend(struct nouveau_fbdev *fbcon)
> > +{
> > +       bool hotplug;
> > +
> > +       if (!fbcon)
> > +               return false;
> > +
> > +       mutex_lock(&fbcon->hotplug_lock);
> > +       hotplug = fbcon->hotplug_waiting;
> > +       mutex_unlock(&fbcon->hotplug_lock);
> > +
> > +       return hotplug;
> > +}
> 
> I'm probably missing it, but where is this function used?
oh no you aren't, I thought I got rid of that function! will respin in just a
moment
-- 
Cheers,
	Lyude Paul

  reply	other threads:[~2018-08-13 19:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-13 19:06 [PATCH v6 0/5] Fix connector probing deadlocks from RPM bugs Lyude Paul
2018-08-13 19:06 ` [PATCH v6 1/5] drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement Lyude Paul
2018-08-13 19:07 ` [PATCH v6 2/5] drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend() Lyude Paul
     [not found] ` <20180813190706.24172-1-lyude-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2018-08-13 19:07   ` [PATCH v6 3/5] drm/nouveau: Fix deadlock with fb_helper with async RPM requests Lyude Paul
2018-08-13 19:11     ` Ilia Mirkin
2018-08-13 19:12       ` Lyude Paul [this message]
2018-08-13 19:07   ` [PATCH v6 4/5] drm/nouveau: Use pm_runtime_get_noresume() in connector_detect() Lyude Paul
2018-08-13 19:07 ` [PATCH v6 5/5] drm/nouveau: Fix deadlocks in nouveau_connector_detect() Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5eedf19a59f06a4c7055660dc85d6dc23964abe9.camel@redhat.com \
    --to=lyude@redhat.com \
    --cc=airlied@linux.ie \
    --cc=bskeggs@redhat.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=imirkin@alum.mit.edu \
    --cc=karolherbst@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lukas@wunner.de \
    --cc=nouveau@lists.freedesktop.org \
    --cc=stable@vger.kernel.org \
    --cc=treding@nvidia.com \
    --cc=ville.syrjala@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).