From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1408DCE79AA for ; Wed, 20 Sep 2023 11:18:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C014110E146; Wed, 20 Sep 2023 11:18:51 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8A0A110E146; Wed, 20 Sep 2023 11:18:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695208729; x=1726744729; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=V/blwaER0AEA6MQ0muNozilAvVoc4x9ou18moN7caUY=; b=CH7/c/KhYcm5ry1nevrTPEkkJxjVM7oGsFU2oUpKnFqqZee9yDm5Pgda FqD1qRlMKZyjpwuRw70o01sFDWwEIi283jQ14/4sGOaDARxTFx1Kw0K8j xjXKEaaGO8GOX2vdY6btVrHTylAGnPa9REJsKBTTxrlefFtPQFxt3hlI5 deHuA0364qRC8xm2CfRfYvUusrJgF/ss6T5eUS+6P1Cjk5NE/H/JxwmjH LTTUsyYsokgNkrsOXRKH5ljKujG7xCaNHeUy3d0wr1XNCzIhX0KDjTzQ4 JfgU5vxwhXAK+3TxhY5o9yBVaGDpLKOkAXWTW3KL3RRfs8ZW32hcjr2ML w==; X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="446662748" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="446662748" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 04:18:48 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10838"; a="746604130" X-IronPort-AV: E=Sophos;i="6.02,161,1688454000"; d="scan'208";a="746604130" Received: from nirmoyda-mobl.ger.corp.intel.com (HELO [10.252.39.128]) ([10.252.39.128]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Sep 2023 04:18:46 -0700 Message-ID: <5ff2eb37-fa7b-84a5-4354-7e1b54dba907@linux.intel.com> Date: Wed, 20 Sep 2023 13:18:43 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] drm/i915: Fix aux invalidation with proper pipe_control flag Content-Language: en-US To: =?UTF-8?Q?Tapani_P=c3=a4lli?= , Andi Shyti , Nirmoy Das References: <20230919114716.19378-1-nirmoy.das@intel.com> From: Nirmoy Das In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Lucas De Marchi , intel-gfx@lists.freedesktop.org, Jonathan Cavitt , dri-devel@lists.freedesktop.org, stable@vger.kernel.org, Andrzej Hajda , Matt Roper , Prathap Kumar Valsan Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Sent out https://patchwork.freedesktop.org/series/123975/ to replace this one as this not really fixing the issue. Thanks, Nirmoy On 9/19/2023 2:19 PM, Tapani Pälli wrote: > > On 19.9.2023 15.11, Andi Shyti wrote: >> Hi Nirmoy, >> >> On Tue, Sep 19, 2023 at 01:47:16PM +0200, Nirmoy Das wrote: >>> The suggestion from the spec is to do l3 fabric flush not L3 flush. >>> >>> Fixes: 78a6ccd65fa3 ("drm/i915/gt: Ensure memory quiesced before >>> invalidation") >> please put this in one line. >> >>> Cc: Jonathan Cavitt >>> Cc: Andi Shyti >>> Cc: # v5.8+ >>> Cc: Nirmoy Das >>> Cc: Andrzej Hajda >>> Cc: Tvrtko Ursulin >>> Cc: Matt Roper >>> Cc: Lucas De Marchi >>> Cc: Tejas Upadhyay >>> Cc: Prathap Kumar Valsan >>> Signed-off-by: Nirmoy Das >> Reviewed-by: Andi Shyti >> >> and I believe >> >> Tested-by: Tapani Pälli > > Yes, tested on TGL LP (0x9a49)! > > >> Thanks, >> Andi