From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EDAE5EB64D9 for ; Fri, 7 Jul 2023 02:29:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0FD2510E4F4; Fri, 7 Jul 2023 02:29:41 +0000 (UTC) Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by gabe.freedesktop.org (Postfix) with ESMTPS id C5A7310E4F4 for ; Fri, 7 Jul 2023 02:29:38 +0000 (UTC) Received: by mail-lf1-x130.google.com with SMTP id 2adb3069b0e04-4f122ff663eso2108012e87.2 for ; Thu, 06 Jul 2023 19:29:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688696977; x=1691288977; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=t3ZR+ulk8qafSu0U6ApGONxyBOmiZshWsm+62zV4VR8=; b=SeutLac0YZ4NSuTvHgwey7e4gFIEN/mFlfmlV9rFaaTwqilhz1xZwH8yGbrLx4Xt+F GhjRL4mAyHn2S0pnEGPOUO4HUuiCEXWweuyL28ywnasYvxbdMKZdwvGKi+Q90yKe0GZf JOf1MDiETLRDO5HFQvFRZ1719feRk2NTcQ2nda2wPKxsM5DizxYnLt1FkO+jmMGY3LUr 4E0hYnoelzhcG9QhszgOKTgnpE9IAcTjg7lh7P+tJULS6im7eNn+8CKLviizFKl0yXLG bEsaKbu7u31r8bT+7zhYklp2H5d+mbBaAL2VvDsoaJMGpYt4pAHiTt7JjKN8Zl1RFZis 5heg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688696977; x=1691288977; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t3ZR+ulk8qafSu0U6ApGONxyBOmiZshWsm+62zV4VR8=; b=N6tZ/hOOVO4tROetzT6A/o7T35HwEJD//474mSZmeQGC7Ppqv9ojFAclI5SLfnsBjI 06ySjvAOBa+jSYqkyXM5DuyyjxX+Y1wdzOdOalknqINkQNwal8MHcSAcP8UHLGSdNmNj TsBeo8VGL0JeX3kFD41AJu5dRWQdxDSj92cU1xmJFkkWiDfUza7cKp4YF35gTg/qjdSi RKr7VWYlhsuDyjsFmcuuWuy3LrD9xk9OBUvSvnPcA01C2LQF8+/GnRwwUy3z7Pip4JBT pEY1JKjisoYtCDTOUaLCU1EVci6yJf12tiPCRtXvguf6uokrC49sxYJyb+T9w273Bu7a syXw== X-Gm-Message-State: ABy/qLZ6S9CB/PeYEbfB6QQ+07+RyHE4u62oaAJzTtqx9RCO84hJJn3c Hi9fyHyCzQREMENYLybIPMWjjw== X-Google-Smtp-Source: APBJJlGtzPjV14lMrIL+sZHD5ek9tOBcAzPG8LZjViHzqzrNlekFyda7ViGGtRfR7kU0hP1Z8p+ubQ== X-Received: by 2002:a19:e04a:0:b0:4f8:5e65:b61b with SMTP id g10-20020a19e04a000000b004f85e65b61bmr2351048lfj.65.1688696976952; Thu, 06 Jul 2023 19:29:36 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id w7-20020ac25987000000b004fb8ff1f531sm478578lfn.70.2023.07.06.19.29.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 06 Jul 2023 19:29:36 -0700 (PDT) Message-ID: <60df0f9e-9a9c-e55b-6cab-3d89dd90bcdb@linaro.org> Date: Fri, 7 Jul 2023 05:29:36 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [Freedreno] [PATCH 05/12] drm/msm/adreno: Use quirk to identify cached-coherent support Content-Language: en-GB To: Rob Clark , dri-devel@lists.freedesktop.org References: <20230706211045.204925-1-robdclark@gmail.com> <20230706211045.204925-6-robdclark@gmail.com> From: Dmitry Baryshkov In-Reply-To: <20230706211045.204925-6-robdclark@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Konrad Dybcio , linux-arm-msm@vger.kernel.org, Rob Clark , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 07/07/2023 00:10, Rob Clark wrote: > From: Rob Clark > > It is better to explicitly list it. With the move to opaque chip-id's > for future devices, we should avoid trying to infer things like > generation from the numerical value. Would it be better to push this to DT? I mean, we already have a 'dma-cache-coherent' property for it. > > Signed-off-by: Rob Clark > --- > drivers/gpu/drm/msm/adreno/adreno_device.c | 23 +++++++++++++++------- > drivers/gpu/drm/msm/adreno/adreno_gpu.h | 1 + > 2 files changed, 17 insertions(+), 7 deletions(-) > -- With best wishes Dmitry