From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F269C4338F for ; Fri, 23 Jul 2021 20:12:09 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E821C60ED7 for ; Fri, 23 Jul 2021 20:12:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E821C60ED7 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 56BC66E8CA; Fri, 23 Jul 2021 20:12:08 +0000 (UTC) Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by gabe.freedesktop.org (Postfix) with ESMTPS id B0DE86E8CA for ; Fri, 23 Jul 2021 20:12:04 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1627071127; h=Message-ID: References: In-Reply-To: Subject: Cc: To: From: Date: Content-Transfer-Encoding: Content-Type: MIME-Version: Sender; bh=z6QEHbzcWaJW5HVjSSDuWiycF/xowMUpC7M51JZaVKk=; b=bLteH3XfzlCyVq0Yst8L2fFZsM3X3sORpktzzKGj7qhcFf/MLfB3W7H6zKLLapnKgufo3YEy Omt27kALcEbiC/iofMAxxBCrQuQUvq1VO7M1Y4MTBBXpGjku1NIYaA6tfDtuKTOVDExUfDYh ZXrJxpCf/koNTrV8AUk8YJApv+M= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyJkOTU5ZSIsICJkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnIiwgImJlOWU0YSJd Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n07.prod.us-west-2.postgun.com with SMTP id 60fb228fd0100c7cf92538f3 (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Fri, 23 Jul 2021 20:11:59 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id E9371C4360C; Fri, 23 Jul 2021 20:11:58 +0000 (UTC) Received: from mail.codeaurora.org (localhost.localdomain [127.0.0.1]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) (Authenticated sender: abhinavk) by smtp.codeaurora.org (Postfix) with ESMTPSA id 020BFC433F1; Fri, 23 Jul 2021 20:11:58 +0000 (UTC) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 23 Jul 2021 13:11:57 -0700 From: abhinavk@codeaurora.org To: Bjorn Andersson Subject: Re: [Freedreno] [PATCH 2/5] drm/msm/dp: Use devres for ioremap() In-Reply-To: <20210722024227.3313096-3-bjorn.andersson@linaro.org> References: <20210722024227.3313096-1-bjorn.andersson@linaro.org> <20210722024227.3313096-3-bjorn.andersson@linaro.org> Message-ID: <612495cded56d0ec6abe502a296ebd6b@codeaurora.org> X-Sender: abhinavk@codeaurora.org User-Agent: Roundcube Webmail/1.3.9 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , Kuogee Hsieh , Rob Herring , Tanmay Shah , freedreno@lists.freedesktop.org, Sean Paul , Chandan Uddaraju Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 2021-07-21 19:42, Bjorn Andersson wrote: > The non-devres version of ioremap is used, which requires manual > cleanup. But the code paths leading here is mixed with other devres > users, so rely on this for ioremap as well to simplify the code. > > Signed-off-by: Bjorn Andersson Reviewed-by: Abhinav Kumar > --- > drivers/gpu/drm/msm/dp/dp_parser.c | 29 ++++------------------------- > 1 file changed, 4 insertions(+), 25 deletions(-) > > diff --git a/drivers/gpu/drm/msm/dp/dp_parser.c > b/drivers/gpu/drm/msm/dp/dp_parser.c > index 0519dd3ac3c3..c064ced78278 100644 > --- a/drivers/gpu/drm/msm/dp/dp_parser.c > +++ b/drivers/gpu/drm/msm/dp/dp_parser.c > @@ -32,7 +32,7 @@ static int msm_dss_ioremap(struct platform_device > *pdev, > } > > io_data->len = (u32)resource_size(res); > - io_data->base = ioremap(res->start, io_data->len); > + io_data->base = devm_ioremap(&pdev->dev, res->start, io_data->len); > if (!io_data->base) { > DRM_ERROR("%pS->%s: ioremap failed\n", > __builtin_return_address(0), __func__); > @@ -42,22 +42,6 @@ static int msm_dss_ioremap(struct platform_device > *pdev, > return 0; > } > > -static void msm_dss_iounmap(struct dss_io_data *io_data) > -{ > - if (io_data->base) { > - iounmap(io_data->base); > - io_data->base = NULL; > - } > - io_data->len = 0; > -} > - > -static void dp_parser_unmap_io_resources(struct dp_parser *parser) > -{ > - struct dp_io *io = &parser->io; > - > - msm_dss_iounmap(&io->dp_controller); > -} > - > static int dp_parser_ctrl_res(struct dp_parser *parser) > { > int rc = 0; > @@ -67,19 +51,14 @@ static int dp_parser_ctrl_res(struct dp_parser > *parser) > rc = msm_dss_ioremap(pdev, &io->dp_controller); > if (rc) { > DRM_ERROR("unable to remap dp io resources, rc=%d\n", rc); > - goto err; > + return rc; > } > > io->phy = devm_phy_get(&pdev->dev, "dp"); > - if (IS_ERR(io->phy)) { > - rc = PTR_ERR(io->phy); > - goto err; > - } > + if (IS_ERR(io->phy)) > + return PTR_ERR(io->phy); > > return 0; > -err: > - dp_parser_unmap_io_resources(parser); > - return rc; > } > > static int dp_parser_misc(struct dp_parser *parser)