From: "Heiko Stübner" <heiko@sntech.de>
To: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Damon Ding <damon.ding@rock-chips.com>
Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, jingoohan1@gmail.com, inki.dae@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
krzk@kernel.org, alim.akhtar@samsung.com, hjc@rock-chips.com,
andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com,
l.stach@pengutronix.de, dianders@chromium.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Damon Ding <damon.ding@rock-chips.com>
Subject: Re: [PATCH v2 12/12] drm/bridge: analogix_dp: Apply drm_bridge_connector helper
Date: Wed, 09 Jul 2025 22:11:57 +0200 [thread overview]
Message-ID: <6140569.FjKLVJYuhi@diego> (raw)
In-Reply-To: <20250709070139.3130635-13-damon.ding@rock-chips.com>
Am Mittwoch, 9. Juli 2025, 09:01:39 Mitteleuropäische Sommerzeit schrieb Damon Ding:
> Apply drm_bridge_connector helper for Analogix DP driver.
>
> The following changes have been made:
> - Remove &analogix_dp_device.connector and change
> &analogix_dp_device.bridge from a pointer to an instance.
> - Apply devm_drm_bridge_alloc() to allocate &analogix_dp_device that
> contains &drm_bridge.
> - Apply drm_bridge_connector helper to get rid of &drm_connector_funcs
> and &drm_connector_helper_funcs.
>
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
>
> ------
>
> Changes in v2:
> - For &drm_bridge.ops, remove DRM_BRIDGE_OP_HPD and add
> DRM_BRIDGE_OP_EDID.
> - Add analogix_dp_bridge_edid_read().
> - Move &analogix_dp_plat_data.skip_connector deletion to the previous
> patches.
> ---
> .../drm/bridge/analogix/analogix_dp_core.c | 169 ++++++++----------
> .../drm/bridge/analogix/analogix_dp_core.h | 4 +-
> 2 files changed, 80 insertions(+), 93 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> index abc64cc17e4c..fb510e55ef06 100644
> --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c
> @@ -23,6 +23,7 @@
> #include <drm/drm_atomic.h>
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_bridge.h>
> +#include <drm/drm_bridge_connector.h>
> #include <drm/drm_crtc.h>
> #include <drm/drm_device.h>
> #include <drm/drm_edid.h>
> @@ -948,23 +949,13 @@ static int analogix_dp_disable_psr(struct analogix_dp_device *dp)
> return analogix_dp_send_psr_spd(dp, &psr_vsc, true);
> }
>
> -static int analogix_dp_get_modes(struct drm_connector *connector)
> +static int analogix_dp_bridge_get_modes(struct drm_bridge *bridge, struct drm_connector *connector)
> {
> - struct analogix_dp_device *dp = to_dp(connector);
> - const struct drm_edid *drm_edid;
> + struct analogix_dp_device *dp = to_dp(bridge);
> int num_modes = 0;
>
> if (dp->plat_data->panel) {
> num_modes += drm_panel_get_modes(dp->plat_data->panel, connector);
here is one example where a panel_bridge would help :-)
I.e. I'd think without it the code would need some sort of
if (dp->plat_data->bridge) {
num_modes += drm_bridge_get_modes(dp->plat_data->bridge, connector);
thing?
> - } else {
> - drm_edid = drm_edid_read_ddc(connector, &dp->aux.ddc);
> -
> - drm_edid_connector_update(&dp->connector, drm_edid);
> -
> - if (drm_edid) {
> - num_modes += drm_edid_connector_add_modes(&dp->connector);
> - drm_edid_free(drm_edid);
> - }
> }
>
> if (dp->plat_data->get_modes)
next prev parent reply other threads:[~2025-07-09 20:12 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250709070241eucas1p1351e2b508cc648d1fafd93640b471e7b@eucas1p1.samsung.com>
2025-07-09 7:01 ` [PATCH v2 00/12] Apply drm_bridge_connector helper for the Analogix DP driver Damon Ding
2025-07-09 7:01 ` [PATCH v2 01/12] drm/bridge: analogix_dp: Formalize the struct analogix_dp_device Damon Ding
2025-07-09 7:01 ` [PATCH v2 02/12] drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to &drm_bridge_funcs.atomic_enable Damon Ding
2025-07-09 7:01 ` [PATCH v2 03/12] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.bridge Damon Ding
2025-07-09 7:01 ` [PATCH v2 04/12] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2025-07-09 19:55 ` Heiko Stübner
2025-07-11 7:20 ` Damon Ding
2025-07-09 7:01 ` [PATCH v2 05/12] drm/exynos: exynos_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2025-07-09 19:58 ` Heiko Stübner
2025-07-11 7:26 ` Damon Ding
2025-07-09 7:01 ` [PATCH v2 06/12] drm/bridge: analogix_dp: " Damon Ding
2025-07-09 7:01 ` [PATCH v2 07/12] drm/bridge: analogix_dp: Add support to find panel or bridge Damon Ding
2025-07-09 20:07 ` Heiko Stübner
2025-07-11 7:41 ` Damon Ding
2025-07-21 7:36 ` Damon Ding
2025-07-09 7:01 ` [PATCH v2 08/12] drm/rockchip: analogix_dp: Apply drmm_encoder_init() instead of drm_simple_encoder_init() Damon Ding
2025-07-09 7:01 ` [PATCH v2 09/12] drm/rockchip: analogix_dp: Apply analogix_dp_find_panel_or_bridge() Damon Ding
2025-07-09 7:01 ` [PATCH v2 10/12] drm/exynos: exynos_dp: " Damon Ding
2025-07-09 7:01 ` [PATCH v2 11/12] drm/bridge: analogix_dp: Remove unused APIs for AUX bus Damon Ding
2025-07-09 7:01 ` [PATCH v2 12/12] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2025-07-09 20:11 ` Heiko Stübner [this message]
2025-07-11 7:50 ` Damon Ding
2025-07-09 7:22 ` [PATCH v2 00/12] Apply drm_bridge_connector helper for the Analogix DP driver Marek Szyprowski
2025-07-11 7:16 ` Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6140569.FjKLVJYuhi@diego \
--to=heiko@sntech.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=damon.ding@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=inki.dae@samsung.com \
--cc=jernej.skrabec@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=sw0312.kim@samsung.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).