From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B13BAC4332F for ; Wed, 4 Jan 2023 13:18:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 740D210E1D2; Wed, 4 Jan 2023 13:18:28 +0000 (UTC) Received: from mail-ej1-x633.google.com (mail-ej1-x633.google.com [IPv6:2a00:1450:4864:20::633]) by gabe.freedesktop.org (Postfix) with ESMTPS id E93CA10E1CE; Wed, 4 Jan 2023 13:18:23 +0000 (UTC) Received: by mail-ej1-x633.google.com with SMTP id u9so82636855ejo.0; Wed, 04 Jan 2023 05:18:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=84fez/ucWTww6NSVV6G0atDkJcgY0oGG1v+FAR1TxNY=; b=JAgCx2eqLgGc08EMjQPLJLJdM45V4H24UGXWCqCVcWPnLC4RuTaC39AX5sQnrkz2Ok /ukjXXhCKa1m3/Co+aDvmf7nqhkWG8e0qbvF3ec77Sq3udTiqU5A7TuQeb7nWxZxqrK/ Kh+8jlqycp7H1ONgeowiSQSMImrMRKnWZELw3GHUqKswDca3xGcU7HOvLOg74zT8RoJo YqrH7o9715DW21d928mrvGgGanh50mhKM4rqZbcRA+W8vrExPYly+InUk4Q05GgH91zh psQFK3XZyCbanbMLOiU+7CkjwDVJrV9FB43AD/MymRnBr/iZ8VmW0sw2XhElkb/EbKvx 7hWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=84fez/ucWTww6NSVV6G0atDkJcgY0oGG1v+FAR1TxNY=; b=H4aYCkjeu+e2jkqYe50SBkyjkOrOfv+oIxKv5VQ+9QP3+DfKeOKQOnpWSOpMtm5RIB 2R2oZBnCKqZU1XNCZ81y+L5RfAGrzAXBO+gFFNqgEW+StHwbMvvyPuAKEibXPkJJUBTe OffJfqqbMs/4QvpMRtPYd98qyM+kRic2aUijGL7OHwicHhtj7WBJNdx/MAsYcF0Zv7r0 Ea4neVsfFBqhLVD5B6wlhkGbFDPd1GSUTPngAV9DauiKRr+lLwC6wp49KkQL1vFQRBoH ABpJ5tUaHWNWzZbxugMKsjG+s/pIG+h0SNP7xoH7PWfKbnW3BMiD6YzRWO1eCjNBGGx+ Vk1Q== X-Gm-Message-State: AFqh2ko/MTc+F75jvjiOjNf31w1Co9E8FJ/NvYlT/ZUe5x4+fr1doUBF ainN8lwSC8ylOAjzv/t2W9M= X-Google-Smtp-Source: AMrXdXvPIrhB2XSa5IXQh0PW2kHoCxgIGUZ5fln0nOiQ8734erNw+n5Ikqlf7f9g9MESnAEjB0wIYA== X-Received: by 2002:a17:907:a485:b0:7c0:e23f:17ca with SMTP id vp5-20020a170907a48500b007c0e23f17camr38689262ejc.34.1672838302310; Wed, 04 Jan 2023 05:18:22 -0800 (PST) Received: from [192.168.178.21] (p5b0ea2e7.dip0.t-ipconnect.de. [91.14.162.231]) by smtp.gmail.com with ESMTPSA id u17-20020a1709061db100b0084c70c27407sm9767146ejh.84.2023.01.04.05.18.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Jan 2023 05:18:21 -0800 (PST) Message-ID: <61ed5d45-c79c-0c5e-ae18-b51d8925386f@gmail.com> Date: Wed, 4 Jan 2023 14:18:20 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v4 27/27] drm/amd: Optimize SRIOV switch/case for PSP microcode load Content-Language: en-US To: Mario Limonciello , Alex Deucher , linux-kernel@vger.kernel.org References: <20230103221852.22813-1-mario.limonciello@amd.com> <20230103221852.22813-28-mario.limonciello@amd.com> From: =?UTF-8?Q?Christian_K=c3=b6nig?= In-Reply-To: <20230103221852.22813-28-mario.limonciello@amd.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Pan, Xinhui" , Lazar Lijo , Javier Martinez Canillas , amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Carlos Soriano Sanchez , christian.koenig@amd.com Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Am 03.01.23 um 23:18 schrieb Mario Limonciello: > Now that IP version decoding is used, a number of case statements > can be combined. > > Signed-off-by: Mario Limonciello This patch can probably be pushed as small cleanup independent of the previous patches. In general I usually suggest to push those separately to make the patch set concentrate on the real changes at hand. Anyway this patch here is Reviewed-by: Christian König Regards, Christian. > --- > v3->v4: > * New patch > > drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c | 8 +------- > 1 file changed, 1 insertion(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > index f45362dd8228..83e253b5d928 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_psp.c > @@ -132,14 +132,8 @@ static int psp_init_sriov_microcode(struct psp_context *psp) > > switch (adev->ip_versions[MP0_HWIP][0]) { > case IP_VERSION(9, 0, 0): > - adev->virt.autoload_ucode_id = AMDGPU_UCODE_ID_CP_MEC2; > - ret = psp_init_cap_microcode(psp, ucode_prefix); > - break; > - case IP_VERSION(11, 0, 9): > - adev->virt.autoload_ucode_id = AMDGPU_UCODE_ID_CP_MEC2; > - ret = psp_init_cap_microcode(psp, ucode_prefix); > - break; > case IP_VERSION(11, 0, 7): > + case IP_VERSION(11, 0, 9): > adev->virt.autoload_ucode_id = AMDGPU_UCODE_ID_CP_MEC2; > ret = psp_init_cap_microcode(psp, ucode_prefix); > break;