From: "Heiko Stübner" <heiko@sntech.de>
To: Wolfram Sang <wsa@kernel.org>, Sandy Huang <hjc@rock-chips.com>,
Heiner Kallweit <hkallweit1@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Maxime Ripard <mripard@kernel.org>,
linux-rockchip@lists.infradead.org, linux-i2c@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
linux-arm-kernel@lists.infradead.org,
Heiner Kallweit <hkallweit1@gmail.com>
Subject: Re: [PATCH 01/20] drivers/gpu/drm/rockchip: remove I2C_CLASS_DDC support
Date: Mon, 13 Nov 2023 21:42:05 +0100 [thread overview]
Message-ID: <6269120.1IzOArtZ34@diego> (raw)
In-Reply-To: <20231113112344.719-2-hkallweit1@gmail.com>
Am Montag, 13. November 2023, 12:23:25 CET schrieb Heiner Kallweit:
> After removal of the legacy EEPROM driver and I2C_CLASS_DDC support in
> olpc_dcon there's no i2c client driver left supporting I2C_CLASS_DDC.
> Class-based device auto-detection is a legacy mechanism and shouldn't
> be used in new code. So we can remove this class completely now.
>
> Preferably this series should be applied via the i2c tree.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Acked-by: Heiko Stuebner <heiko@sntech.de>
>
> ---
> drivers/gpu/drm/rockchip/inno_hdmi.c | 1 -
> drivers/gpu/drm/rockchip/rk3066_hdmi.c | 1 -
> 2 files changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/rockchip/inno_hdmi.c b/drivers/gpu/drm/rockchip/inno_hdmi.c
> index 6e5b922a1..a7739b27c 100644
> --- a/drivers/gpu/drm/rockchip/inno_hdmi.c
> +++ b/drivers/gpu/drm/rockchip/inno_hdmi.c
> @@ -793,7 +793,6 @@ static struct i2c_adapter *inno_hdmi_i2c_adapter(struct inno_hdmi *hdmi)
> init_completion(&i2c->cmp);
>
> adap = &i2c->adap;
> - adap->class = I2C_CLASS_DDC;
> adap->owner = THIS_MODULE;
> adap->dev.parent = hdmi->dev;
> adap->dev.of_node = hdmi->dev->of_node;
> diff --git a/drivers/gpu/drm/rockchip/rk3066_hdmi.c b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
> index fa6e592e0..7a3f71aa2 100644
> --- a/drivers/gpu/drm/rockchip/rk3066_hdmi.c
> +++ b/drivers/gpu/drm/rockchip/rk3066_hdmi.c
> @@ -725,7 +725,6 @@ static struct i2c_adapter *rk3066_hdmi_i2c_adapter(struct rk3066_hdmi *hdmi)
> init_completion(&i2c->cmpltn);
>
> adap = &i2c->adap;
> - adap->class = I2C_CLASS_DDC;
> adap->owner = THIS_MODULE;
> adap->dev.parent = hdmi->dev;
> adap->dev.of_node = hdmi->dev->of_node;
>
>
next prev parent reply other threads:[~2023-11-13 20:42 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 11:23 [PATCH 00/20] remove I2C_CLASS_DDC support Heiner Kallweit
2023-11-13 11:23 ` [PATCH 01/20] drivers/gpu/drm/rockchip: " Heiner Kallweit
2023-11-13 20:42 ` Heiko Stübner [this message]
2023-11-13 11:23 ` [PATCH 02/20] drivers/gpu/drm/mgag200/mgag200_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 03/20] drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c: " Heiner Kallweit
2023-11-13 17:50 ` Harry Wentland
2023-11-13 18:32 ` Heiner Kallweit
2023-11-16 19:18 ` Alex Deucher
2023-11-13 11:23 ` [PATCH 04/20] drivers/gpu/drm/sun4i/sun4i_hdmi_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 05/20] drivers/video/fbdev: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 06/20] drivers/video/fbdev/core/fb_ddc.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 07/20] drivers/gpu/drm: " Heiner Kallweit
2023-11-16 19:16 ` Alex Deucher
2023-11-13 11:23 ` [PATCH 08/20] drivers/gpu/drm/loongson/lsdc_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 09/20] drivers/video/fbdev/via/via_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 10/20] drivers/video/fbdev/cyber2000fb.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 11/20] drivers/gpu/drm/bridge/synopsys/dw-hdmi.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 12/20] drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 13/20] drivers/video/fbdev/intelfb/intelfb_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 14/20] drivers/gpu/drm/msm/hdmi/hdmi_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 15/20] drivers/gpu/drm/i915/display: " Heiner Kallweit
2023-11-13 12:17 ` Jani Nikula
2023-11-13 12:32 ` Heiner Kallweit
2023-11-13 17:50 ` Jani Nikula
2023-11-13 18:20 ` Heiner Kallweit
2023-11-13 11:23 ` [PATCH 16/20] drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 17/20] drivers/gpu/drm/ast/ast_i2c.c: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 18/20] drivers/gpu/drm/gma500: " Heiner Kallweit
2023-11-13 11:23 ` [PATCH 19/20] drivers/gpu/drm/display: " Heiner Kallweit
2023-11-16 19:14 ` Alex Deucher
2023-11-13 17:49 ` [PATCH 00/20] " Wolfram Sang
2023-11-13 18:21 ` Heiner Kallweit
2023-11-13 20:54 ` Wolfram Sang
2023-11-16 19:17 ` Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6269120.1IzOArtZ34@diego \
--to=heiko@sntech.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=hkallweit1@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mripard@kernel.org \
--cc=tzimmermann@suse.de \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).