From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs Date: Thu, 8 Dec 2016 13:37:57 +0200 Message-ID: <6288d19f-0975-cbb8-71db-62b47a636f0d@ti.com> References: <1480687631-22196-1-git-send-email-tomi.valkeinen@ti.com> <2844580.rlqx11OSCG@avalon> <2b43face-7038-9029-8730-f82189e58bcf@ti.com> <1622574.C8YJoFl6Ho@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0288861796==" Return-path: Received: from lelnx194.ext.ti.com (lelnx194.ext.ti.com [198.47.27.80]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1DF1B6E739 for ; Thu, 8 Dec 2016 11:38:03 +0000 (UTC) In-Reply-To: <1622574.C8YJoFl6Ho@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============0288861796== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4eluViwvfjwv8lJQjFcn9mjxBnGW7IxXv" --4eluViwvfjwv8lJQjFcn9mjxBnGW7IxXv Content-Type: multipart/mixed; boundary="SKST8AAkKeu6QPefuf8v93dfSebO2hBmc"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org Message-ID: <6288d19f-0975-cbb8-71db-62b47a636f0d@ti.com> Subject: Re: [PATCHv2 2/2] drm/omap: fix primary-plane's possible_crtcs References: <1480687631-22196-1-git-send-email-tomi.valkeinen@ti.com> <2844580.rlqx11OSCG@avalon> <2b43face-7038-9029-8730-f82189e58bcf@ti.com> <1622574.C8YJoFl6Ho@avalon> In-Reply-To: <1622574.C8YJoFl6Ho@avalon> --SKST8AAkKeu6QPefuf8v93dfSebO2hBmc Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 02/12/16 17:56, Laurent Pinchart wrote: > Hi Tomi, >=20 > On Friday 02 Dec 2016 17:55:10 Tomi Valkeinen wrote: >> On 02/12/16 17:42, Laurent Pinchart wrote: >>> I can understand that (even if I'm not sure it's really an issue, and= we >>> should really clean up the CRTC creation code at some point), but how= >>> about adding a possible_crtcs field to the priv structure then ? I do= n't >>> really like having to pass it around through a bunch of functions. >> >> It is passed to two functions, I'm not sure if that's a bunch =3D). >> >> I can do as you suggest, but I don't like adding fields to structs for= >> things that we only need once. >=20 > I'm not too fond of that either, hence my first suggestion :-) >=20 >> I think local variables and function parameters are for that. >> >> But I agree that the patch would be quite a bit smaller with the field= , >> so... >=20 > I won't nack any solution you end up selecting even if I have my prefer= ences. I'll go with the posted v2. I agree it's not perfect, but every other option I've tried also feels bad =3D). I think the only good solution is to rewrite the init parts, but I don't want to do that for a fix. Tomi --SKST8AAkKeu6QPefuf8v93dfSebO2hBmc-- --4eluViwvfjwv8lJQjFcn9mjxBnGW7IxXv Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJYSUYVAAoJEPo9qoy8lh71QGoQALJuZhf6dWjXyu4l5AZRx/6s VH1KLyScKfH+AlzJW3geLnpo/3sfQcRYFCj+igdp5ZcGDpinCPqSUbT8KZVuYWEt t35mL3jJBrykxb+sARTFke87xRlngvy2kNOFgh9UcmJ7Cl6RXPh0bcrwLi+F79rc /mTPu0q6DLmoqDDZaYUPZo/GWuVcha0O7roD27J1VHYmfpFxB/6UeRSmVo98QAHg kDkrEi7CjfdsepiTzdkcKeO9oJy7qQE8Gy1MByOZ6oCFN9goWnHq+gpctL3iMM+Y l4WLfBFIGOOPBS24qAAHG515GJvb+tFyNhcReSE6w/yXpqqRRoaItqJcSuPW1Hw5 AjvU3fAsCyplYXgD3tbKW1ctsseDm3PpFDJ3NSiwFfas/8w0QK5gLzJJoxionRrT vd5YCsctwZh0D3bbmi6QEO0qCHgLNnfWht8xgJ50/ejHNJqj47JPzKXAxyd+h5qR RqqAgX8rjXL6lIrutL50Opd7zUZEn/h7uHtKgalhpNfWcBf6105O4sfCc5vhGY8T w3omhkR9jXzTc6H7zgX6enhJwmb7LozPWXa2MRKoQvwYzxUM6jzFwXRBccEBZWcN pcawfE8MXq5dodY2OwLbLRzOjgoA0yp6tyMBt4ciaZbX1/tZ5ugqAm7ikvDEmroy s12jKapHd3v4muxk6Ebb =fJac -----END PGP SIGNATURE----- --4eluViwvfjwv8lJQjFcn9mjxBnGW7IxXv-- --===============0288861796== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============0288861796==--