From: Jeffrey Hugo <quic_jhugo@quicinc.com>
To: Stanislaw Gruszka <stanislaw.gruszka@linux.intel.com>,
<dri-devel@lists.freedesktop.org>
Cc: Oded Gabbay <ogabbay@kernel.org>,
Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
Subject: Re: [RFC 1/4] accel/ivpu: Allocate vpu_addr in gem->open() callback
Date: Mon, 11 Sep 2023 09:19:03 -0600 [thread overview]
Message-ID: <62e3769d-b747-9258-c330-97c034ea52ec@quicinc.com> (raw)
In-Reply-To: <20230901164842.178654-2-stanislaw.gruszka@linux.intel.com>
On 9/1/2023 10:48 AM, Stanislaw Gruszka wrote:
> From: Jacek Lawrynowicz <jacek.lawrynowicz@linux.intel.com>
>
> gem->open() is called during handle creation for a gem object.
> It is called during prime import and in BO_CREATE ioctl.
I feel like the "why" is missing. This appears to start to explain how
gem->open() might be useful for the driver, but does not seem to
complete explaining the connection to the driver. From the code
changes, it looks like using gem->open() simplifies the code by
allocating the vpu_addr in one place for all BOs. If that is the goal,
I feel that it should be mentioned here.
next prev parent reply other threads:[~2023-09-11 15:19 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 16:48 [RFC 0/4] accel/ivpu: Use GEM shmem Stanislaw Gruszka
2023-09-01 16:48 ` [RFC 1/4] accel/ivpu: Allocate vpu_addr in gem->open() callback Stanislaw Gruszka
2023-09-11 15:19 ` Jeffrey Hugo [this message]
2023-09-19 9:24 ` Stanislaw Gruszka
2023-09-22 15:20 ` Jeffrey Hugo
2023-09-01 16:48 ` [RFC 2/4] accel/ivpu: Fix locking in ivpu_bo_remove_all_bos_from_context() Stanislaw Gruszka
2023-09-11 15:21 ` Jeffrey Hugo
2023-09-01 16:48 ` [RFC 3/4] accel/ivpu: Remove support for uncached buffers Stanislaw Gruszka
2023-09-11 15:24 ` Jeffrey Hugo
2023-09-19 9:49 ` Stanislaw Gruszka
2023-09-22 15:21 ` Jeffrey Hugo
2023-09-01 16:48 ` [RFC 4/4] accel/ivpu: Use GEM shmem helper for all buffers Stanislaw Gruszka
2023-09-11 15:27 ` Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=62e3769d-b747-9258-c330-97c034ea52ec@quicinc.com \
--to=quic_jhugo@quicinc.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.lawrynowicz@linux.intel.com \
--cc=ogabbay@kernel.org \
--cc=stanislaw.gruszka@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox