From: "Heiko Stübner" <heiko@sntech.de>
To: andrzej.hajda@intel.com, neil.armstrong@linaro.org,
rfoss@kernel.org, Damon Ding <damon.ding@rock-chips.com>
Cc: Laurent.pinchart@ideasonboard.com, jonas@kwiboo.se,
jernej.skrabec@gmail.com, maarten.lankhorst@linux.intel.com,
mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com,
simona@ffwll.ch, jingoohan1@gmail.com, inki.dae@samsung.com,
sw0312.kim@samsung.com, kyungmin.park@samsung.com,
krzk@kernel.org, alim.akhtar@samsung.com, hjc@rock-chips.com,
andy.yan@rock-chips.com, dmitry.baryshkov@oss.qualcomm.com,
l.stach@pengutronix.de, dianders@chromium.org,
dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org,
linux-rockchip@lists.infradead.org,
Damon Ding <damon.ding@rock-chips.com>
Subject: Re: [PATCH v2 05/12] drm/exynos: exynos_dp: Remove redundant &analogix_dp_plat_data.skip_connector
Date: Wed, 09 Jul 2025 21:58:17 +0200 [thread overview]
Message-ID: <6306541.2iPT33SAM4@diego> (raw)
In-Reply-To: <20250709070139.3130635-6-damon.ding@rock-chips.com>
Hi Damon,
Am Mittwoch, 9. Juli 2025, 09:01:32 Mitteleuropäische Sommerzeit schrieb Damon Ding:
> The &analogix_dp_plat_data.skip_connector related check can be replaced
> by &analogix_dp_plat_data.bridge.
>
> Signed-off-by: Damon Ding <damon.ding@rock-chips.com>
> ---
> drivers/gpu/drm/exynos/exynos_dp.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/exynos/exynos_dp.c b/drivers/gpu/drm/exynos/exynos_dp.c
> index 9d7d3f009e58..9e1313fdecad 100644
> --- a/drivers/gpu/drm/exynos/exynos_dp.c
> +++ b/drivers/gpu/drm/exynos/exynos_dp.c
> @@ -237,7 +237,6 @@ static int exynos_dp_probe(struct platform_device *pdev)
> dp->plat_data.power_off = exynos_dp_poweroff;
> dp->plat_data.attach = exynos_dp_bridge_attach;
> dp->plat_data.get_modes = exynos_dp_get_modes;
> - dp->plat_data.skip_connector = !!bridge;
>
> out:
> dp->adp = analogix_dp_probe(dev, &dp->plat_data);
>
I think you might want to merge
- drm/exynos: exynos_dp: Remove redundant &analogix_dp_plat_data.skip_connector
- drm/bridge: analogix_dp: Remove redundant &analogix_dp_plat_data.skip_connector
Because when separate this creates a bisection issue.
Like when a bisect happens to land directly on this commit, you already have
removed the exynos assignment, but the updated check from the following patch
is not yet in place.
next prev parent reply other threads:[~2025-07-09 19:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20250709070241eucas1p1351e2b508cc648d1fafd93640b471e7b@eucas1p1.samsung.com>
2025-07-09 7:01 ` [PATCH v2 00/12] Apply drm_bridge_connector helper for the Analogix DP driver Damon Ding
2025-07-09 7:01 ` [PATCH v2 01/12] drm/bridge: analogix_dp: Formalize the struct analogix_dp_device Damon Ding
2025-07-09 7:01 ` [PATCH v2 02/12] drm/bridge: analogix_dp: Move &drm_bridge_funcs.mode_set to &drm_bridge_funcs.atomic_enable Damon Ding
2025-07-09 7:01 ` [PATCH v2 03/12] drm/bridge: analogix_dp: Add &analogix_dp_plat_data.bridge Damon Ding
2025-07-09 7:01 ` [PATCH v2 04/12] drm/exynos: exynos_dp: Remove &exynos_dp_device.ptn_bridge Damon Ding
2025-07-09 19:55 ` Heiko Stübner
2025-07-11 7:20 ` Damon Ding
2025-07-09 7:01 ` [PATCH v2 05/12] drm/exynos: exynos_dp: Remove redundant &analogix_dp_plat_data.skip_connector Damon Ding
2025-07-09 19:58 ` Heiko Stübner [this message]
2025-07-11 7:26 ` Damon Ding
2025-07-09 7:01 ` [PATCH v2 06/12] drm/bridge: analogix_dp: " Damon Ding
2025-07-09 7:01 ` [PATCH v2 07/12] drm/bridge: analogix_dp: Add support to find panel or bridge Damon Ding
2025-07-09 20:07 ` Heiko Stübner
2025-07-11 7:41 ` Damon Ding
2025-07-21 7:36 ` Damon Ding
2025-07-09 7:01 ` [PATCH v2 08/12] drm/rockchip: analogix_dp: Apply drmm_encoder_init() instead of drm_simple_encoder_init() Damon Ding
2025-07-09 7:01 ` [PATCH v2 09/12] drm/rockchip: analogix_dp: Apply analogix_dp_find_panel_or_bridge() Damon Ding
2025-07-09 7:01 ` [PATCH v2 10/12] drm/exynos: exynos_dp: " Damon Ding
2025-07-09 7:01 ` [PATCH v2 11/12] drm/bridge: analogix_dp: Remove unused APIs for AUX bus Damon Ding
2025-07-09 7:01 ` [PATCH v2 12/12] drm/bridge: analogix_dp: Apply drm_bridge_connector helper Damon Ding
2025-07-09 20:11 ` Heiko Stübner
2025-07-11 7:50 ` Damon Ding
2025-07-09 7:22 ` [PATCH v2 00/12] Apply drm_bridge_connector helper for the Analogix DP driver Marek Szyprowski
2025-07-11 7:16 ` Damon Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6306541.2iPT33SAM4@diego \
--to=heiko@sntech.de \
--cc=Laurent.pinchart@ideasonboard.com \
--cc=airlied@gmail.com \
--cc=alim.akhtar@samsung.com \
--cc=andrzej.hajda@intel.com \
--cc=andy.yan@rock-chips.com \
--cc=damon.ding@rock-chips.com \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=hjc@rock-chips.com \
--cc=inki.dae@samsung.com \
--cc=jernej.skrabec@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonas@kwiboo.se \
--cc=krzk@kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=l.stach@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=rfoss@kernel.org \
--cc=simona@ffwll.ch \
--cc=sw0312.kim@samsung.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).