From mboxrd@z Thu Jan 1 00:00:00 1970 From: Frediano Ziglio Subject: Re: [PATCH 1/3] drm/qxl: add mode/framebuffer check functions Date: Wed, 16 Jan 2019 04:24:51 -0500 (EST) Message-ID: <636470684.58090538.1547630691403.JavaMail.zimbra@redhat.com> References: <20190116083521.22673-1-kraxel@redhat.com> <20190116083521.22673-2-kraxel@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20190116083521.22673-2-kraxel@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spice-devel-bounces@lists.freedesktop.org Sender: "Spice-devel" To: Gerd Hoffmann Cc: David Airlie , open list , dri-devel@lists.freedesktop.org, "open list:DRM DRIVER FOR QXL VIRTUAL GPU" , Daniel Vetter , Dave Airlie , "open list:DRM DRIVER FOR QXL VIRTUAL GPU" List-Id: dri-devel@lists.freedesktop.org PiAKPiBBZGQgYSBoZWxwZXIgZnVuY3Rpb25zIHRvIGNoZWNrIHZpZGVvIG1vZGVzLiAgQWxzbyBh ZGQgYSBoZWxwZXIgdG8gY2hlY2sKPiBmcmFtZWJ1ZmZlciBidWZmZXIgb2JqZWN0cywgdXNpbmcg dGhlIGZvcm1lciBmb3IgY29uc2lzdGVuY3kuICBUaGF0IHdheQo+IHdlIHNob3VsZCBub3QgZmFp bCBpbiBxeGxfcHJpbWFyeV9hdG9taWNfY2hlY2soKSBiZWNhdXNlIHZpZGVvIG1vZGVzCj4gd2hp Y2ggYXJlIHRvbyBiaWcgd2lsbCBub3QgYmUgYWRkZWQgdG8gdGhlIG1vZGUgbGlzdCBpbiB0aGUg Zmlyc3QgcGxhY2UuCj4gCj4gU2lnbmVkLW9mZi1ieTogR2VyZCBIb2ZmbWFubiA8a3JheGVsQHJl ZGhhdC5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS9xeGwvcXhsX2Rpc3BsYXkuYyB8IDM3 ICsrKysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQs IDE5IGluc2VydGlvbnMoKyksIDE4IGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2 ZXJzL2dwdS9kcm0vcXhsL3F4bF9kaXNwbGF5LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9xeGwvcXhs X2Rpc3BsYXkuYwo+IGluZGV4IDFmOGZkZGNjMzQuLjA3YTM3ZDUyYzQgMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3F4bC9xeGxfZGlzcGxheS5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJt L3F4bC9xeGxfZGlzcGxheS5jCj4gQEAgLTE5MSw2ICsxOTEsMjEgQEAgdm9pZCBxeGxfZGlzcGxh eV9yZWFkX2NsaWVudF9tb25pdG9yc19jb25maWcoc3RydWN0Cj4gcXhsX2RldmljZSAqcWRldikK PiAgCX0KPiAgfQo+ICAKPiArc3RhdGljIGludCBxeGxfY2hlY2tfbW9kZShzdHJ1Y3QgcXhsX2Rl dmljZSAqcWRldiwKPiArCQkJICB1bnNpZ25lZCBpbnQgd2lkdGgsCj4gKwkJCSAgdW5zaWduZWQg aW50IGhlaWdodCkKPiArewo+ICsJaWYgKHdpZHRoICogaGVpZ2h0ICogNCA+IHFkZXYtPnZyYW1f c2l6ZSkKCklzIHNvbWVvbmUgY2hlY2tpbmcgZm9yIGludGVnZXIgb3ZlcmZsb3dzIGFscmVhZHk/ Cgo+ICsJCXJldHVybiAtRU5PTUVNOwo+ICsJcmV0dXJuIDA7Cj4gK30KPiArCj4gK3N0YXRpYyBp bnQgcXhsX2NoZWNrX2ZyYW1lYnVmZmVyKHN0cnVjdCBxeGxfZGV2aWNlICpxZGV2LAo+ICsJCQkJ IHN0cnVjdCBxeGxfYm8gKmJvKQo+ICt7Cj4gKwlyZXR1cm4gcXhsX2NoZWNrX21vZGUocWRldiwg Ym8tPnN1cmYud2lkdGgsIGJvLT5zdXJmLmhlaWdodCk7Cj4gK30KPiArCj4gIHN0YXRpYyBpbnQg cXhsX2FkZF9tb25pdG9yc19jb25maWdfbW9kZXMoc3RydWN0IGRybV9jb25uZWN0b3IgKmNvbm5l Y3RvciwKPiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB1bnNpZ25l ZCAqcHdpZHRoLAo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVu c2lnbmVkICpwaGVpZ2h0KQo+IEBAIC00NjYsMTIgKzQ4MSw3IEBAIHN0YXRpYyBpbnQgcXhsX3By aW1hcnlfYXRvbWljX2NoZWNrKHN0cnVjdCBkcm1fcGxhbmUKPiAqcGxhbmUsCj4gIAo+ICAJYm8g PSBnZW1fdG9fcXhsX2JvKHN0YXRlLT5mYi0+b2JqWzBdKTsKPiAgCj4gLQlpZiAoYm8tPnN1cmYu c3RyaWRlICogYm8tPnN1cmYuaGVpZ2h0ID4gcWRldi0+dnJhbV9zaXplKSB7Cj4gLQkJRFJNX0VS Uk9SKCJNb2RlIGRvZXNuJ3QgZml0IGluIHZyYW0gc2l6ZSAodmdhbWVtKSIpOwo+IC0JCXJldHVy biAtRUlOVkFMOwo+IC0JfQo+IC0KPiAtCXJldHVybiAwOwo+ICsJcmV0dXJuIHF4bF9jaGVja19m cmFtZWJ1ZmZlcihxZGV2LCBibyk7Cj4gIH0KPiAgCj4gIHN0YXRpYyBpbnQgcXhsX3ByaW1hcnlf YXBwbHlfY3Vyc29yKHN0cnVjdCBkcm1fcGxhbmUgKnBsYW5lKQo+IEBAIC05NDEsMjAgKzk1MSwx MSBAQCBzdGF0aWMgZW51bSBkcm1fbW9kZV9zdGF0dXMgcXhsX2Nvbm5fbW9kZV92YWxpZChzdHJ1 Y3QKPiBkcm1fY29ubmVjdG9yICpjb25uZWN0b3IsCj4gIHsKPiAgCXN0cnVjdCBkcm1fZGV2aWNl ICpkZGV2ID0gY29ubmVjdG9yLT5kZXY7Cj4gIAlzdHJ1Y3QgcXhsX2RldmljZSAqcWRldiA9IGRk ZXYtPmRldl9wcml2YXRlOwo+IC0JaW50IGk7Cj4gIAo+IC0JLyogVE9ETzogaXMgdGhpcyBjYWxs ZWQgZm9yIHVzZXIgZGVmaW5lZCBtb2Rlcz8gKHhyYW5kciAtLWFkZC1tb2RlKQo+IC0JICogVE9E TzogY2hlY2sgdGhhdCB0aGUgbW9kZSBmaXRzIGluIHRoZSBmcmFtZWJ1ZmZlciAqLwo+ICsJaWYg KHF4bF9jaGVja19tb2RlKHFkZXYsIG1vZGUtPmhkaXNwbGF5LCBtb2RlLT52ZGlzcGxheSkgIT0g MCkKPiArCQlyZXR1cm4gTU9ERV9CQUQ7Cj4gIAo+IC0JaWYgKHFkZXYtPm1vbml0b3JzX2NvbmZp Z193aWR0aCA9PSBtb2RlLT5oZGlzcGxheSAmJgo+IC0JICAgIHFkZXYtPm1vbml0b3JzX2NvbmZp Z19oZWlnaHQgPT0gbW9kZS0+dmRpc3BsYXkpCj4gLQkJcmV0dXJuIE1PREVfT0s7Cj4gLQo+IC0J Zm9yIChpID0gMDsgaSA8IEFSUkFZX1NJWkUoY29tbW9uX21vZGVzKTsgaSsrKSB7Cj4gLQkJaWYg KGNvbW1vbl9tb2Rlc1tpXS53ID09IG1vZGUtPmhkaXNwbGF5ICYmIGNvbW1vbl9tb2Rlc1tpXS5o ID09Cj4gbW9kZS0+dmRpc3BsYXkpCj4gLQkJCXJldHVybiBNT0RFX09LOwo+IC0JfQo+IC0JcmV0 dXJuIE1PREVfQkFEOwo+ICsJcmV0dXJuIE1PREVfT0s7Cj4gIH0KPiAgCj4gIHN0YXRpYyBzdHJ1 Y3QgZHJtX2VuY29kZXIgKnF4bF9iZXN0X2VuY29kZXIoc3RydWN0IGRybV9jb25uZWN0b3IgKmNv bm5lY3RvcikKCkZyZWRpYW5vCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fClNwaWNlLWRldmVsIG1haWxpbmcgbGlzdApTcGljZS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9zcGljZS1kZXZlbAo=