From mboxrd@z Thu Jan 1 00:00:00 1970 From: Markus Elfring Subject: [PATCH] drm/komeda: Use devm_platform_ioremap_resource() in komeda_dev_create() Date: Sat, 21 Sep 2019 19:50:46 +0200 Message-ID: <64a6ea39-3e4b-2ebe-74f7-98720e581e3e@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Return-path: Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: dri-devel@lists.freedesktop.org, Brian Starkey , Daniel Vetter , David Airlie , "James (Qian) Wang" , Liviu Dudau Cc: LKML , kernel-janitors@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org From: Markus Elfring Date: Sat, 21 Sep 2019 19:43:51 +0200 Simplify this function implementation by using a known wrapper function. This issue was detected by using the Coccinelle software. Signed-off-by: Markus Elfring =2D-- drivers/gpu/drm/arm/display/komeda/komeda_dev.c | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c b/drivers/gpu= /drm/arm/display/komeda/komeda_dev.c index ca64a129c594..a387d923962e 100644 =2D-- a/drivers/gpu/drm/arm/display/komeda/komeda_dev.c +++ b/drivers/gpu/drm/arm/display/komeda/komeda_dev.c @@ -172,19 +172,12 @@ struct komeda_dev *komeda_dev_create(struct device *= dev) struct platform_device *pdev =3D to_platform_device(dev); const struct komeda_product_data *product; struct komeda_dev *mdev; - struct resource *io_res; int err =3D 0; product =3D of_device_get_match_data(dev); if (!product) return ERR_PTR(-ENODEV); - io_res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!io_res) { - DRM_ERROR("No registers defined.\n"); - return ERR_PTR(-ENODEV); - } - mdev =3D devm_kzalloc(dev, sizeof(*mdev), GFP_KERNEL); if (!mdev) return ERR_PTR(-ENOMEM); @@ -192,7 +185,7 @@ struct komeda_dev *komeda_dev_create(struct device *de= v) mutex_init(&mdev->lock); mdev->dev =3D dev; - mdev->reg_base =3D devm_ioremap_resource(dev, io_res); + mdev->reg_base =3D devm_platform_ioremap_resource(pdev, 0); if (IS_ERR(mdev->reg_base)) { DRM_ERROR("Map register space failed.\n"); err =3D PTR_ERR(mdev->reg_base); =2D- 2.23.0