From: Markus Elfring <Markus.Elfring@web.de>
To: Brigham Campbell <me@brighamcampbell.com>,
dri-devel@lists.freedesktop.org, lkp@intel.com
Cc: LKML <linux-kernel@vger.kernel.org>,
Julia Lawall <julia.lawall@inria.fr>,
Oded Gabbay <ogabbay@kernel.org>,
Tomeu Vizoso <tomeu@tomeuvizoso.net>
Subject: Re: [PATCH] accel/rocket: Fix usages of kfree() and sizeof()
Date: Wed, 13 Aug 2025 19:56:35 +0200 [thread overview]
Message-ID: <65769f0a-af9f-4e96-93d4-8594e76d8e73@web.de> (raw)
In-Reply-To: <20250813-rocket-free-fix-v1-1-51f00a7a1271@brighamcampbell.com>
> Replace usages of kfree() with kvfree() for pointers which were
> allocated using kvmalloc(), as required by the kernel memory management
> API.
How do you think about to add any tags (like “Fixes” and “Cc”) accordingly?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc1#n145
> Use sizeof() on the type that a pointer references instead of …
Would it be helpful to offer desirable changes by separate update steps?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.17-rc1#n81
Regards,
Markus
next prev parent reply other threads:[~2025-08-13 17:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-13 16:02 [PATCH] accel/rocket: Fix usages of kfree() and sizeof() Brigham Campbell
2025-08-13 17:56 ` Markus Elfring [this message]
2025-08-14 3:56 ` Brigham Campbell
2025-08-14 6:19 ` Markus Elfring
2025-09-01 15:43 ` [PATCH] " Tomeu Vizoso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=65769f0a-af9f-4e96-93d4-8594e76d8e73@web.de \
--to=markus.elfring@web.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=julia.lawall@inria.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=me@brighamcampbell.com \
--cc=ogabbay@kernel.org \
--cc=tomeu@tomeuvizoso.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).