From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76D9EC4338F for ; Wed, 18 Aug 2021 15:04:23 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 429C5604D7 for ; Wed, 18 Aug 2021 15:04:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 429C5604D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5EFA089B29; Wed, 18 Aug 2021 15:04:22 +0000 (UTC) Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id 099F989B29 for ; Wed, 18 Aug 2021 15:04:21 +0000 (UTC) Received: by mail-lj1-x236.google.com with SMTP id h11so5631869ljo.12 for ; Wed, 18 Aug 2021 08:04:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Xr9jfom6cWdr34E1fd8HPE7h7ktRyhvZRNFf4lj4jAQ=; b=d7vWQtfYNwjvKTlX+D7cGmxzglW4/UcbCP3k883yPwOnxzLjUO0MPLUtr+mkpWt1Oi P6esNY3xCKInvn9sKG4XBfONscW0AIoeu5bJLV5ZTKWBGLAhdZ64HG8UcVIz6r2nfQQl Yrxf+zPusVZGvFkC4QytKocyFHnvXnTinlNufGur7yB83siMoPE+NlIFcdErvMFOvaRm djF5sqCwTodRZH48kqlk0WysuoONIiF9oO3KYSPg+WVHw6iqzbFtFUS7q02t5k20ekd+ 45EsBKWTuCNLNfcORCVLawHr8Q3kMXd1Bq4Pg8JARvc5KVV1TVghp79Rl7Nr3fufWiW5 iqfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Xr9jfom6cWdr34E1fd8HPE7h7ktRyhvZRNFf4lj4jAQ=; b=D9pmECR0UHUoTQmM7OU/K1iHNOHdNvyeFv2AwRW01DQ7vKDRUx5TZ7sDZF+eBy2RF1 Us2HJfXPMsuk+9sTlmg6AOCbicj2shTFEq4WOxY3SG4oqkROLgdGQplXh9RKdS7om0g3 UU50zoqrYhI+RvQ9XdNi8y0qRbaFGuR+l8h8J7LAEuMFbDPC6YZQO5eAhKh+f5tb8wja MgHcRHsLuAWdIipnP3prZw6at5vxZfKlbOpFX2EWd33/XuPTAF+R2Lvb1lZCw/uC3jTS NA5qj03NfZuNP1K17nLXUG28NBCMbmH101NnZ2Ja6AEmSA9eK6DIKWU8k2piALsOO5gz HJmQ== X-Gm-Message-State: AOAM530nzYyKmjiETqPC+cCwtalIz/2f7lIr8rf86M7QOGGPMV7uK0YW FAe5iHQHl7WqhY0yAlVcc50= X-Google-Smtp-Source: ABdhPJyyQVKytu447MFJPeps/ZgloBzDSSZ92Nm3+pCI6+S9Y81A/uwqWMGjetCbs6/mNtqN/r95BQ== X-Received: by 2002:a2e:99da:: with SMTP id l26mr8197284ljj.339.1629299059349; Wed, 18 Aug 2021 08:04:19 -0700 (PDT) Received: from [192.168.2.145] (46-138-85-91.dynamic.spd-mgts.ru. [46.138.85.91]) by smtp.googlemail.com with ESMTPSA id q5sm517822lfb.78.2021.08.18.08.04.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Aug 2021 08:04:18 -0700 (PDT) Subject: Re: [PATCH v8 06/34] dt-bindings: clock: tegra-car: Document new tegra-clocks sub-node To: Thierry Reding Cc: Rob Herring , Jonathan Hunter , Ulf Hansson , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Mark Brown , Lee Jones , =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Nishanth Menon , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Adrian Hunter , Mauro Carvalho Chehab , Michael Turquette , linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, linux-pm@vger.kernel.org, linux-usb@vger.kernel.org, linux-staging@lists.linux.dev, linux-spi@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-clk@vger.kernel.org References: <20210817012754.8710-1-digetx@gmail.com> <20210817012754.8710-7-digetx@gmail.com> <06128217-92e1-9b66-64ea-91855d041121@gmail.com> From: Dmitry Osipenko Message-ID: <659df86d-4fa1-b541-3d0d-8a1622fe7068@gmail.com> Date: Wed, 18 Aug 2021 18:04:17 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" 18.08.2021 16:52, Thierry Reding пишет: > On Wed, Aug 18, 2021 at 04:44:30AM +0300, Dmitry Osipenko wrote: >> 18.08.2021 04:15, Rob Herring пишет: >>>> + tegra-clocks: >>>> + description: child nodes are the output clocks from the CAR >>>> + type: object >>>> + >>>> + patternProperties: >>>> + "^[a-z]+[0-9]+$": >>>> + type: object >>>> + properties: >>>> + compatible: >>>> + allOf: >>>> + - items: >>>> + - enum: >>>> + - nvidia,tegra20-sclk >>>> + - nvidia,tegra30-sclk >>>> + - nvidia,tegra30-pllc >>>> + - nvidia,tegra30-plle >>>> + - nvidia,tegra30-pllm >>>> + - const: nvidia,tegra-clock >>> You are saying the first string must be both one of the enums and >>> 'nvidia,tegra-clock'. You don't get an error because your pattern >>> doesn't match 'sclk'. >>> >> >> Could you please rephrase or clarify? If pattern doesn't match 'sclk', >> then it must match any other enum. I'm not sure what you're meaning. > > "sclk" doesn't match "^[a-z]+[0-9]+$" because it's missing at least one > digit at the end. Perhaps that last + was supposed to be *? Ah, the regex pattern. Yes, I forgot to update it. >> The 'nvidia,tegra-clock' actually could be removed since it's >> superfluous now. I'll consider the removal in v9. > > It also looks like your schema was meant to be something like: > > compatible: > - items: > - enum: > - nvidia,tegra20-sclk > - nvidia,tegra30-sclk > - nvidia,tegra30-pllc > - nvidia,tegra30-plle > - nvidia,tegra30-pllm > - const: nvidia,tegra-clock > > Note how the const: element is indented one more level. Now this means: > one of the enumeration values, followed by the constant value. That > matches what the example has. > > That said, I agree that nvidia,tegra-clock seems a bit useless. There's > really no such thing as a generic clock, they're all different in some > way. It's a leftover from older versions of this patchset, I'll remove it.