From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hans de Goede Subject: Re: [PATCH 11/15] staging: vboxvideo: Fix DPMS support after atomic conversion Date: Mon, 1 Oct 2018 23:14:47 +0200 Message-ID: <6652863f-362f-aea2-4a46-319ecd13e014@redhat.com> References: <20180926194206.23517-1-hdegoede@redhat.com> <20180926194206.23517-12-hdegoede@redhat.com> <20181001075344.GR11082@phenom.ffwll.local> <501c05d9-e053-b74f-f7b5-6253797e32c4@redhat.com> <20181001165222.GE11082@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by gabe.freedesktop.org (Postfix) with ESMTPS id DB653894DE for ; Mon, 1 Oct 2018 21:14:50 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id j62-v6so182578edd.7 for ; Mon, 01 Oct 2018 14:14:50 -0700 (PDT) In-Reply-To: <20181001165222.GE11082@phenom.ffwll.local> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Daniel Vetter Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , Michael Thayer , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiAwMS0xMC0xOCAxODo1MiwgRGFuaWVsIFZldHRlciB3cm90ZToKPiBPbiBNb24sIE9j dCAwMSwgMjAxOCBhdCAxMTozNzoyOUFNICswMjAwLCBIYW5zIGRlIEdvZWRlIHdyb3RlOgo+PiBI aSwKPj4KPj4gT24gMDEtMTAtMTggMDk6NTMsIERhbmllbCBWZXR0ZXIgd3JvdGU6Cj4+PiBPbiBX ZWQsIFNlcCAyNiwgMjAxOCBhdCAwOTo0MjowMlBNICswMjAwLCBIYW5zIGRlIEdvZWRlIHdyb3Rl Ogo+Pj4+IEF0b21pYyBtb2Rlc2V0dGluZyBkb2VzIG5vdCB1c2UgdGhlIHRyYWRpdGlvbmFsIGRw bXMgY2FsbCBiYWNrcywgaW5zdGVhZAo+Pj4+IHdlIHNob3VsZCBjaGVjayBjcnRjX3N0YXRlLT5h Y3RpdmUuCj4+Pj4KPj4+PiBTaWduZWQtb2ZmLWJ5OiBIYW5zIGRlIEdvZWRlIDxoZGVnb2VkZUBy ZWRoYXQuY29tPgo+Pj4KPj4+IEFyZSB5b3Ugc3VyZSB0aGlzIGRvZXMgd2hhdCB5b3Ugd2FudCBp dCB0byBkbz8gQXRvbWljIGhlbHBlcnMgZnVsbHkgc2h1dAo+Pj4gZG93biB0aGUgc2NyZWVuIHdo ZW4geW91IGRvIGEgZHBtcyBvZmYsICJqdXN0IGJsYW5rZWQiIGtpbmRhIGRvZXNuJ3QgZXhpc3QK Pj4+IGFzIGEgc3RhdGUgYnkgZGVmYXVsdC4KPj4KPj4gWWVzIEknbSBzdXJlIEkgdGVzdGVkICJ4 c2V0IGRwbXMgZm9yY2Ugb2ZmIiBhbmQgYmVmb3JlIHRoaXMgd291bGQKPj4gcmVzdWx0IGluIGlu IHRoZSB2aXJ0dWFsIG1vbml0b3JzIChqdXN0IHdpbmRvd3Mgb24gdGhlIGhvc3QpIHRvIHJlc2l6 ZSB0bwo+PiA2NDB4NDgwIGFuZCBpbiB0aGF0IDY0MHg0ODAgc3RpbGwgc2hvdyBwYXJ0IG9mIHRo ZSBvbGQgY29udGVudHMuCj4gCj4gSG0sIHRoaXMgc291bmRzIGEgYml0IGxpa2UgYSBidWcgaW4g eW91ciBjb2RlIHNvbWV3aGVyZSwgb3IgYXQgbGVhc3Qgbm90Cj4gMTAwJSBjb252ZXJ0ZWQgb3Zl ciB0byBhdG9taWMuIEZyb20gYSBkcml2ZXIgcG92IGl0IHNob3VsZCBiZSAxMDAlCj4gZXF1aXZh bGVudCBjb2RlIGJldHdlZW4gZHBtcyBvZmYgYW5kIHRoZSB4cmFuZHIgLS1vZmYuIElmIGRwbXMg c2hvd3Mgc29tZQo+IGdhcmJhZ2Ugd2l0aG91dCB0aGlzLCB0aGVuIHNvbWV0aGluZyBpcyB3cm9u Zy4KCkkgYmVsaWV2ZSB0aGUgMiBwYXRocyBhcmUgZGlmZmVyZW50LCB4cmFuZHIgLS1vZmYgYWN0 dWFsbHkgZG9lcyBhIG1vZGVzZXQKZGlzYWJsaW5nIHRoZSBjcnRjLCB3aGVyZSBhcyB4c2V0IGRw bXMgZm9yY2Ugb2ZmIGp1c3QgY2hhbmdlcyB0aGUgRFBNUwpwcm9wZXJ0eSBvbiB0aGUgY29ubmVj dG9yIHVzaW5nIHRoZSBub24gYXRvbWljIHByb3BlcnR5IGlvY3RscyBsZWFkaW5nIHRvCnRoZSBm b2xsb3dpbmcgY2FsbCBncmFwaDoKCmRybV9tb2RlX29ial9zZXRfcHJvcGVydHlfaW9jdGwoKQpz ZXRfcHJvcGVydHlfYXRvbWljKCkKZHJtX2F0b21pY19jb25uZWN0b3JfY29tbWl0X2RwbXMoKQoK V2l0aCB0aGUgbGFzdCBvbmUgaXRlcmF0aW5nIG92ZXIgYWxsIGNvbm5lY3RvcnMgb2YgdGhlIGNy dGMgdG8gd2hpY2gKdGhlIGNvbm5lY3RvciBpbiBxdWVzdGlvbiBpcyBjb25uZWN0ZWQgYW5kIHRo ZW4gc2V0dGluZwpjcnRjX3N0YXRlLT5hY3RpdmUgPSBmYWxzZSBpZiBhbGwgY29ubmVjdG9ycyBo YXZlIHRoZWlyIGRwbXMgdmFsdWUKc2V0IHRvIGEgdmFsdWUgIT0gRFJNX01PREVfRFBNU19PTi4K CkZvbGxvd2VkIGJ5IGEgZHJtX2F0b21pY19jb21taXQoKSBzbyBhbGwgdGhhdCBjaGFuZ2VzIGlu IHRoaXMgY29kZQpwYXRoIGlzIHRoZSBhY3RpdmUgcHJvcGVydHkgb2YgdGhlIGNydGNfc3RhdGUu IFdoZXJlIGFzIHdpdGggYSAtLW9mZiB0aGUKcHJpbWFyeSBwbGFuZV9zdGF0ZSB3aWxsIGdldCBp dHMgZmIgKGFuZCBjcnRjKSBzZXQgdG8gTlVMTC4KCj4gVGhlIG9ubHkgZGlmZmVyZW5jZSBpcyB0 aGF0IGZvciBkcG1zIG9mZiB0aGUgaGVscGVycyBkb24ndCBjYWxsCj4gLT5jbGVhbnVwX3BsYW5l IChhbmQgdGhlbiAtPnByZXBhcmVfcGxhbmUgb24gcmUtZW5hYmxpbmcpLCBzaW5jZSB0aGUKPiBm cmFtZWJ1ZmZlcnMgYXJlIHN1cHBvc2VkIHRvIHN0aWNrIGFyb3VuZC4gQXJlIHlvdSBwZXJjaGFu Y2UgZG9pbmcgc29tZQo+IG1vZGVzZXQgcHJvZ3JhbW1pbmcgaW4gdGhlcmU/IFRoYXQgd291bGQg YmUgYSBidWcgaW4gdGhlIGF0b21pYwo+IGltcGxlbWVudGF0aW9uLgo+IAo+IGNydGNfc3RhdGUt PmFjdGl2ZSBzaG91bGQgb25seSBiZSBjb25zdWx0ZWQgZnJvbSBhdG9taWNfY2hlY2sgY2FsbGJh Y2tzLgo+IEkndmUgYWRkZWQgc29tZSBwcmV0dHkgbGVuZ3RoeSBrZXJuZWxkb2MgZm9yIHRoaXMg anVzdCByZWNlbnRseSwgdG8KPiBleHBsYWluIGJldHRlciBob3cgdGhpcyBpcyBzdXBwb3NlZCB0 byB3b3JrLgoKU2VlIGFib3ZlLCBJIGJlbGlldmUgdGhhdCB0aGUgY29kZSBwYXRoIHdoaWNoIEkg cG9pbnQgb3V0IGNoYW5nZXMKY3J0Y19zdGF0ZS0+YWN0aXZlIHdpdGhvdXQgbWFraW5nIGFueSBm dXJ0aGVyIGNoYW5nZXMuCgpJJ20gcHJldHR5IG5ldyB0byBhbGwgdGhpcywgc28gSSBjb3VsZCBi ZSB3cm9uZywgYnV0IHRoaXMgaXMgd2hhdApJIGJlbGlldmUgaXMgaGFwcGVuaW5nLgoKUmVnYXJk cywKCkhhbnMKCgoKCj4gCj4+IEFmdGVyIHRoaXMgcGF0Y2ggdGhleSBiZWNvbWUgYmxhY2sgaW5z dGVhZC4KPj4KPj4gTm90ZSBzb21ld2hhdCByZWxhdGVkLCBWaXJ0dWFsYm94IGRvZXMgbm90IGFs bG93IGNsb3NpbmcgYSB3aW5kb3cgZnJvbQo+PiB3aXRoaW4gdGhlIGd1ZXN0LCBpZiB0aGUgdXNl ciB3YW50cyB0byBzdG9wIHVzaW5nIGFuIChleHRyYSkgdmlydHVhbCBtb25pdG9yCj4+IGl0IG5l ZWRzIHRvIGJlIGRpc2FibGVkIGluIHRoZSBWTXMgVUkuIFR1cm5pbmcgb2YgYSBtb25pdG9yIHRo cm91Z2ggZS5nLgo+PiAieHJhbmRyIC0tb3V0cHV0IGZvbyAtLW9mZiIganVzdCBtYWtlcyB0aGUg d2luZG93IGJsYWNrLgo+IAo+IE9rIHRoYXQncyBmdW5ueSwgYnV0IHNob3VsZG4ndCBiZSByZWxh dGVkIHRvIHdoYXQncyBnb2luZyBvbiBoZXJlLgo+IC1EYW5pZWwKPiAKPj4KPj4gUmVnYXJkcywK Pj4KPj4gSGFucwo+Pgo+Pgo+Pgo+Pgo+Pj4gLURhbmllbAo+Pj4KPj4+PiAtLS0KPj4+PiAgICBk cml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zib3hfZHJ2LmggIHwgIDEgLQo+Pj4+ICAgIGRyaXZl cnMvc3RhZ2luZy92Ym94dmlkZW8vdmJveF9tb2RlLmMgfCAyOCArKy0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0KPj4+PiAgICAyIGZpbGVzIGNoYW5nZWQsIDIgaW5zZXJ0aW9ucygrKSwgMjcgZGVs ZXRpb25zKC0pCj4+Pj4KPj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9zdGFnaW5nL3Zib3h2aWRl by92Ym94X2Rydi5oIGIvZHJpdmVycy9zdGFnaW5nL3Zib3h2aWRlby92Ym94X2Rydi5oCj4+Pj4g aW5kZXggZmNjYjM4NTFkNmEzLi45Y2MyMGMxODJkZjEgMTAwNjQ0Cj4+Pj4gLS0tIGEvZHJpdmVy cy9zdGFnaW5nL3Zib3h2aWRlby92Ym94X2Rydi5oCj4+Pj4gKysrIGIvZHJpdmVycy9zdGFnaW5n L3Zib3h2aWRlby92Ym94X2Rydi5oCj4+Pj4gQEAgLTEzOSw3ICsxMzksNiBAQCBzdHJ1Y3QgdmJv eF9jb25uZWN0b3Igewo+Pj4+ICAgIHN0cnVjdCB2Ym94X2NydGMgewo+Pj4+ICAgIAlzdHJ1Y3Qg ZHJtX2NydGMgYmFzZTsKPj4+PiAtCWJvb2wgYmxhbmtlZDsKPj4+PiAgICAJYm9vbCBkaXNjb25u ZWN0ZWQ7Cj4+Pj4gICAgCXVuc2lnbmVkIGludCBjcnRjX2lkOwo+Pj4+ICAgIAl1MzIgZmJfb2Zm c2V0Owo+Pj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL3N0YWdpbmcvdmJveHZpZGVvL3Zib3hfbW9k ZS5jIGIvZHJpdmVycy9zdGFnaW5nL3Zib3h2aWRlby92Ym94X21vZGUuYwo+Pj4+IGluZGV4IGM0 ZWMzZmE0OTc4Mi4uNDlmZjljNGE2MzAyIDEwMDY0NAo+Pj4+IC0tLSBhL2RyaXZlcnMvc3RhZ2lu Zy92Ym94dmlkZW8vdmJveF9tb2RlLmMKPj4+PiArKysgYi9kcml2ZXJzL3N0YWdpbmcvdmJveHZp ZGVvL3Zib3hfbW9kZS5jCj4+Pj4gQEAgLTg0LDE0ICs4NCwxMyBAQCBzdGF0aWMgdm9pZCB2Ym94 X2RvX21vZGVzZXQoc3RydWN0IGRybV9jcnRjICpjcnRjKQo+Pj4+ICAgIAl9Cj4+Pj4gICAgCWZs YWdzID0gVkJWQV9TQ1JFRU5fRl9BQ1RJVkU7Cj4+Pj4gLQlmbGFncyB8PSAoZmIgJiYgIXZib3hf Y3J0Yy0+YmxhbmtlZCkgPyAwIDogVkJWQV9TQ1JFRU5fRl9CTEFOSzsKPj4+PiArCWZsYWdzIHw9 IChmYiAmJiBjcnRjLT5zdGF0ZS0+YWN0aXZlKSA/IDAgOiBWQlZBX1NDUkVFTl9GX0JMQU5LOwo+ Pj4+ICAgIAlmbGFncyB8PSB2Ym94X2NydGMtPmRpc2Nvbm5lY3RlZCA/IFZCVkFfU0NSRUVOX0Zf RElTQUJMRUQgOiAwOwo+Pj4+ICAgIAloZ3NtaV9wcm9jZXNzX2Rpc3BsYXlfaW5mbyh2Ym94LT5n dWVzdF9wb29sLCB2Ym94X2NydGMtPmNydGNfaWQsCj4+Pj4gICAgCQkJCSAgIHhfb2Zmc2V0LCB5 X29mZnNldCwKPj4+PiAgICAJCQkJICAgdmJveF9jcnRjLT54ICogYnBwIC8gOCArCj4+Pj4gICAg CQkJCQkJCXZib3hfY3J0Yy0+eSAqIHBpdGNoLAo+Pj4+IC0JCQkJICAgcGl0Y2gsIHdpZHRoLCBo ZWlnaHQsCj4+Pj4gLQkJCQkgICB2Ym94X2NydGMtPmJsYW5rZWQgPyAwIDogYnBwLCBmbGFncyk7 Cj4+Pj4gKwkJCQkgICBwaXRjaCwgd2lkdGgsIGhlaWdodCwgYnBwLCBmbGFncyk7Cj4+Pj4gICAg fQo+Pj4+ICAgIHN0YXRpYyBpbnQgdmJveF9zZXRfdmlldyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMp Cj4+Pj4gQEAgLTEyOCwyNyArMTI3LDYgQEAgc3RhdGljIGludCB2Ym94X3NldF92aWV3KHN0cnVj dCBkcm1fY3J0YyAqY3J0YykKPj4+PiAgICAJcmV0dXJuIDA7Cj4+Pj4gICAgfQo+Pj4+IC1zdGF0 aWMgdm9pZCB2Ym94X2NydGNfZHBtcyhzdHJ1Y3QgZHJtX2NydGMgKmNydGMsIGludCBtb2RlKQo+ Pj4+IC17Cj4+Pj4gLQlzdHJ1Y3QgdmJveF9jcnRjICp2Ym94X2NydGMgPSB0b192Ym94X2NydGMo Y3J0Yyk7Cj4+Pj4gLQlzdHJ1Y3QgdmJveF9wcml2YXRlICp2Ym94ID0gY3J0Yy0+ZGV2LT5kZXZf cHJpdmF0ZTsKPj4+PiAtCj4+Pj4gLQlzd2l0Y2ggKG1vZGUpIHsKPj4+PiAtCWNhc2UgRFJNX01P REVfRFBNU19PTjoKPj4+PiAtCQl2Ym94X2NydGMtPmJsYW5rZWQgPSBmYWxzZTsKPj4+PiAtCQli cmVhazsKPj4+PiAtCWNhc2UgRFJNX01PREVfRFBNU19TVEFOREJZOgo+Pj4+IC0JY2FzZSBEUk1f TU9ERV9EUE1TX1NVU1BFTkQ6Cj4+Pj4gLQljYXNlIERSTV9NT0RFX0RQTVNfT0ZGOgo+Pj4+IC0J CXZib3hfY3J0Yy0+YmxhbmtlZCA9IHRydWU7Cj4+Pj4gLQkJYnJlYWs7Cj4+Pj4gLQl9Cj4+Pj4g LQo+Pj4+IC0JbXV0ZXhfbG9jaygmdmJveC0+aHdfbXV0ZXgpOwo+Pj4+IC0JdmJveF9kb19tb2Rl c2V0KGNydGMpOwo+Pj4+IC0JbXV0ZXhfdW5sb2NrKCZ2Ym94LT5od19tdXRleCk7Cj4+Pj4gLX0K Pj4+PiAtCj4+Pj4gICAgLyoKPj4+PiAgICAgKiBUcnkgdG8gbWFwIHRoZSBsYXlvdXQgb2Ygdmly dHVhbCBzY3JlZW5zIHRvIHRoZSByYW5nZSBvZiB0aGUgaW5wdXQgZGV2aWNlLgo+Pj4+ICAgICAq IFJldHVybiB0cnVlIGlmIHdlIG5lZWQgdG8gcmUtc2V0IHRoZSBjcnRjIG1vZGVzIGR1ZSB0byBz Y3JlZW4gb2Zmc2V0Cj4+Pj4gQEAgLTI3Niw3ICsyNTQsNiBAQCBzdGF0aWMgdm9pZCB2Ym94X2Ny dGNfYXRvbWljX2ZsdXNoKHN0cnVjdCBkcm1fY3J0YyAqY3J0YywKPj4+PiAgICB9Cj4+Pj4gICAg c3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY3J0Y19oZWxwZXJfZnVuY3MgdmJveF9jcnRjX2hlbHBl cl9mdW5jcyA9IHsKPj4+PiAtCS5kcG1zID0gdmJveF9jcnRjX2RwbXMsCj4+Pj4gICAgCS5kaXNh YmxlID0gdmJveF9jcnRjX2Rpc2FibGUsCj4+Pj4gICAgCS5jb21taXQgPSB2Ym94X2NydGNfY29t bWl0LAo+Pj4+ICAgIAkuYXRvbWljX2ZsdXNoID0gdmJveF9jcnRjX2F0b21pY19mbHVzaCwKPj4+ PiBAQCAtODYxLDcgKzgzOCw2IEBAIHN0YXRpYyBjb25zdCBzdHJ1Y3QgZHJtX2Nvbm5lY3Rvcl9o ZWxwZXJfZnVuY3MgdmJveF9jb25uZWN0b3JfaGVscGVyX2Z1bmNzID0gewo+Pj4+ICAgIH07Cj4+ Pj4gICAgc3RhdGljIGNvbnN0IHN0cnVjdCBkcm1fY29ubmVjdG9yX2Z1bmNzIHZib3hfY29ubmVj dG9yX2Z1bmNzID0gewo+Pj4+IC0JLmRwbXMgPSBkcm1faGVscGVyX2Nvbm5lY3Rvcl9kcG1zLAo+ Pj4+ICAgIAkuZGV0ZWN0ID0gdmJveF9jb25uZWN0b3JfZGV0ZWN0LAo+Pj4+ICAgIAkuZmlsbF9t b2RlcyA9IHZib3hfZmlsbF9tb2RlcywKPj4+PiAgICAJLmRlc3Ryb3kgPSB2Ym94X2Nvbm5lY3Rv cl9kZXN0cm95LAo+Pj4+IC0tIAo+Pj4+IDIuMTkuMAo+Pj4+Cj4+Pj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPj4+PiBkcmktZGV2ZWwgbWFpbGluZyBs aXN0Cj4+Pj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+Pj4+IGh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4+Pgo+IApfX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFp bGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5m cmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK