From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Armstrong Subject: Re: [PATCH] drm/panfrost: Fix regulator_get_optional() misuse Date: Thu, 5 Sep 2019 15:49:19 +0200 Message-ID: <677fc044-6c12-6fb4-9d85-1e4d6c4b96ae@baylibre.com> References: <20190904123032.23263-1-broonie@kernel.org> <20190905124014.GA4053@sirena.co.uk> <93b8910d-fc01-4c16-fd7e-86abfc3cc617@arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wm1-x344.google.com (mail-wm1-x344.google.com [IPv6:2a00:1450:4864:20::344]) by gabe.freedesktop.org (Postfix) with ESMTPS id C9A8D6E0F4 for ; Thu, 5 Sep 2019 13:49:22 +0000 (UTC) Received: by mail-wm1-x344.google.com with SMTP id y135so5053031wmc.1 for ; Thu, 05 Sep 2019 06:49:22 -0700 (PDT) In-Reply-To: <93b8910d-fc01-4c16-fd7e-86abfc3cc617@arm.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Steven Price , Mark Brown Cc: David Airlie , Tomeu Vizoso , dri-devel , "linux-kernel@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org T24gMDUvMDkvMjAxOSAxNTowMiwgU3RldmVuIFByaWNlIHdyb3RlOgo+IE9uIDA1LzA5LzIwMTkg MTM6NDAsIE1hcmsgQnJvd24gd3JvdGU6Cj4+IE9uIFRodSwgU2VwIDA1LCAyMDE5IGF0IDEwOjM3 OjUzQU0gKzAxMDAsIFN0ZXZlbiBQcmljZSB3cm90ZToKPj4KPj4+IEFoLCBJIGRpZG4ndCByZWFs aXNlIHRoYXQgcmVndWxhdG9yX2dldCgpIHdpbGwgcmV0dXJuIGEgZHVtbXkgcmVndWxhdG9yCj4+ PiBpZiBub25lIGlzIHByb3ZpZGVkIGluIHRoZSBEVC4gSW4gdGhlb3J5IHRoYXQgc2VlbXMgbGlr ZSBhIG5pY2VyCj4+PiBzb2x1dGlvbiB0byBteSB0d28gY29tbWl0cy4gSG93ZXZlciB0aGVyZSdz IHN0aWxsIGEgcHJvYmxlbSAtIHRoZSBkdW1teQo+Pj4gcmVndWxhdG9yIHJldHVybmVkIGZyb20g cmVndWxhdG9yX2dldCgpIHJlcG9ydHMgZXJyb3JzIHdoZW4KPj4+IHJlZ3VsYXRvcl9zZXRfdm9s dGFnZSgpIGlzIGNhbGxlZC4gU28gSSBnZXQgZXJyb3JzIGxpa2UgdGhpczoKPj4KPj4+IFsgIDI5 OS44NjExNjVdIHBhbmZyb3N0IGU4MmMwMDAwLm1hbGk6IENhbm5vdCBzZXQgdm9sdGFnZSAxMTAw MDAwIHVWCj4+PiBbICAyOTkuODY3Mjk0XSBkZXZmcmVxIGRldmZyZXEwOiBkdmZzIGZhaWxlZCB3 aXRoICgtMjIpIGVycm9yCj4+Cj4+PiAoQW5kIHRoZXJlZm9yZSB0aGUgZnJlcXVlbmN5IGlzbid0 IGJlaW5nIGNoYW5nZWQpCj4+Cj4+PiBJZGVhbGx5IHdlIHdhbnQgYSBkdW1teSByZWd1bGF0b3Ig dGhhdCB3aWxsIHNpbGVudGx5IGlnbm9yZSBhbnkKPj4+IHJlZ3VsYXRvcl9zZXRfdm9sdGFnZSgp IGNhbGxzLgo+Pgo+PiBJcyB0aGF0IHNhZmU/ICBZb3UgY2FuJ3QgcmVseSBvbiBiZWluZyBhYmxl IHRvIGNoYW5nZSB2b2x0YWdlcyBldmVuIGlmCj4+IHRoZXJlJ3MgYSBwaHlzaWNhbCByZWd1bGF0 b3IgYXZhaWxhYmxlLCBzeXN0ZW0gY29uc3RyYWludHMgb3IgdGhlCj4+IHJlc3VsdHMgb2Ygc2hh cmluZyB0aGUgcmVndWxhdG9yIHdpdGggb3RoZXIgdXNlcnMgbWF5IHByZXZlbnQgY2hhbmdlcy4K PiAKPiBQZXJoYXBzIEkgZGlkbid0IGV4cHJlc3MgbXlzZWxmIGNsZWFybHkuIEkgbWVhbiB0aGF0 IGluIHRoZSBjYXNlIG9mIHRoZQo+IEhpa2V5OTYwIGl0IHdvdWxkIGJlIGNvbnZlbmllbnQgdG8g aGF2ZSBhICJkdW1teSByZWd1bGF0b3IiIHRoYXQgc2ltcGx5Cj4gYWNjZXB0ZWQgYW55IGNoYW5n ZSBiZWNhdXNlIHVsdGltYXRlbHkgTGludXggZG9lc24ndCBoYXZlIGRpcmVjdCBjb250cm9sCj4g b2YgdGhlIHZvbHRhZ2VzIGJ1dCBzaW1wbHkgcmVxdWVzdHMgYSBwYXJ0aWN1bGFyIG9wZXJhdGlu ZyBmcmVxdWVuY3kgdmlhCj4gdGhlIG1haWxib3guCj4gCj4+IEkgZ3Vlc3MgYXQgdGhlIG1pbnV0 ZSB0aGUgY29kZSBpcyBhc3N1bWluZyB0aGF0IGlmIHlvdSBjYW4ndCB2YXJ5IHRoZQo+PiByZWd1 bGF0b3IgaXQncyBmaXhlZCBhdCB0aGUgbWF4aW11bSB2b2x0YWdlIGFuZCB0aGF0IGl0J3Mgc2Fm ZSB0byBydW4gYXQKPj4gYSBsb3dlciBjbG9jayB3aXRoIGEgaGlnaGVyIHZvbHRhZ2UgKHNvbWUg ZGV2aWNlcyBkb24ndCBsaWtlIGRvaW5nIHRoYXQpLgo+IAo+IE5vIC0gYXQgdGhlIG1vbWVudCBp ZiB0aGUgcmVndWxhdG9yIHJlcG9ydHMgYW4gZXJyb3IgdGhlbiB0aGUgZnVuY3Rpb24KPiBiYWls cyBvdXQgYW5kIGRvZXNuJ3QgY2hhbmdlIHRoZSBmcmVxdWVuY3kuCj4gCj4+IElmIHRoZSBkZXZp Y2UgYWx3YXlzIHN0YXJ0cyB1cCBhdCBmdWxsIHNwZWVkIEkgZ3Vlc3MgdGhhdCdzIE9LLiAgSXQn cwo+PiBjZXJ0YWlubHkgaW4gZ2VuZXJhbCBhIGJhZCBpZGVhIHRvIGRvIHRoaXMgaW4gZ2VuZXJh bCwgd2UgY2FuJ3QgdGVsbCBob3cKPj4gaW1wb3J0YW50IGl0IGlzIHRvIHRoZSBjb25zdW1lciB0 aGF0IHRoZXkgYWN0dWFsbHkgZ2V0IHRoZSB2b2x0YWdlIHRoYXQKPj4gdGhleSBhc2tlZCBmb3Ig LSBmb3Igc29tZSBhcHBsaWNhdGlvbnMgbGlrZSB0aGlzIGl0J3MganVzdCBhZGRpbmcgdG8gdGhl Cj4+IHBvd2VyIHNhdmluZyBpdCdzIGxpa2VseSBmaW5lIGJ1dCBmb3Igb3RoZXJzIGl0IG1pZ2h0 IGJyZWFrIHRoaW5ncy4KPiAKPiBBZ3JlZWQuCj4gCj4+IElmIHlvdSdyZSBoYXBweSB0byBjaGFu Z2UgdGhlIGZyZXF1ZW5jeSB3aXRob3V0IHRoZSBhYmlsaXR5IHRvIHZhcnkgdGhlCj4+IHZvbHRh Z2UgeW91IGNhbiBxdWVyeSB3aGF0J3Mgc3VwcG9ydGVkIHRocm91Z2ggdGhlIEFQSSAodGhlIHNp bXBsZXN0Cj4+IGludGVyZmFjZSBpcyByZWd1bGF0b3JfaXNfc3VwcG9ydGVkX3ZvbHRhZ2UoKSku ICBZb3Ugc2hvdWxkIGRvIHRoZQo+PiByZWd1bGF0b3IgQVBJIHF1ZXJpZXMgYXQgaW5pdGlhbGl6 YXRpb24gdGltZSBzaW5jZSB0aGV5IGNhbiBiZSBhIGJpdAo+PiBleHBlbnNpdmUsIHRoZSB1c3Vh bCBwYXR0ZXJuIHdvdWxkIGJlIHRvIGdvIHRocm91Z2ggeW91ciBPUFAgdGFibGUgYW5kCj4+IGRp c2FibGUgc3RhdGVzIHdoZXJlIHlvdSBjYW4ndCBzdXBwb3J0IHRoZSB2b2x0YWdlIGJ1dCB5b3Ug KmNvdWxkKiBhbHNvCj4+IGZsYWcgc3RhdGVzIHdoZXJlIHlvdSBqdXN0IGRvbid0IHNldCB0aGUg dm9sdGFnZS4gIFRoYXQgc2VlbXMgZXNwZWNpYWxseQo+PiByZWFzb25hYmxlIGlmIG5vIHZvbHRh Z2VzIGluIHRoZSByYW5nZSB0aGUgZGV2aWNlIHN1cHBvcnRzIGNhbiBiZSBzZXQuCj4+Cj4+IEkg ZG8gbm90ZSB0aGF0IHRoZSBjdXJyZW50IGNvZGUgcmVxdWlyZXMgZXhhY3RseSBzcGVjaWZpZWQg dm9sdGFnZXMgd2l0aAo+PiBubyB2YXJpYXRpb24gd2hpY2ggZG9lc24ndCBtYXRjaCB0aGUgYmVo YXZpb3VyIHlvdSBzYXkgeW91J3JlIE9LIHdpdGgKPj4gaGVyZSwgd2hhdCB5b3UncmUgZGVzY3Jp YmluZyBzb3VuZHMgbGlrZSB0aGUgZHJpdmVyIHNob3VsZCBiZSBzcGVjaWZ5aW5nCj4+IGEgdm9s dGFnZSByYW5nZSBmcm9tIHRoZSBoYXJkd2FyZSBzcGVjaWZpZWQgbWF4aW11bSBkb3duIHRvIHdo YXRldmVyIHRoZQo+PiBtaW5pbXVtIHRoZSBPUFAgc3VwcG9ydHMgcmF0aGVyIHRoYW4gZXhhY3Rs eSB0aGUgT1BQIHZvbHRhZ2UuICBBcyB0aGluZ3MKPj4gYXJlIHlvdSBtaWdodCBhbHNvIHJ1biBp bnRvIHZvbHRhZ2VzIHRoYXQgY2FuJ3QgYmUgaGl0IGV4YWN0bHkgKGVnLCBpbgo+PiB0aGUgRXh5 bm9zIDU0MzMgY2FzZSBpbiBtYWlubGluZSBhIHJlZ3VsYXRvciB0aGF0IG9ubHkgb2ZmZXJzIHN0 ZXBzIG9mCj4+IDJtViB3aWxsIGVycm9yIG91dCB0cnlpbmcgdG8gc2V0IHNldmVyYWwgb2YgdGhl IE9QUHMpLgoKSW4gY2FzZSB3ZSBuZWVkIGEgZml4ZWQgdm9sdGFnZSwgc2ltcGx5IGFkZCBhIG5l dyBmaXhlZC1yZWd1bGF0b3IgaW4gdGhlIGJvYXJkL3NvYyBEVCwKdXNlIHRoaXMgcmVndWxhdG9y IGZvciBwYW5mcm9zdCBhbmQgdXNlIHRoZSBzYW1lIGZpeGVkIHZvbHRhZ2UgaW4gdGhlIE9QUCB0 YWJsZS4KCkl0IHJlbGllcyBvbiBhIGNvcnJlY3QgRFQsIGJ1dCBpc24ndCBpcyB0aGUgZ29hbCBv ZiBtYWlubGluZSBsaW51eCA/CgpOZWlsCgo+IAo+IFBlcmhhcHMgdGhlcmUncyBhIGJldHRlciB3 YXkgb2YgZG9pbmcgZGV2ZnJlcT8gUGFuZnJvc3QgaXRzZWxmIGRvZXNuJ3QKPiByZWFsbHkgY2Fy ZSBtdXN0IGFib3V0IHRoaXMgLSB3ZSBqdXN0IG5lZWQgdG8gYmUgYWJsZSB0byBzY2FsaW5nIHVw L2Rvd24KPiB0aGUgb3BlcmF0aW5nIHBvaW50IGRlcGVuZGluZyBvbiBsb2FkLgo+IAo+IE9uIG1h bnkgcGxhdGZvcm1zIHRvIHNldCB0aGUgZnJlcXVlbmN5IGl0J3MgbmVjZXNzYXJ5IHRvIGRvIHRo ZSBkYW5jZSB0bwo+IHNldCBhbiBhcHByb3ByaWF0ZSB2b2x0YWdlIGJlZm9yZS9hZnRlcndhcmRz LCBidXQgb24gdGhlIEhpa2V5OTYwCj4gYmVjYXVzZSB0aGlzIGlzIGhhbmRsZWQgdmlhIGEgbWFp bGJveCB3ZSBkb24ndCBhY3R1YWxseSBoYXZlIGEgcmVndWxhdG9yCj4gdG8gc2V0IHRoZSB2b2x0 YWdlIG9uLiBNeSBjb21taXRbMV0gc3VwcG9ydHMgdGhpcyBieSBzaW1wbHkgbm90IGxpc3RpbmcK PiB0aGUgcmVndWxhdG9yIGluIHRoZSBEVCBhbmQgYXNzdW1pbmcgdGhhdCBub3RoaW5nIGlzIG5l ZWRlZCB3aGVuCj4gc3dpdGNoaW5nIGZyZXF1ZW5jeS4gSSdtIGhhcHB5IGZvciBzb21lIG90aGVy IHdheSBvZiBoYW5kbGluZyB0aGlzIGlmCj4gdGhlcmUncyBhIGJldHRlciBtZXRob2QuCj4gCj4g QXQgdGhlIG1vbWVudCB5b3VyIGNoYW5nZSBmcm9tIGRldm1fcmVndWxhdG9yX2dldF9vcHRpb25h bCgpIHRvCj4gZGV2bV9yZWd1bGF0b3JfZ2V0KCkgaXMgYSByZWdyZXNzaW9uIG9uIHRoaXMgcGxh dGZvcm0gYmVjYXVzZSBpdCBtZWFucwo+IHRoZXJlIGlzIG5vdyBhIGR1bW15IHJlZ3VsYXRvciB3 aGljaCB3aWxsIGFsd2F5cyBmYWlsIHRoZQo+IHJlZ3VsYXRvcl9zZXRfdm9sdGFnZSgpIGNhbGxz IHByZXZlbnRpbmcgZnJlcXVlbmN5IGNoYW5nZXMuIEFuZCBJIGNhbid0Cj4gc2VlIGFueXRoaW5n IEkgY2FuIGRvIGluIHRoZSBEVCB0byBmaXggdGhhdC4KPiAKPiBTdGV2ZQo+IAo+IFsxXSBlMjFk ZDI5MDg4MWIgZHJtL3BhbmZyb3N0OiBFbmFibGUgZGV2ZnJlcSB0byB3b3JrIHdpdGhvdXQgcmVn dWxhdG9yCj4gKHBsdXMgYnVnIGZpeCBpbiA1MjI4MjE2M2RmYTYpCj4gX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBkcmktZGV2ZWwgbWFpbGluZyBsaXN0 Cj4gZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwo+IGh0dHBzOi8vbGlzdHMuZnJlZWRl c2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCj4gCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5v cmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWw=