From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH 1/3] drm/tegra: vic: Implement explicit reset support Date: Thu, 29 Nov 2018 13:40:32 +0000 Message-ID: <67b69475-7bfe-afaf-8e45-2a3aef01c05e@nvidia.com> References: <20181123120639.16706-1-thierry.reding@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by gabe.freedesktop.org (Postfix) with ESMTPS id 834776E2D8 for ; Thu, 29 Nov 2018 13:40:37 +0000 (UTC) In-Reply-To: <20181123120639.16706-1-thierry.reding@gmail.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: linux-tegra@vger.kernel.org, dri-devel@lists.freedesktop.org, Mikko Perttunen List-Id: dri-devel@lists.freedesktop.org Ck9uIDIzLzExLzIwMTggMTI6MDYsIFRoaWVycnkgUmVkaW5nIHdyb3RlOgo+IEZyb206IFRoaWVy cnkgUmVkaW5nIDx0cmVkaW5nQG52aWRpYS5jb20+Cj4gCj4gVGVncmEgc3VwcG9ydHMgZ2VuZXJp YyBQTSBkb21haW5zIG9uIDY0LWJpdCBBUk0sIGFuZCBpZiB0aGF0IGlzIGVuYWJsZWQsCj4gdGhl IHBvd2VyIGRvbWFpbiBjb2RlIHdpbGwgbWFrZSBzdXJlIHRoYXQgcmVzZXRzIGFyZSBhc3NlcnRl ZCBhbmQKPiBkZWFzc2VydGVkIGF0IGFwcHJvcHJpYXRlIHBvaW50cyBpbiB0aW1lLgo+IAo+IElm IGdlbmVyaWMgUE0gZG9tYWlucyBhcmUgbm90IGltcGxlbWVudGVkLCBzdWNoIGFzIG9uIDMyLWJp dCBUZWdyYSwgdGhlCj4gcmVzZXRzIG5lZWQgdG8gYmUgYXNzZXJ0ZWQgYW5kIGRlYXNzZXJ0ZWQg ZXhwbGljaXRseSBieSB0aGUgZHJpdmVyLgo+IAo+IFNpZ25lZC1vZmYtYnk6IFRoaWVycnkgUmVk aW5nIDx0cmVkaW5nQG52aWRpYS5jb20+Cj4gLS0tCj4gIGRyaXZlcnMvZ3B1L2RybS90ZWdyYS92 aWMuYyB8IDM1ICsrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKystCj4gIDEgZmlsZSBj aGFuZ2VkLCAzNCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBh L2RyaXZlcnMvZ3B1L2RybS90ZWdyYS92aWMuYyBiL2RyaXZlcnMvZ3B1L2RybS90ZWdyYS92aWMu Ywo+IGluZGV4IDlmYTc3NDA1ZGIwMS4uMjNmNTMwZGI0NWFkIDEwMDY0NAo+IC0tLSBhL2RyaXZl cnMvZ3B1L2RybS90ZWdyYS92aWMuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS90ZWdyYS92aWMu Ywo+IEBAIC0zOCw2ICszOCw3IEBAIHN0cnVjdCB2aWMgewo+ICAJc3RydWN0IGlvbW11X2RvbWFp biAqZG9tYWluOwo+ICAJc3RydWN0IGRldmljZSAqZGV2Owo+ICAJc3RydWN0IGNsayAqY2xrOwo+ ICsJc3RydWN0IHJlc2V0X2NvbnRyb2wgKnJzdDsKPiAgCj4gIAkvKiBQbGF0Zm9ybSBjb25maWd1 cmF0aW9uICovCj4gIAljb25zdCBzdHJ1Y3QgdmljX2NvbmZpZyAqY29uZmlnOwo+IEBAIC01Niwx MyArNTcsMzcgQEAgc3RhdGljIHZvaWQgdmljX3dyaXRlbChzdHJ1Y3QgdmljICp2aWMsIHUzMiB2 YWx1ZSwgdW5zaWduZWQgaW50IG9mZnNldCkKPiAgc3RhdGljIGludCB2aWNfcnVudGltZV9yZXN1 bWUoc3RydWN0IGRldmljZSAqZGV2KQo+ICB7Cj4gIAlzdHJ1Y3QgdmljICp2aWMgPSBkZXZfZ2V0 X2RydmRhdGEoZGV2KTsKPiArCWludCBlcnI7Cj4gKwo+ICsJZXJyID0gY2xrX3ByZXBhcmVfZW5h YmxlKHZpYy0+Y2xrKTsKPiArCWlmIChlcnIgPCAwKQo+ICsJCXJldHVybiBlcnI7Cj4gKwo+ICsJ dXNsZWVwX3JhbmdlKDIwMDAsIDQwMDApOwoKVGhlIFRlZ3JhIGdlbnBkIGNvZGUgaGFzIGEgdXNs ZWVwX3JhbmdlKDEwLCAyMCksIGlzIHRoYXQgbm90IHN1ZmZpY2llbnQKaGVyZT8gSWYgaXQgaXMs IGl0IHdvdWxkIGJlIGdvb2QgdG8gYmUgY29uc2lzdGVudC4KCj4gKwo+ICsJZXJyID0gcmVzZXRf Y29udHJvbF9kZWFzc2VydCh2aWMtPnJzdCk7Cj4gKwlpZiAoZXJyIDwgMCkKPiArCQlnb3RvIGRp c2FibGU7Cj4gKwo+ICsJdXNsZWVwX3JhbmdlKDIwMDAsIDQwMDApOwo+ICsKPiArCXJldHVybiAw Owo+ICAKPiAtCXJldHVybiBjbGtfcHJlcGFyZV9lbmFibGUodmljLT5jbGspOwo+ICtkaXNhYmxl Ogo+ICsJY2xrX2Rpc2FibGVfdW5wcmVwYXJlKHZpYy0+Y2xrKTsKPiArCXJldHVybiBlcnI7Cj4g IH0KPiAgCj4gIHN0YXRpYyBpbnQgdmljX3J1bnRpbWVfc3VzcGVuZChzdHJ1Y3QgZGV2aWNlICpk ZXYpCj4gIHsKPiAgCXN0cnVjdCB2aWMgKnZpYyA9IGRldl9nZXRfZHJ2ZGF0YShkZXYpOwo+ICsJ aW50IGVycjsKPiArCj4gKwllcnIgPSByZXNldF9jb250cm9sX2Fzc2VydCh2aWMtPnJzdCk7Cj4g KwlpZiAoZXJyIDwgMCkKPiArCQlyZXR1cm4gZXJyOwo+ICsKPiArCXVzbGVlcF9yYW5nZSgyMDAw LCA0MDAwKTsKPiAgCj4gIAljbGtfZGlzYWJsZV91bnByZXBhcmUodmljLT5jbGspOwo+ICAKPiBA QCAtMzI0LDYgKzM0OSwxNCBAQCBzdGF0aWMgaW50IHZpY19wcm9iZShzdHJ1Y3QgcGxhdGZvcm1f ZGV2aWNlICpwZGV2KQo+ICAJCXJldHVybiBQVFJfRVJSKHZpYy0+Y2xrKTsKPiAgCX0KPiAgCj4g KwlpZiAoIWRldi0+cG1fZG9tYWluKSB7Cj4gKwkJdmljLT5yc3QgPSBkZXZtX3Jlc2V0X2NvbnRy b2xfZ2V0KGRldiwgInZpYyIpOwo+ICsJCWlmIChJU19FUlIodmljLT5yc3QpKSB7Cj4gKwkJCWRl dl9lcnIoJnBkZXYtPmRldiwgImZhaWxlZCB0byBnZXQgcmVzZXRcbiIpOwo+ICsJCQlyZXR1cm4g UFRSX0VSUih2aWMtPnJzdCk7Cj4gKwkJfQo+ICsJfQo+ICsKPiAgCXZpYy0+ZmFsY29uLmRldiA9 IGRldjsKPiAgCXZpYy0+ZmFsY29uLnJlZ3MgPSB2aWMtPnJlZ3M7Cj4gIAl2aWMtPmZhbGNvbi5v cHMgPSAmdmljX2ZhbGNvbl9vcHM7Cj4gCgpDaGVlcnMKSm9uCgotLSAKbnZwdWJsaWMKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==