From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [PATCH] dma-buf/reservation: shouldn't kfree staged when slot available Date: Mon, 5 Mar 2018 12:51:07 +0100 Message-ID: <67d0d2de-ae45-4e46-33fc-48d9c0a53ea1@gmail.com> References: <1519800242-2442-1-git-send-email-Monk.Liu@amd.com> <210b7a03-f309-8ab6-0f23-17377660e664@amd.com> <3baa1046-79b1-7c6d-644f-9aa921733ad2@amd.com> Reply-To: christian.koenig@amd.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wr0-x22b.google.com (mail-wr0-x22b.google.com [IPv6:2a00:1450:400c:c0c::22b]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9ED5689C5E for ; Mon, 5 Mar 2018 11:51:10 +0000 (UTC) Received: by mail-wr0-x22b.google.com with SMTP id o76so16932528wrb.7 for ; Mon, 05 Mar 2018 03:51:10 -0800 (PST) In-Reply-To: Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: "Liu, Monk" , "Koenig, Christian" , "dri-devel@lists.freedesktop.org" , "linux-kernel@vger.kernel.org" List-Id: dri-devel@lists.freedesktop.org V2VsbCwgbm90IHJlYWxseS4KCkl0J3MganVzdCB0aGF0IHJlc2VydmF0aW9uX29iamVjdF9yZXNl cnZlX3NoYXJlZCgpIGlzIGNhbGxlZCBtdWx0aXBsZSAKdGltZXMgd2l0aG91dCBhY3R1YWxseSBh ZGRpbmcgZmVuY2VzLgoKVGhhdCBpcyBhIHBlcmZlY3RseSBub3JtYWwgdXNlIGNhc2UsIHNvIG5v dGhpbmcgc3BlY2lhbCBoZXJlLgoKQ2hyaXN0aWFuLgoKQW0gMDUuMDMuMjAxOCB1bSAxMjo0NyBz Y2hyaWViIExpdSwgTW9uazoKPiBDYW4geW91IGdpdmUgbW9yZSBkZXRhaWxzID8gdGhhbmtzCj4K PiAvTW9uawo+Cj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiBGcm9tOiBLb2VuaWcsIENo cmlzdGlhbgo+IFNlbnQ6IDIwMTjlubQz5pyINeaXpSAxOTozOQo+IFRvOiBMaXUsIE1vbmsgPE1v bmsuTGl1QGFtZC5jb20+OyBkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnOyBsaW51eC1r ZXJuZWxAdmdlci5rZXJuZWwub3JnCj4gU3ViamVjdDogUmU6IFtQQVRDSF0gZG1hLWJ1Zi9yZXNl cnZhdGlvbjogc2hvdWxkbid0IGtmcmVlIHN0YWdlZCB3aGVuIHNsb3QgYXZhaWxhYmxlCj4KPiBB bSAwNS4wMy4yMDE4IHVtIDEyOjM3IHNjaHJpZWIgTGl1LCBNb25rOgo+PiBCdXQgdGhlIHRoaW5n IGNvbmZ1c2UgbWUgaXMgYWNjb3JkaW5nIHRvIHRoZSBkZXNpZ24sIGlmIGRyaXZlciBrZWVwCj4+ IGNhbGxpbmcgcmVzZXJ2ZV9zaGFyZWQoKSBwcmlvciB0byBhZGRfZmVuY2UoKSwgYW5kIHdpdGgg bG9jayBoZWxkIG9mIGNhdXNlLCBUaGF0IEJVRygpIHNob3VsZG4ndCBoaXQsIHNvIHRoZXJlIGFy ZSB0d28gdGhpbmdzIGluIGZhY2UgbG9va3Mgd2VpcmVkIHRvIG1lOgo+PiAxKSBieSBkZXNpZ24g aW4gcmVzZXJ2ZV9zaGFyZWQoKSwgb2JqLT5zdGFnZWQgc2hvdWxkIGJlIGFscmVhZHkgTlVMTCwK Pj4gc28gd2h5IHdlIGtmcmVlIG9uIGl0Cj4gTm8sIHRoYXQgaXMgbm90IGNvcnJlY3QuCj4KPj4g MikgaW4gZmFjdCwgYW1kZ3B1IGNhbiBoaXQgdGhlIGNhc2UgdGhhdCBvYmotPnN0YWdlZCBpcyBu b3QgTlVMTCBpbgo+PiByZXNlcnZlZF9zaGFyZWQoKSwgZG9uJ3Qga25vdyBob3cgaXQgbGVhZCBo ZXJlCj4gV2UgcmVzZXJ2ZWQgYSBmZW5jZSBzbG90IHdpdGhvdXQgdXNpbmcgaXQsIHNvIGl0IGlz IHN0aWxsIHRoZXJlIHdoZW4KPiByZXNlcnZlX3NoYXJlZCgpIGlzIGNhbGxlZC4KPgo+IENocmlz dGlhbi4KPgo+Pgo+PiBBbnkgdGhvdWdodCA/Cj4+Cj4+IC9Nb25rCj4+Cj4+IC0tLS0tT3JpZ2lu YWwgTWVzc2FnZS0tLS0tCj4+IEZyb206IEtvZW5pZywgQ2hyaXN0aWFuCj4+IFNlbnQ6IDIwMTjl ubQz5pyINeaXpSAxOToyOQo+PiBUbzogTGl1LCBNb25rIDxNb25rLkxpdUBhbWQuY29tPjsgZHJp LWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsKPj4gbGludXgta2VybmVsQHZnZXIua2VybmVs Lm9yZwo+PiBTdWJqZWN0OiBSZTogW1BBVENIXSBkbWEtYnVmL3Jlc2VydmF0aW9uOiBzaG91bGRu J3Qga2ZyZWUgc3RhZ2VkIHdoZW4KPj4gc2xvdCBhdmFpbGFibGUKPj4KPj4gQW0gMDUuMDMuMjAx OCB1bSAxMjoyNSBzY2hyaWViIExpdSwgTW9uazoKPj4+IEFuZCBieSB0aGUgd2F5LCBJIGFkZCAi aWYgKHN0YWdlZCE9TlVMTCkgQlVHKCk7IiBwcmlvciB0bwo+Pj4gImtmcmVlKG9iai0+c3RhZ2Vk KSIgaW4gcmVzZXJ2ZV9zaGFyZWQoKSByb3V0aW5lLCBhbmQgdGhpcyBCVUcoKSBpcyBhY3R1YWxs eSBoaXQsIFRoZSBzdGFjayBkdW1wIHNob3dzIGl0IGlzIGhpdCBkdXJpbmcgdGhlIHZtX2JvX3Vw ZGF0ZSgpIGluIGdlbV92YV91cGRhdGUoKS4uLgo+PiBUaGF0IGlzIGV4cGVjdGVkLiBUaGUgc3Rh Z2VkIGhhbmRsaW5nIGp1c3QgbWFrZXMgc3VyZSB0aGF0IHRoZXJlIGlzIHJvb20gYXZhaWxhYmxl LCBpdCBkb2Vzbid0IGd1YXJhbnRlZSB0aGF0IGl0IGlzIGFjdHVhbGx5IHVzZWQuCj4+Cj4+IEUu Zy4gd2UgY2FuIGVuZCB1cCByZXNlcnZpbmcgYSBmZW5jZSBzbG90LCBidXQgdGhlbiBmaW5kIHRo YXQgd2UgYWN0dWFsbHkgZG9uJ3QgbmVlZCBpdC4KPj4KPj4gQ2hyaXN0aWFuLgo+Pgo+Pj4gQmVz aWRlcywgdGhlIHdob2xlIHJlc2VydmF0aW9uIGxvZ2ljIHN0aWxsIGxvb2tzIGEgbGl0dGxlIHdl aXJlZCB0byBtZSAuLi4gZXNwZWNpYWxseSB0aGlzIHN0YWdlZCBwYXJ0IC4uLgo+Pj4KPj4+IFRo YW5rcwo+Pj4KPj4+IC9Nb25rCj4+Pgo+Pj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPj4+ IEZyb206IENocmlzdGlhbiBLw7ZuaWcgW21haWx0bzpja29lbmlnLmxlaWNodHp1bWVya2VuQGdt YWlsLmNvbV0KPj4+IFNlbnQ6IDIwMTjlubQz5pyINeaXpSAxOToyMgo+Pj4gVG86IExpdSwgTW9u ayA8TW9uay5MaXVAYW1kLmNvbT47IEtvZW5pZywgQ2hyaXN0aWFuCj4+PiA8Q2hyaXN0aWFuLktv ZW5pZ0BhbWQuY29tPjsgZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZzsKPj4+IGxpbnV4 LWtlcm5lbEB2Z2VyLmtlcm5lbC5vcmcKPj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGRtYS1idWYv cmVzZXJ2YXRpb246IHNob3VsZG4ndCBrZnJlZSBzdGFnZWQgd2hlbgo+Pj4gc2xvdCBhdmFpbGFi bGUKPj4+Cj4+PiBBbSAwNS4wMy4yMDE4IHVtIDA4OjU1IHNjaHJpZWIgTGl1LCBNb25rOgo+Pj4+ IEhpIENocmlzdGlhbgo+Pj4+Cj4+Pj4gWW91IGFyZSByaWdodCBvbiB0aGF0IHBhcnQgb2Ygb2Jq LXN0YWdlZCBpcyBzZXQgdG8gTlVMTCBpbgo+Pj4+IGFkZF9mZW5jZSwgU28gbXkgZm9sbG93aW5n IHF1ZXN0aW9uIHdpbGwgYmUgd2h5IHdlIGtmcmVlKG9iai0+c3RhZ2VkKSBpbiByZXNlcnZlX3No YXJlZCgpIGlmIHN0YWdlZCBpcyBhbHdheXMgTlVMTCBpbiB0aGF0IHBvaW50ID8KPj4+IEdvb2Qg cXVlc3Rpb24sIEkgaGF2ZW4ndCB3cm90ZSBjb2RlIHRoYXQgc28gSSBjYW4ndCBmdWxseSBhbnN3 ZXIuCj4+Pgo+Pj4gTWF5YmUgQ2hyaXMgb3IgTWFhcnRlbiBrbm93IG1vcmUgYWJvdXQgdGhhdC4K Pj4+Cj4+PiBDaHJpc3RpYW4uCj4+Pgo+Pj4+IFRoYW5rcwo+Pj4+IC9Nb25rCj4+Pj4KPj4+PiAt LS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQo+Pj4+IEZyb206IENocmlzdGlhbiBLw7ZuaWcgW21h aWx0bzpja29lbmlnLmxlaWNodHp1bWVya2VuQGdtYWlsLmNvbV0KPj4+PiBTZW50OiAyMDE45bm0 MuaciDI45pelIDE2OjI3Cj4+Pj4gVG86IExpdSwgTW9uayA8TW9uay5MaXVAYW1kLmNvbT47IGRy aS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmc7Cj4+Pj4gbGludXgta2VybmVsQHZnZXIua2Vy bmVsLm9yZwo+Pj4+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGRtYS1idWYvcmVzZXJ2YXRpb246IHNo b3VsZG4ndCBrZnJlZSBzdGFnZWQKPj4+PiB3aGVuIHNsb3QgYXZhaWxhYmxlCj4+Pj4KPj4+PiBB bSAyOC4wMi4yMDE4IHVtIDA3OjQ0IHNjaHJpZWIgTW9uayBMaXU6Cj4+Pj4+IHVuZGVyIGJlbG93 IHNjZW5hcmlvIHRoZSBvYmotPmZlbmNlIHdvdWxkIHJlZmVyIHRvIGEgd2lsZCBwb2ludGVyOgo+ Pj4+Pgo+Pj4+PiAxLGNhbGwgcmVzZXJ2YXRpb25fb2JqZWN0X3Jlc2VydmVkX3NoYXJlZAo+Pj4+ PiAyLGNhbGwgcmVzZXJ2YXRpb25fb2JqZWN0X2FkZF9zaGFyZWRfZmVuY2UKPj4+Pj4gMyxjYWxs IHJlc2VydmF0aW9uX29iamVjdF9yZXNlcnZlZF9zaGFyZWQKPj4+Pj4gNCxjYWxsIHJlc2VydmF0 aW9uX29iamVjdF9hZGRfc2hhcmVkX2ZlbmNlCj4+Pj4+Cj4+Pj4+IGluIHN0ZXAgMSwgc3RhZ2Vk IGlzIGFsbG9jYXRlZCwKPj4+Pj4KPj4+Pj4gaW4gc3RlcCAyLCBjb2RlIHBhdGggd2lsbCBnbwo+ Pj4+PiByZXNlcnZhdGlvbl9vYmplY3RfYWRkX3NoYXJlZF9yZXBsYWNlKCkKPj4+Pj4gYW5kIG9i ai0+ZmVuY2Ugd291bGQgYmUgYXNzaWduZWQgYXMgc3RhZ2VkICh0aHJvdWdoCj4+Pj4+IFJDVV9J TklUX1BPSU5URVIpCj4+Pj4+Cj4+Pj4+IGluIHN0ZXAgMywgb2JqLT5zdGFnZWQgd2lsbCBiZSBm cmVlZChieSBzaW1wbGUga2ZyZWUpLCB3aGljaCBtYWtlCj4+Pj4+IG9iai0+ZmVuY2UgcG9pbnQg dG8gYSB3aWxkIHBvaW50ZXIuLi4KPj4+PiBXZWxsIHRoYXQgZXhwbGFuYXRpb24gaXMgc3RpbGwg bm9uc2Vuc2UuIFNlZQo+Pj4+IHJlc2VydmF0aW9uX29iamVjdF9hZGRfc2hhcmVkX2ZlbmNlOgo+ Pj4+PiAgICAgwqDCoMKgwqDCoMKgwqAgb2JqLT5zdGFnZWQgPSBOVUxMOwo+Pj4+IEFtb25nIHRo ZSBmaXJzdCB0aGluZ3MgcmVzZXJ2YXRpb25fb2JqZWN0X2FkZF9zaGFyZWRfZmVuY2UoKSBkb2Vz IGlzCj4+Pj4gaXQgc2V0cyBvYmotPnN0YWdlZCB0byBOVUxMLgo+Pj4+Cj4+Pj4gU28gc3RlcCAz IHdpbGwgbm90IGZyZWUgYW55dGhpbmcgYW5kIHdlIG5ldmVyIGhhdmUgYSB3aWxkIHBvaW50ZXIu Cj4+Pj4KPj4+PiBSZWdhcmRzLAo+Pj4+IENocmlzdGlhbi4KPj4+Pgo+Pj4+PiBpbiBzdGVwIDQs IGNvZGUgcGF0aCB3aWxsIGdvCj4+Pj4+IHJlc2VydmF0aW9uX29iamVjdF9hZGRfc2hhcmVkX2lu cGxhY2UoKQo+Pj4+PiBhbmQgaW5zaWRlIGl0IHRoZSBAZm9iaiAod2hpY2ggZXF1YWxzIHRvIEBv YmotPnN0YWdlZCwgc2V0IGJ5IGFib3ZlCj4+Pj4+IHN0ZXBzKSBpcyBhbHJlYWR5IGEgd2lsZCBw b2ludGVyCj4+Pj4+Cj4+Pj4+IHNob3VsZCByZW1vdiB0aGUga2ZyZWUgb24gc3RhZ2VkIGluCj4+ Pj4+IHJlc2VydmF0aW9uX29iamVjdF9yZXNlcnZlX3NoYXJlZCgpCj4+Pj4+Cj4+Pj4+IENoYW5n ZS1JZDogSWY3YzAxZjFiNGJlM2QzZDhhODFlZmE5MDIxNjg0MWY3OWFiMWZjMWMKPj4+Pj4gU2ln bmVkLW9mZi1ieTogTW9uayBMaXUgPE1vbmsuTGl1QGFtZC5jb20+Cj4+Pj4+IC0tLQo+Pj4+PiAg ICAgICBkcml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRpb24uYyB8IDcgKystLS0tLQo+Pj4+PiAgICAg ICAxIGZpbGUgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCA1IGRlbGV0aW9ucygtKQo+Pj4+Pgo+ Pj4+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9kbWEtYnVmL3Jlc2VydmF0aW9uLmMKPj4+Pj4gYi9k cml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRpb24uYyBpbmRleCAzNzVkZTQxLi5iNDczY2NjIDEwMDY0 NAo+Pj4+PiAtLS0gYS9kcml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRpb24uYwo+Pj4+PiArKysgYi9k cml2ZXJzL2RtYS1idWYvcmVzZXJ2YXRpb24uYwo+Pj4+PiBAQCAtNzQsMTIgKzc0LDkgQEAgaW50 IHJlc2VydmF0aW9uX29iamVjdF9yZXNlcnZlX3NoYXJlZChzdHJ1Y3QgcmVzZXJ2YXRpb25fb2Jq ZWN0ICpvYmopCj4+Pj4+ICAgICAgIAlvbGQgPSByZXNlcnZhdGlvbl9vYmplY3RfZ2V0X2xpc3Qo b2JqKTsKPj4+Pj4gICAgICAgCj4+Pj4+ICAgICAgIAlpZiAob2xkICYmIG9sZC0+c2hhcmVkX21h eCkgewo+Pj4+PiAtCQlpZiAob2xkLT5zaGFyZWRfY291bnQgPCBvbGQtPnNoYXJlZF9tYXgpIHsK Pj4+Pj4gLQkJCS8qIHBlcmZvcm0gYW4gaW4tcGxhY2UgdXBkYXRlICovCj4+Pj4+IC0JCQlrZnJl ZShvYmotPnN0YWdlZCk7Cj4+Pj4+IC0JCQlvYmotPnN0YWdlZCA9IE5VTEw7Cj4+Pj4+ICsJCWlm IChvbGQtPnNoYXJlZF9jb3VudCA8IG9sZC0+c2hhcmVkX21heCkKPj4+Pj4gICAgICAgCQkJcmV0 dXJuIDA7Cj4+Pj4+IC0JCX0gZWxzZQo+Pj4+PiArCQllbHNlCj4+Pj4+ICAgICAgIAkJCW1heCA9 IG9sZC0+c2hhcmVkX21heCAqIDI7Cj4+Pj4+ICAgICAgIAl9IGVsc2UKPj4+Pj4gICAgICAgCQlt YXggPSA0Owo+Pj4+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCj4+Pj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+Pj4+IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPj4+PiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2RyaS1kZXZlbAo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fCj4gZHJpLWRldmVsIG1haWxpbmcgbGlzdAo+IGRyaS1kZXZlbEBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKPiBodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3Rp bmZvL2RyaS1kZXZlbAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Au b3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRl dmVsCg==