From: Jani Nikula <jani.nikula@intel.com>
To: dri-devel@lists.freedesktop.org
Cc: tzimmermann@suse.de, intel-gfx@lists.freedesktop.org,
intel-xe@lists.freedesktop.org, jani.nikula@intel.com
Subject: [PATCH v3 21/25] drm/vblank: pass vblank to __{enable, disable}_vblank()
Date: Fri, 5 Dec 2025 13:27:37 +0200 [thread overview]
Message-ID: <6984b7dd2fdfe308c3b51fc6bbcd0bbdc540a7a4.1764933891.git.jani.nikula@intel.com> (raw)
In-Reply-To: <cover.1764933891.git.jani.nikula@intel.com>
Use the vblank pointer instead of a dev, pipe pair to simplify code.
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/drm_vblank.c | 16 ++++++++++------
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_vblank.c b/drivers/gpu/drm/drm_vblank.c
index 04c75cdbb916..52fa4ca361e3 100644
--- a/drivers/gpu/drm/drm_vblank.c
+++ b/drivers/gpu/drm/drm_vblank.c
@@ -443,10 +443,12 @@ u64 drm_crtc_accurate_vblank_count(struct drm_crtc *crtc)
}
EXPORT_SYMBOL(drm_crtc_accurate_vblank_count);
-static void __disable_vblank(struct drm_device *dev, unsigned int pipe)
+static void __disable_vblank(struct drm_vblank_crtc *vblank)
{
+ struct drm_device *dev = vblank->dev;
+
if (drm_core_check_feature(dev, DRIVER_MODESET)) {
- struct drm_crtc *crtc = drm_crtc_from_index(dev, pipe);
+ struct drm_crtc *crtc = drm_crtc_from_vblank(vblank);
if (drm_WARN_ON(dev, !crtc))
return;
@@ -491,7 +493,7 @@ void drm_vblank_disable_and_save(struct drm_device *dev, unsigned int pipe)
* between drm_crtc_vblank_on() and drm_crtc_vblank_off().
*/
drm_vblank_crtc_update_count(vblank, false);
- __disable_vblank(dev, pipe);
+ __disable_vblank(vblank);
vblank->enabled = false;
out:
@@ -1155,10 +1157,12 @@ void drm_crtc_send_vblank_event(struct drm_crtc *crtc,
}
EXPORT_SYMBOL(drm_crtc_send_vblank_event);
-static int __enable_vblank(struct drm_device *dev, unsigned int pipe)
+static int __enable_vblank(struct drm_vblank_crtc *vblank)
{
+ struct drm_device *dev = vblank->dev;
+
if (drm_core_check_feature(dev, DRIVER_MODESET)) {
- struct drm_crtc *crtc = drm_crtc_from_index(dev, pipe);
+ struct drm_crtc *crtc = drm_crtc_from_vblank(vblank);
if (drm_WARN_ON(dev, !crtc))
return 0;
@@ -1188,7 +1192,7 @@ static int drm_vblank_enable(struct drm_vblank_crtc *vblank)
* timestamps. Filtercode in drm_handle_vblank() will
* prevent double-accounting of same vblank interval.
*/
- ret = __enable_vblank(dev, pipe);
+ ret = __enable_vblank(vblank);
drm_dbg_core(dev, "enabling vblank on crtc %u, ret: %d\n",
pipe, ret);
if (ret) {
--
2.47.3
next prev parent reply other threads:[~2025-12-05 11:29 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 11:27 [PATCH v3 00/25] drm/vblank: refactoring and cleanups Jani Nikula
2025-12-05 11:27 ` [PATCH v3 01/25] drm/vblank: Unexport drm_wait_one_vblank() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 02/25] drm/vblank: remove drm_wait_one_vblank() completely Jani Nikula
2025-12-05 11:27 ` [PATCH v3 03/25] drm/vblank: remove superfluous pipe check Jani Nikula
2025-12-05 11:27 ` [PATCH v3 04/25] drm/vblank: add return value to drm_crtc_wait_one_vblank() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 05/25] drm/vblank: limit vblank variable scope to atomic Jani Nikula
2025-12-05 11:27 ` [PATCH v3 06/25] drm/vblank: use the drm_vblank_crtc() and drm_crtc_vblank_crtc() helpers more Jani Nikula
2025-12-05 11:27 ` [PATCH v3 07/25] drm/vblank: prefer drm_crtc_vblank_crtc() over drm_vblank_crtc() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 08/25] drm/vblank: pass vlank to drm_vblank_get()/_put()/_count() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 09/25] drm/vblank: pass vblank to drm_update_vblank_count() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 10/25] drm/vblank: pass vblank to drm_handle_vblank_events() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 11/25] drm/vblank: use the vblank based interfaces more Jani Nikula
2025-12-05 11:27 ` [PATCH v3 12/25] drm/vblank: pass vblank to drm_queue_vblank_event() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 13/25] drm/vblank: pass vblank to drm_wait_vblank_reply() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 14/25] drm/vblank: pass vblank to drm_vblank_count_and_time() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 15/25] drm/vblank: pass vblank to drm_reset_vblank_timestamp() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 16/25] drm/vblank: pass vblank to store_vblank() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 17/25] drm/vblank: pass vblank to drm_vblank_enable() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 18/25] drm/vblank: merge drm_vblank_restore() into drm_crtc_vblank_restore() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 19/25] drm/vblank: add drm_crtc_from_vblank() helper Jani Nikula
2025-12-05 11:27 ` [PATCH v3 20/25] drm/vblank: pass vblank to __get_vblank_counter() and drm_max_vblank_count() Jani Nikula
2025-12-05 11:27 ` Jani Nikula [this message]
2025-12-05 11:27 ` [PATCH v3 22/25] drm/vblank: pass vblank to drm_get_last_vbltimestamp() Jani Nikula
2025-12-05 11:27 ` [PATCH v3 23/25] drm/vblank: pass vblank to drm_vblank_disable_and_save(), make static Jani Nikula
2025-12-05 11:27 ` [PATCH v3 24/25] drm/vblank: reduce pipe checks Jani Nikula
2025-12-05 11:27 ` [PATCH v3 25/25] drm/vblank: clean up debug logging Jani Nikula
2025-12-08 15:18 ` [PATCH v3 00/25] drm/vblank: refactoring and cleanups Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6984b7dd2fdfe308c3b51fc6bbcd0bbdc540a7a4.1764933891.git.jani.nikula@intel.com \
--to=jani.nikula@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).