From: Philipp Stanner <phasta@mailbox.org>
To: Markus Elfring <Markus.Elfring@web.de>,
Philipp Stanner <phasta@kernel.org>,
Liao Yuanhong <liaoyuanhong@vivo.com>,
dri-devel@lists.freedesktop.org
Cc: LKML <linux-kernel@vger.kernel.org>,
"Christian König" <ckoenig.leichtzumerken@gmail.com>,
"Danilo Krummrich" <dakr@kernel.org>,
"David Airlie" <airlied@gmail.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Maíra Canal" <mcanal@igalia.com>,
"Matthew Brost" <matthew.brost@intel.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Simona Vetter" <simona@ffwll.ch>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"Tvrtko Ursulin" <tvrtko.ursulin@igalia.com>
Subject: Re: drm/sched/tests: Remove redundant header files
Date: Thu, 28 Aug 2025 10:15:44 +0200 [thread overview]
Message-ID: <698ebb7319fbdb405dd7f9ddf96d82a7fdd5e023.camel@mailbox.org> (raw)
In-Reply-To: <697bb91b-24ea-4830-8794-373f709aa37e@web.de>
On Mon, 2025-08-25 at 12:48 +0200, Markus Elfring wrote:
> > > > The header file <linux/atomic.h> is already included on line 8. Remove the
> > > > redundant include.
> > >
> > > You would like to omit a duplicate #include directive, don't you?
>
> The change intention is probably clear.
>
>
> > > Will a corresponding refinement become helpful for the summary phrase
> > > and change description?
> >
> > I don't understand what you mean. Can you elaborate?
> >
> > Both patch content and description are completely fine as far as I'm concerned.
>
> How do you think about to distinguish better between the deletion of header files
> and an adjustment for a repeated preprocessor directive?
The patch is very trivial and the commit message is perfectly fine.
Applied it to drm-misc-next
Thx
P.
>
> Regards,
> Markus
prev parent reply other threads:[~2025-08-28 8:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-19 14:26 [PATCH] drm/sched/tests: Remove redundant header files Liao Yuanhong
2025-08-19 14:28 ` Tvrtko Ursulin
2025-08-19 16:15 ` Markus Elfring
2025-08-25 10:25 ` Philipp Stanner
2025-08-25 10:48 ` Markus Elfring
2025-08-28 8:15 ` Philipp Stanner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=698ebb7319fbdb405dd7f9ddf96d82a7fdd5e023.camel@mailbox.org \
--to=phasta@mailbox.org \
--cc=Markus.Elfring@web.de \
--cc=airlied@gmail.com \
--cc=ckoenig.leichtzumerken@gmail.com \
--cc=dakr@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=liaoyuanhong@vivo.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=matthew.brost@intel.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=phasta@kernel.org \
--cc=simona@ffwll.ch \
--cc=tvrtko.ursulin@igalia.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).