From mboxrd@z Thu Jan  1 00:00:00 1970
From: Chris Wilson <chris@chris-wilson.co.uk>
Subject: Re: [PATCH linux-next] i915: intel_set_mode: Reduce stack allocation from 500 bytes to 2 pointers
Date: Fri, 07 Dec 2012 11:49:54 +0000
Message-ID: <6c3329$7hpdt5@orsmga002.jf.intel.com>
References: <1354815755-83271-1-git-send-email-tim.gardner@canonical.com> <87zk1qm6cd.fsf@intel.com>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <87zk1qm6cd.fsf@intel.com>
Sender: linux-kernel-owner@vger.kernel.org
To: Jani Nikula <jani.nikula@linux.intel.com>, linux-kernel@vger.kernel.org
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>, Tim Gardner <tim.gardner@canonical.com>, dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Fri, 07 Dec 2012 13:47:46 +0200, Jani Nikula <jani.nikula@linux.intel.com> wrote:
> 
> On Thu, 06 Dec 2012, Tim Gardner <tim.gardner@canonical.com> wrote:
> > +	if (!saved_mode) {
> > +		pr_err("i915: Could not allocate saved display mode.\n");
> 
> Please use DRM_ERROR().

Truthfully neither, but join the growing petition to get real errorcodes
back to userspace!
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre