From: Zack Rusin <zackr@vmware.com>
To: "laurent.pinchart@ideasonboard.com" <laurent.pinchart@ideasonboard.com>
Cc: "kherbst@redhat.com" <kherbst@redhat.com>,
"xinliang.liu@linaro.org" <xinliang.liu@linaro.org>,
"lijo.lazar@amd.com" <lijo.lazar@amd.com>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"javierm@redhat.com" <javierm@redhat.com>,
"mairacanal@riseup.net" <mairacanal@riseup.net>,
"thierry.reding@gmail.com" <thierry.reding@gmail.com>,
"jstultz@google.com" <jstultz@google.com>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"flora.cui@amd.com" <flora.cui@amd.com>,
"etom@igel.co.jp" <etom@igel.co.jp>,
"andriy.shevchenko@linux.intel.com"
<andriy.shevchenko@linux.intel.com>,
"guchun.chen@amd.com" <guchun.chen@amd.com>,
"bernard@vivo.com" <bernard@vivo.com>,
"Rodrigo.Siqueira@amd.com" <Rodrigo.Siqueira@amd.com>,
"Jerry.Zuo@amd.com" <Jerry.Zuo@amd.com>,
"jonathanh@nvidia.com" <jonathanh@nvidia.com>,
"kong.kongxinwei@hisilicon.com" <kong.kongxinwei@hisilicon.com>,
"aurabindo.pillai@amd.com" <aurabindo.pillai@amd.com>,
"bskeggs@redhat.com" <bskeggs@redhat.com>,
"airlied@redhat.com" <airlied@redhat.com>,
"tzimmermann@suse.de" <tzimmermann@suse.de>,
"sunpeng.li@amd.com" <sunpeng.li@amd.com>,
"puck.chen@hisilicon.com" <puck.chen@hisilicon.com>,
"quic_abhinavk@quicinc.com" <quic_abhinavk@quicinc.com>,
"alexander.deucher@amd.com" <alexander.deucher@amd.com>,
"Yuliang.Shi@amd.com" <Yuliang.Shi@amd.com>,
"evan.quan@amd.com" <evan.quan@amd.com>,
"sean@poorly.run" <sean@poorly.run>,
"tomba@kernel.org" <tomba@kernel.org>,
"Xinhui.Pan@amd.com" <Xinhui.Pan@amd.com>,
"roman.li@amd.com" <roman.li@amd.com>,
"christian.koenig@amd.com" <christian.koenig@amd.com>,
"dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
"tiantao6@hisilicon.com" <tiantao6@hisilicon.com>,
"nicholas.kazlauskas@amd.com" <nicholas.kazlauskas@amd.com>
Subject: Re: [PATCH v2] drm: Remove drm_mode_config::fb_base
Date: Tue, 18 Oct 2022 16:31:20 +0000 [thread overview]
Message-ID: <6c8ba4444e990046f013bf0bcb72fc8451a1a00c.camel@vmware.com> (raw)
In-Reply-To: <Y07UJ0ogxrGnHE9j@pendragon.ideasonboard.com>
On Tue, 2022-10-18 at 19:28 +0300, Laurent Pinchart wrote:
> > @@ -271,7 +260,8 @@ static int hibmc_load(struct drm_device *dev)
> > if (ret)
> > goto err;
> >
> > - ret = drmm_vram_helper_init(dev, pci_resource_start(pdev, 0), priv-
> > >fb_size);
> > + ret = drmm_vram_helper_init(dev, pci_resource_start(pdev, 0),
> > + pci_resource_len(pdev, 1));
>
> This should be pci_resource_len(pdev, 0). Apart from that,
Eh, yes, of course. Thanks!
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
z
next prev parent reply other threads:[~2022-10-18 16:31 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-18 13:17 [PATCH] drm: Remove drm_mode_config::fb_base Zack Rusin
2022-10-18 14:05 ` Thomas Zimmermann
2022-10-18 15:52 ` Zack Rusin
2022-10-19 7:32 ` Thomas Zimmermann
2022-10-19 11:08 ` andriy.shevchenko
2022-10-19 11:12 ` Thomas Zimmermann
2022-10-21 7:25 ` Patrik Jakobsson
2022-10-18 14:58 ` Christian König
2022-10-18 15:25 ` Laurent Pinchart
2022-10-18 16:11 ` [PATCH v2] " Zack Rusin
2022-10-18 16:28 ` Laurent Pinchart
2022-10-18 16:31 ` Zack Rusin [this message]
2022-10-18 16:49 ` [PATCH v3] " Zack Rusin
2022-10-19 7:40 ` Thomas Zimmermann
2022-10-18 20:20 ` [PATCH v2] " Andy Shevchenko
2022-10-18 20:26 ` Zack Rusin
2022-10-18 20:59 ` Andy Shevchenko
2022-10-19 2:44 ` Zack Rusin
2022-10-18 18:37 ` [PATCH] " kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c8ba4444e990046f013bf0bcb72fc8451a1a00c.camel@vmware.com \
--to=zackr@vmware.com \
--cc=Jerry.Zuo@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=Yuliang.Shi@amd.com \
--cc=airlied@redhat.com \
--cc=alexander.deucher@amd.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=aurabindo.pillai@amd.com \
--cc=bernard@vivo.com \
--cc=bskeggs@redhat.com \
--cc=christian.koenig@amd.com \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=etom@igel.co.jp \
--cc=evan.quan@amd.com \
--cc=flora.cui@amd.com \
--cc=guchun.chen@amd.com \
--cc=javierm@redhat.com \
--cc=jonathanh@nvidia.com \
--cc=jstultz@google.com \
--cc=kherbst@redhat.com \
--cc=kong.kongxinwei@hisilicon.com \
--cc=kraxel@redhat.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=lijo.lazar@amd.com \
--cc=mairacanal@riseup.net \
--cc=nicholas.kazlauskas@amd.com \
--cc=puck.chen@hisilicon.com \
--cc=quic_abhinavk@quicinc.com \
--cc=roman.li@amd.com \
--cc=sean@poorly.run \
--cc=sunpeng.li@amd.com \
--cc=thierry.reding@gmail.com \
--cc=tiantao6@hisilicon.com \
--cc=tomba@kernel.org \
--cc=tzimmermann@suse.de \
--cc=xinliang.liu@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox