From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?Q?Christian_K=c3=b6nig?= Subject: Re: [RFC] drm/amd/amdgpu: get rid of else branch Date: Fri, 28 Apr 2017 10:30:49 +0200 Message-ID: <6ce3044b-9473-94eb-e54c-e8e856f1c88f@amd.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: amd-gfx-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "amd-gfx" To: Nikola Pajkovsky , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Alex Deucher , David Airlie , amd-gfx-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org, =?UTF-8?Q?Christian_K=c3=b6nig?= , dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org List-Id: dri-devel@lists.freedesktop.org QW0gMjcuMDQuMjAxNyB1bSAxODoxNyBzY2hyaWViIE5pa29sYSBQYWprb3Zza3k6Cj4gVGhpcyBp cyBzdXBlciBzaW1wbGUgZWxpbWluYXRpb24gb2YgZWxzZSBicmFuY2ggYW5kIEkgc2hvdWxkCj4g cHJvYmFibHkgZXZlbiB1c2UgdW5saWtlbHkgaW4KPgo+ICAgCWlmIChyaW5nLT5jb3VudF9kdyA8 IGNvdW50X2R3KSB7Cj4KPiBIb3dldmVyLCBhbWRncHVfcmluZ193cml0ZSgpIGhhcyBzaW1pbGFy IGlmIGNvbmRpdGlvbiwgYnV0IGRvZXMgbm90Cj4gcmV0dXJuIGFmdGVyIERSTV9FUlJPUiBhbmQg aXQgbG9va3Mgc3VzcGljaW91cy4gT24gZXJyb3IsIHdlIHN0aWxsCj4gYWRkaW5nIHYgdG8gcmlu ZyBhbmQga2VlcGluZyBjb3VudF9kdy0tIGJlbG93IHplcm8uCj4KPiAJaWYgKHJpbmctPmNvdW50 X2R3IDw9IDApCj4gCQlEUk1fRVJST1IoImFtZGdwdTogd3JpdGluZyBtb3JlIGR3b3JkcyB0byB0 aGUgcmluZyB0aGFuIGV4cGVjdGVkIVxuIik7Cj4gCXJpbmctPnJpbmdbcmluZy0+d3B0cisrXSA9 IHY7Cj4gCXJpbmctPndwdHIgJj0gcmluZy0+cHRyX21hc2s7Cj4gCXJpbmctPmNvdW50X2R3LS07 Cj4KPiBJIGNhbiBvYnZpb3VzbHkgYmUgdG90YWx5IHdyb25nLiBIbW0/CgpUaGF0J3MganVzdCBj aG9vc2luZyB0aGUgbGVzc2VyIGV2aWwuCgpXaGVuIHdlIHdyaXRlIG1vcmUgRFcgdG8gdGhlIHJp bmcgdGhhbiBleHBlY3RlZCBpdCBpcyBwb3NzaWJsZSAoYnV0IG5vdCAKbGlrZWx5KSB0aGF0IHdl IG92ZXJyaWRlIHN0dWZmIG9uIHRoZSByaW5nIGJ1ZmZlciB3aGljaCBpcyBzdGlsbCAKZXhlY3V0 ZWQgYnkgdGhlIGNvbW1hbmQgcHJvY2Vzc29yIGxlYWRpbmcgdG8gYSBwb3NzaWJsZSBDUCBjcmFz aC4KCkJ1dCB3aGVuIHdlIGNvbXBsZXRlbHkgZHJvcCB0aGUgd3JpdGUgdGhlIGNvbW1hbmRzIGlu IHRoZSByaW5nIGJ1ZmZlciAKd2lsbCBjZXJ0YWlubHkgYmUgaW52YWxpZCBhbmQgc28gdGhlIENQ IHdpbGwgY2VydGFpbmx5IGNyYXNoIHNvb25lciBvciAKbGF0ZXIuCgpQbGVhc2UgYWRkIHRoZSB1 bmxpa2VseSgpIGFzIHdlbGwgYW5kIHRoZW4gc2VuZCBvdXQgdGhlIHBhdGNoIHdpdGggYSAKc2ln bmVkLW9mLWJ5IGxpbmUgYW5kIEkgd2lsbCBiZSBoYXBweSB0byBwdXNoIGl0IGludG8gb3VyIHVw c3RyZWFtIGJyYW5jaC4KClJlZ2FyZHMsCkNocmlzdGlhbi4KCj4KPiAtLS0tLS0tLTg8LS0tLS0t LS04PC0tLS0tLS0tODwtLS0tLS0tLTg8LS0tLS0tLS04PC0tLS0tLS0tODwtLS0tLS0tLTg8LS0t LS0tLS04PC0tLS0tLS0tODwKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRn cHUvYW1kZ3B1LmggYi9kcml2ZXJzL2dwdS9kcm0vYW1kL2FtZGdwdS9hbWRncHUuaAo+IGluZGV4 IGMxYjkxMzU0MTczOS4uYzZmNGY4NzRlYTY4IDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2Ry bS9hbWQvYW1kZ3B1L2FtZGdwdS5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2FtZC9hbWRncHUv YW1kZ3B1LmgKPiBAQCAtMTU5NiwyOCArMTU5NiwyOSBAQCBzdGF0aWMgaW5saW5lIHZvaWQgYW1k Z3B1X3Jpbmdfd3JpdGVfbXVsdGlwbGUoc3RydWN0IGFtZGdwdV9yaW5nICpyaW5nLCB2b2lkICpz cgo+ICAgCj4gICAJaWYgKHJpbmctPmNvdW50X2R3IDwgY291bnRfZHcpIHsKPiAgIAkJRFJNX0VS Uk9SKCJhbWRncHU6IHdyaXRpbmcgbW9yZSBkd29yZHMgdG8gdGhlIHJpbmcgdGhhbiBleHBlY3Rl ZCFcbiIpOwo+IC0JfSBlbHNlIHsKPiAtCQlvY2N1cGllZCA9IHJpbmctPndwdHIgJiByaW5nLT5w dHJfbWFzazsKPiAtCQlkc3QgPSAodm9pZCAqKSZyaW5nLT5yaW5nW29jY3VwaWVkXTsKPiAtCQlj aHVuazEgPSByaW5nLT5wdHJfbWFzayArIDEgLSBvY2N1cGllZDsKPiAtCQljaHVuazEgPSAoY2h1 bmsxID49IGNvdW50X2R3KSA/IGNvdW50X2R3OiBjaHVuazE7Cj4gLQkJY2h1bmsyID0gY291bnRf ZHcgLSBjaHVuazE7Cj4gLQkJY2h1bmsxIDw8PSAyOwo+IC0JCWNodW5rMiA8PD0gMjsKPiAtCj4g LQkJaWYgKGNodW5rMSkKPiAtCQkJbWVtY3B5KGRzdCwgc3JjLCBjaHVuazEpOwo+IC0KPiAtCQlp ZiAoY2h1bmsyKSB7Cj4gLQkJCXNyYyArPSBjaHVuazE7Cj4gLQkJCWRzdCA9ICh2b2lkICopcmlu Zy0+cmluZzsKPiAtCQkJbWVtY3B5KGRzdCwgc3JjLCBjaHVuazIpOwo+IC0JCX0KPiAtCj4gLQkJ cmluZy0+d3B0ciArPSBjb3VudF9kdzsKPiAtCQlyaW5nLT53cHRyICY9IHJpbmctPnB0cl9tYXNr Owo+IC0JCXJpbmctPmNvdW50X2R3IC09IGNvdW50X2R3Owo+ICsJCXJldHVybjsKPiAgIAl9Cj4g Kwo+ICsJb2NjdXBpZWQgPSByaW5nLT53cHRyICYgcmluZy0+cHRyX21hc2s7Cj4gKwlkc3QgPSAo dm9pZCAqKSZyaW5nLT5yaW5nW29jY3VwaWVkXTsKPiArCWNodW5rMSA9IHJpbmctPnB0cl9tYXNr ICsgMSAtIG9jY3VwaWVkOwo+ICsJY2h1bmsxID0gKGNodW5rMSA+PSBjb3VudF9kdykgPyBjb3Vu dF9kdzogY2h1bmsxOwo+ICsJY2h1bmsyID0gY291bnRfZHcgLSBjaHVuazE7Cj4gKwljaHVuazEg PDw9IDI7Cj4gKwljaHVuazIgPDw9IDI7Cj4gKwo+ICsJaWYgKGNodW5rMSkKPiArCQltZW1jcHko ZHN0LCBzcmMsIGNodW5rMSk7Cj4gKwo+ICsJaWYgKGNodW5rMikgewo+ICsJCXNyYyArPSBjaHVu azE7Cj4gKwkJZHN0ID0gKHZvaWQgKilyaW5nLT5yaW5nOwo+ICsJCW1lbWNweShkc3QsIHNyYywg Y2h1bmsyKTsKPiArCX0KPiArCj4gKwlyaW5nLT53cHRyICs9IGNvdW50X2R3Owo+ICsJcmluZy0+ d3B0ciAmPSByaW5nLT5wdHJfbWFzazsKPiArCXJpbmctPmNvdW50X2R3IC09IGNvdW50X2R3Owo+ ICAgfQo+ICAgCj4gICBzdGF0aWMgaW5saW5lIHN0cnVjdCBhbWRncHVfc2RtYV9pbnN0YW5jZSAq CgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KYW1kLWdm eCBtYWlsaW5nIGxpc3QKYW1kLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0 cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9hbWQtZ2Z4Cg==