From: Oleksandr Andrushchenko <andr2000@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
Cc: David Airlie <airlied@linux.ie>,
kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org,
xen-devel@lists.xen.org
Subject: Re: [PATCH 2/3] drm/xen-front: fix xen_drm_front_shbuf_alloc() error handling
Date: Tue, 8 May 2018 12:37:21 +0300 [thread overview]
Message-ID: <6eeed19a-f4ad-530d-bee5-926032f4d10f@gmail.com> (raw)
In-Reply-To: <20180508092739.GB661@mwanda>
On 05/08/2018 12:27 PM, Dan Carpenter wrote:
> The xen_drm_front_shbuf_alloc() function was returning a mix of error
> pointers and NULL and the the caller wasn't checking correctly. I've
> changed it to always return error pointer consistently.
>
> Fixes: c575b7eeb89f ("drm/xen-front: Add support for Xen PV display frontend")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thank you,
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> diff --git a/drivers/gpu/drm/xen/xen_drm_front_shbuf.c b/drivers/gpu/drm/xen/xen_drm_front_shbuf.c
> index d5705251a0d6..8099cb343ae3 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front_shbuf.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front_shbuf.c
> @@ -383,7 +383,7 @@ xen_drm_front_shbuf_alloc(struct xen_drm_front_shbuf_cfg *cfg)
>
> buf = kzalloc(sizeof(*buf), GFP_KERNEL);
> if (!buf)
> - return NULL;
> + return ERR_PTR(-ENOMEM);
>
> if (cfg->be_alloc)
> buf->ops = &backend_ops;
> diff --git a/drivers/gpu/drm/xen/xen_drm_front.c b/drivers/gpu/drm/xen/xen_drm_front.c
> index 8615e8522c7a..378cb7ce0db5 100644
> --- a/drivers/gpu/drm/xen/xen_drm_front.c
> +++ b/drivers/gpu/drm/xen/xen_drm_front.c
> @@ -188,8 +188,8 @@ int xen_drm_front_dbuf_create(struct xen_drm_front_info *front_info,
> buf_cfg.be_alloc = front_info->cfg.be_alloc;
>
> shbuf = xen_drm_front_shbuf_alloc(&buf_cfg);
> - if (!shbuf)
> - return -ENOMEM;
> + if (IS_ERR(shbuf))
> + return PTR_ERR(shbuf);
>
> ret = dbuf_add_to_list(front_info, shbuf, dbuf_cookie);
> if (ret < 0) {
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-05-08 9:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-08 9:27 [PATCH 2/3] drm/xen-front: fix xen_drm_front_shbuf_alloc() error handling Dan Carpenter
2018-05-08 9:37 ` Oleksandr Andrushchenko [this message]
2018-05-08 11:50 ` Oleksandr Andrushchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6eeed19a-f4ad-530d-bee5-926032f4d10f@gmail.com \
--to=andr2000@gmail.com \
--cc=airlied@linux.ie \
--cc=dan.carpenter@oracle.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).