From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 4/7] drm/omap: remove unused plugin defines
Date: Sun, 13 Dec 2015 22:34:08 +0200 [thread overview]
Message-ID: <7145322.j6BuzPHHDZ@avalon> (raw)
In-Reply-To: <1449675491-9184-5-git-send-email-tomi.valkeinen@ti.com>
Hi Tomi,
Thank you for the patch.
On Wednesday 09 December 2015 17:38:08 Tomi Valkeinen wrote:
> Remove unused defines related to SGX plugin which are not used.
>
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/omapdrm/omap_drv.h | 6 ------
> include/uapi/drm/omap_drm.h | 6 ------
> 2 files changed, 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/omapdrm/omap_drv.h
> b/drivers/gpu/drm/omapdrm/omap_drv.h index 5c367aad8a6e..038a27f349d9
> 100644
> --- a/drivers/gpu/drm/omapdrm/omap_drv.h
> +++ b/drivers/gpu/drm/omapdrm/omap_drv.h
> @@ -36,12 +36,6 @@
>
> #define MODULE_NAME "omapdrm"
>
> -/* max # of mapper-id's that can be assigned.. todo, come up with a better
> - * (but still inexpensive) way to store/access per-buffer mapper private
> - * data..
> - */
> -#define MAX_MAPPERS 2
> -
> /* parameters which describe (unrotated) coordinates of scanout within a
> fb: */ struct omap_drm_window {
> uint32_t rotation;
> diff --git a/include/uapi/drm/omap_drm.h b/include/uapi/drm/omap_drm.h
> index 1d0b1172664e..72e461e1e5bc 100644
> --- a/include/uapi/drm/omap_drm.h
> +++ b/include/uapi/drm/omap_drm.h
> @@ -101,9 +101,6 @@ struct drm_omap_gem_info {
>
> #define DRM_OMAP_GET_PARAM 0x00
> #define DRM_OMAP_SET_PARAM 0x01
> -/* placeholder for plugin-api
> -#define DRM_OMAP_GET_BASE 0x02
> -*/
> #define DRM_OMAP_GEM_NEW 0x03
> #define DRM_OMAP_GEM_CPU_PREP 0x04
> #define DRM_OMAP_GEM_CPU_FINI 0x05
> @@ -112,9 +109,6 @@ struct drm_omap_gem_info {
>
> #define DRM_IOCTL_OMAP_GET_PARAM DRM_IOWR(DRM_COMMAND_BASE +
> DRM_OMAP_GET_PARAM, struct drm_omap_param) #define
> DRM_IOCTL_OMAP_SET_PARAM DRM_IOW (DRM_COMMAND_BASE + DRM_OMAP_SET_PARAM,
> struct drm_omap_param) -/* placeholder for plugin-api
> -#define DRM_IOCTL_OMAP_GET_BASE DRM_IOWR(DRM_COMMAND_BASE +
> DRM_OMAP_GET_BASE, struct drm_omap_get_base) -*/
> #define DRM_IOCTL_OMAP_GEM_NEW DRM_IOWR(DRM_COMMAND_BASE +
> DRM_OMAP_GEM_NEW, struct drm_omap_gem_new) #define
> DRM_IOCTL_OMAP_GEM_CPU_PREP DRM_IOW (DRM_COMMAND_BASE +
> DRM_OMAP_GEM_CPU_PREP, struct drm_omap_gem_cpu_prep) #define
> DRM_IOCTL_OMAP_GEM_CPU_FINI DRM_IOW (DRM_COMMAND_BASE +
> DRM_OMAP_GEM_CPU_FINI, struct drm_omap_gem_cpu_fini)
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2015-12-14 1:36 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 15:38 [PATCH 0/7] drm/omap: misc patches Tomi Valkeinen
2015-12-09 15:38 ` [PATCH 1/7] drm/omap: ensure all displays have been probed Tomi Valkeinen
2015-12-13 20:30 ` Laurent Pinchart
2015-12-16 15:45 ` Tomi Valkeinen
2015-12-09 15:38 ` [PATCH 2/7] drm/omap: remove extra drm_gem_free_mmap_offset() call Tomi Valkeinen
2015-12-13 20:33 ` Laurent Pinchart
2015-12-09 15:38 ` [PATCH 3/7] drm/omap: Use bitmaps for TILER placement Tomi Valkeinen
2015-12-09 15:38 ` [PATCH 4/7] drm/omap: remove unused plugin defines Tomi Valkeinen
2015-12-13 20:34 ` Laurent Pinchart [this message]
2015-12-09 15:38 ` [PATCH 5/7] drm/omap: set DRIVER_ATOMIC for omapdrm Tomi Valkeinen
2015-12-13 20:34 ` Laurent Pinchart
2015-12-09 15:38 ` [PATCH 6/7] drm/omap: remove obsolete manager assignment Tomi Valkeinen
2015-12-09 15:38 ` [PATCH 7/7] drm/omap: fix fbdev pix format to support all platforms Tomi Valkeinen
2015-12-13 20:35 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7145322.j6BuzPHHDZ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox