From: Stefan Agner <stefan@agner.ch>
To: Ahmad Fatoum <a.fatoum@pengutronix.de>
Cc: Marek Vasut <marex@denx.de>, David Airlie <airlied@linux.ie>,
kernel@pengutronix.de, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 0/3] drm/mxsfb: support swapped RGB lanes
Date: Wed, 02 Jan 2019 22:05:31 +0100 [thread overview]
Message-ID: <719c261f00bef5b805bf74b53e7d6cc5@agner.ch> (raw)
In-Reply-To: <20190102170247.8208-1-a.fatoum@pengutronix.de>
On 02.01.2019 18:02, Ahmad Fatoum wrote:
> Hello,
>
> I got a board with the RED[0:7]/BLUE[0:7] lanes originating from the
> LCDIF swapped and would like to describe this in the device tree:
>
> This first patch extends the mxsfb driver to support
> following bus formats:
> MEDIA_BUS_FMT_BGR888_1X24
> MEDIA_BUS_FMT_RBG888_1X24
> MEDIA_BUS_FMT_GBR888_1X24
>
> The latter two patches add a new interface-pix-fmt property
> (named so because fsl,imx-parallel-display has one),
> which allows a device tree to override the bus format to account
> for swapped signal lanes.
>
> Thoughts?
On a quick glance patch 1 looks good.
However, patch 2/3 are probably unnecessary when using of graph/panel
support. E.g. panel-simple.c supports bus formats.
Is the display you are using regular RGB and only the board/connectors
happen to swap colors?
--
Stefan
>
> Cheers
> Ahmad
>
> --
>
> Ahmad Fatoum (3):
> drm/mxsfb: use bus_format to determine pixel RGB component order
> drm/mxsfb: implement interface-pix-fmt of_property to override bus
> format
> dt-bindings: mxsfb: document new interface-pix-fmt property
>
> .../devicetree/bindings/display/mxsfb.txt | 5 +++
> drivers/gpu/drm/mxsfb/mxsfb_crtc.c | 45 +++++++++++++++----
> drivers/gpu/drm/mxsfb/mxsfb_drv.c | 13 ++++++
> drivers/gpu/drm/mxsfb/mxsfb_drv.h | 7 +++
> drivers/gpu/drm/mxsfb/mxsfb_regs.h | 17 +++++++
> 5 files changed, 79 insertions(+), 8 deletions(-)
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2019-01-02 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-02 17:02 [PATCH 0/3] drm/mxsfb: support swapped RGB lanes Ahmad Fatoum
2019-01-02 17:02 ` [PATCH 1/3] drm/mxsfb: use bus_format to determine pixel RGB component order Ahmad Fatoum
2019-01-02 17:14 ` Ahmad Fatoum
2019-01-02 17:02 ` [PATCH 2/3] drm/mxsfb: implement interface-pix-fmt of_property to override bus format Ahmad Fatoum
2019-01-02 17:02 ` [PATCH 3/3] dt-bindings: mxsfb: document new interface-pix-fmt property Ahmad Fatoum
2019-01-02 21:05 ` Stefan Agner [this message]
2019-01-02 21:37 ` [PATCH 0/3] drm/mxsfb: support swapped RGB lanes Sam Ravnborg
2019-01-07 17:35 ` Ahmad Fatoum
2019-01-07 18:04 ` Sam Ravnborg
2019-03-27 14:26 ` Ahmad Fatoum
2019-01-03 9:59 ` Ahmad Fatoum
2019-03-27 14:30 ` Ahmad Fatoum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=719c261f00bef5b805bf74b53e7d6cc5@agner.ch \
--to=stefan@agner.ch \
--cc=a.fatoum@pengutronix.de \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@pengutronix.de \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox